| Message ID | 20170929100542.12849-11-a.hajda@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
2017년 09월 29일 19:05에 Andrzej Hajda 이(가) 쓴 글: > Since HDMI can handle these modes despite of MIXER limitations let's > enable them. > > Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> > Reviewed-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c > index 8baa93f80106..85d33137cfd8 100644 > --- a/drivers/gpu/drm/exynos/exynos_mixer.c > +++ b/drivers/gpu/drm/exynos/exynos_mixer.c > @@ -1014,6 +1014,9 @@ static int mixer_mode_valid(struct exynos_drm_crtc *crtc, > (w >= 1664 && w <= 1920 && h >= 936 && h <= 1080)) > return MODE_OK; > > + if ((w == 1024 && h == 768) || (w == 1280 && h == 1024)) > + return MODE_OK; mixer_mode_valid function is common to all Exynos SoC managed by Exynos DRM driver. So is it valid for all of them? Thanks, Inki Dae > + > return MODE_BAD; > } > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 17.10.2017 09:48, Inki Dae wrote: > > 2017년 09월 29일 19:05에 Andrzej Hajda 이(가) 쓴 글: >> Since HDMI can handle these modes despite of MIXER limitations let's >> enable them. >> >> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com> >> Reviewed-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de> >> --- >> drivers/gpu/drm/exynos/exynos_mixer.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c >> index 8baa93f80106..85d33137cfd8 100644 >> --- a/drivers/gpu/drm/exynos/exynos_mixer.c >> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c >> @@ -1014,6 +1014,9 @@ static int mixer_mode_valid(struct exynos_drm_crtc *crtc, >> (w >= 1664 && w <= 1920 && h >= 936 && h <= 1080)) >> return MODE_OK; >> >> + if ((w == 1024 && h == 768) || (w == 1280 && h == 1024)) >> + return MODE_OK; > mixer_mode_valid function is common to all Exynos SoC managed by Exynos DRM driver. > So is it valid for all of them? It is valid for all SoCs having mixer, it was tested on Odroid U3(Exynos4412) and XU3 (Exynos5422). Regards Andrzej > > Thanks, > Inki Dae > > > >> + >> return MODE_BAD; >> } >> >> > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index 8baa93f80106..85d33137cfd8 100644 --- a/drivers/gpu/drm/exynos/exynos_mixer.c +++ b/drivers/gpu/drm/exynos/exynos_mixer.c @@ -1014,6 +1014,9 @@ static int mixer_mode_valid(struct exynos_drm_crtc *crtc, (w >= 1664 && w <= 1920 && h >= 936 && h <= 1080)) return MODE_OK; + if ((w == 1024 && h == 768) || (w == 1280 && h == 1024)) + return MODE_OK; + return MODE_BAD; }