| Message ID | 20170930145454.sm2zpwonemlfsemo@vis (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Sat, Sep 30, 2017 at 04:54:54PM +0200, Jochen Sprickerhof wrote: > Without this, the USB3 and LAN ports don't show up. > > See also https://bugs.debian.org/843448 > > This was first proposed in https://lkml.org/lkml/2015/3/18/400 but for > exynos5420.dtsi. I only tested it on Odroid XU4, so I propose it only > for that board. Also I found the dis_u2_susphy_quirk to make no > difference, so it's not included. > > A second proposal is in https://lkml.org/lkml/2017/1/24/402, but only > for USB3, not for the LAN port. No external references in commit msg (if really needed it could go to BugLink but this should be just described here) and no links to lkml.org please (it just does not work, instead for example http://lkml.kernel.org/r/). It looks like already merged: https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/dt&id=3bf689f9275ff73de1ffad3e571837c8bff41d27 What is the difference? Best regards, Krzysztof > Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de> > --- > arch/arm/boot/dts/exynos5422-odroidxu4.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts > index 2faf88627a48..30fc4d35422e 100644 > --- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts > +++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts > @@ -43,6 +43,13 @@ > status = "okay"; > }; > > +&usbdrd_dwc3_0 { > + /* quirk is needed to make USB3 ports work */ > + snps,dis_u3_susphy_quirk; > +}; > + > &usbdrd_dwc3_1 { > dr_mode = "host"; > + /* quirk is needed to make LAN port work */ > + snps,dis_u3_susphy_quirk; > }; > -- > 2.14.2 > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
* Krzysztof Kozlowski <krzk@kernel.org> [2017-09-30 18:28]: >It looks like already merged: >https://git.kernel.org/pub/scm/linux/kernel/git/krzk/linux.git/commit/?h=next/dt&id=3bf689f9275ff73de1ffad3e571837c8bff41d27 > >What is the difference? Fine with my, just overlapped with my last search. Thank for the quick reply :). Cheers Jochen
diff --git a/arch/arm/boot/dts/exynos5422-odroidxu4.dts b/arch/arm/boot/dts/exynos5422-odroidxu4.dts index 2faf88627a48..30fc4d35422e 100644 --- a/arch/arm/boot/dts/exynos5422-odroidxu4.dts +++ b/arch/arm/boot/dts/exynos5422-odroidxu4.dts @@ -43,6 +43,13 @@ status = "okay"; }; +&usbdrd_dwc3_0 { + /* quirk is needed to make USB3 ports work */ + snps,dis_u3_susphy_quirk; +}; + &usbdrd_dwc3_1 { dr_mode = "host"; + /* quirk is needed to make LAN port work */ + snps,dis_u3_susphy_quirk; };
Without this, the USB3 and LAN ports don't show up. See also https://bugs.debian.org/843448 This was first proposed in https://lkml.org/lkml/2015/3/18/400 but for exynos5420.dtsi. I only tested it on Odroid XU4, so I propose it only for that board. Also I found the dis_u2_susphy_quirk to make no difference, so it's not included. A second proposal is in https://lkml.org/lkml/2017/1/24/402, but only for USB3, not for the LAN port. Signed-off-by: Jochen Sprickerhof <git@jochen.sprickerhof.de> --- arch/arm/boot/dts/exynos5422-odroidxu4.dts | 7 +++++++ 1 file changed, 7 insertions(+)