| Message ID | 20171218123805.26345-2-simon@lineageos.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Dec 18, 2017 at 11:38:02PM +1100, Simon Shields wrote: > Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along > with the shared "midas" binding. > > Signed-off-by: Simon Shields <simon@lineageos.org> > --- > Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++ > 1 file changed, 4 insertions(+) My comment on v2 remains. -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Rob, Thanks for the review. On Wed, Dec 20, 2017 at 12:17:59PM -0600, Rob Herring wrote: > On Mon, Dec 18, 2017 at 11:38:02PM +1100, Simon Shields wrote: > > Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along > > with the shared "midas" binding. > > > > Signed-off-by: Simon Shields <simon@lineageos.org> > > --- > > Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++ > > 1 file changed, 4 insertions(+) > > My comment on v2 remains. Do you have any example of a better description? All the other ARM board descriptions seem similarly terse. Alternatively, maybe changing the compatible strings is a better solution? "samsung,n710x" for t0, "samsung,i9300" for m0, and "samsung,i9305" for m3? Cheers, Simon -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, Dec 20, 2017 at 7:42 PM, Simon Shields <simon@lineageos.org> wrote: > Hi Rob, > > Thanks for the review. > > On Wed, Dec 20, 2017 at 12:17:59PM -0600, Rob Herring wrote: >> On Mon, Dec 18, 2017 at 11:38:02PM +1100, Simon Shields wrote: >> > Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along >> > with the shared "midas" binding. >> > >> > Signed-off-by: Simon Shields <simon@lineageos.org> >> > --- >> > Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++ >> > 1 file changed, 4 insertions(+) >> >> My comment on v2 remains. > > Do you have any example of a better description? All the other ARM board > descriptions seem similarly terse. > > Alternatively, maybe changing the compatible strings is a better > solution? "samsung,n710x" for t0, "samsung,i9300" for m0, and > "samsung,i9305" for m3? Yes, it was the compatible string I was commenting on. I don't really care about the description because for most boards I have no idea what they are. Rob -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt index e13459618581..9457c1dcb1e6 100644 --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt @@ -9,7 +9,11 @@ Required root node properties: - "samsung,smdkv310" - for Exynos4210-based Samsung SMDKV310 eval board. - "samsung,trats" - for Exynos4210-based Tizen Reference board. - "samsung,universal_c210" - for Exynos4210-based Samsung board. + - "samsung,m0" - for Exynos4412-based Samsung GT-I9300 board, codenamed M0. + - "samsung,m3" - for Exynos4412-based Samsung GT-I9305 board, codenamed M3. + - "samsung,midas" - for Exynos4412-based Samsung Midas board. - "samsung,smdk4412", - for Exynos4412-based Samsung SMDK4412 eval board. + - "samsung,t0" - for Exynos4412-based Samsung GT-N7100/GT-N7105 board, codenamed T0. - "samsung,trats2" - for Exynos4412-based Tizen Reference board. - "samsung,smdk5250" - for Exynos5250-based Samsung SMDK5250 eval board. - "samsung,xyref5260" - for Exynos5260-based Samsung board.
Document GT-I9300, GT-I9305, GT-N7100, and GT-N7105 bindings, along with the shared "midas" binding. Signed-off-by: Simon Shields <simon@lineageos.org> --- Documentation/devicetree/bindings/arm/samsung/samsung-boards.txt | 4 ++++ 1 file changed, 4 insertions(+)