diff mbox

ARM: dts: exynos: Update x and y properties for mms114 touchscreen

Message ID 20180126060454.18082-1-andi.shyti@samsung.com (mailing list archive)
State Superseded
Headers show

Commit Message

Andi Shyti Jan. 26, 2018, 6:04 a.m. UTC
The mms114 binding [1] specifies that the 'x' and 'y' should be
called respectively 'touchscreen-size-x' and 'touchscreen-size-y'
in coherence with the touchscreen [2] binding.

Update the mms114 node for trats2 and trats dts according to the
binding.

[1] Documentation/devicetree/bindings/input/touchscreen/mms114.txt
[2] Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
Hi Krzysztof,

this patch depends on Simon's patchset [1] and must be applied after
that. If you want I can ping you when the patch gets or you can take
it in the next cycle.

Andi

[1] https://marc.info/?l=linux-kernel&m=151682273403098&w=2

 arch/arm/boot/dts/exynos4210-trats.dts  | 4 ++--
 arch/arm/boot/dts/exynos4412-trats2.dts | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Krzysztof Kozlowski Jan. 26, 2018, 8:10 a.m. UTC | #1
On Fri, Jan 26, 2018 at 7:04 AM, Andi Shyti <andi.shyti@samsung.com> wrote:
> The mms114 binding [1] specifies that the 'x' and 'y' should be
> called respectively 'touchscreen-size-x' and 'touchscreen-size-y'
> in coherence with the touchscreen [2] binding.
>
> Update the mms114 node for trats2 and trats dts according to the
> binding.
>
> [1] Documentation/devicetree/bindings/input/touchscreen/mms114.txt
> [2] Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
> Hi Krzysztof,
>
> this patch depends on Simon's patchset [1] and must be applied after
> that. If you want I can ping you when the patch gets or you can take
> it in the next cycle.
>
> Andi

Thanks, looks good. Indeed I would appreciate if you gave me a ping
once dependency gets into Linus's tree.

Best regards,
Krzysztof

>
> [1] https://marc.info/?l=linux-kernel&m=151682273403098&w=2
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski April 17, 2018, 3:32 p.m. UTC | #2
On Fri, Jan 26, 2018 at 03:04:54PM +0900, Andi Shyti wrote:
> The mms114 binding [1] specifies that the 'x' and 'y' should be
> called respectively 'touchscreen-size-x' and 'touchscreen-size-y'
> in coherence with the touchscreen [2] binding.
> 
> Update the mms114 node for trats2 and trats dts according to the
> binding.
> 
> [1] Documentation/devicetree/bindings/input/touchscreen/mms114.txt
> [2] Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> ---
> Hi Krzysztof,
> 
> this patch depends on Simon's patchset [1] and must be applied after
> that. If you want I can ping you when the patch gets or you can take
> it in the next cycle.
> 
> Andi
> 
> [1] https://marc.info/?l=linux-kernel&m=151682273403098&w=2
>

Hi Andi,

As I understand, the dependencies are in and I can take this?

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Andi Shyti April 17, 2018, 6:06 p.m. UTC | #3
Hi Krzysztof,

On 18.04.2018 00:32, Krzysztof Kozlowski wrote:
> On Fri, Jan 26, 2018 at 03:04:54PM +0900, Andi Shyti wrote:
>> The mms114 binding [1] specifies that the 'x' and 'y' should be
>> called respectively 'touchscreen-size-x' and 'touchscreen-size-y'
>> in coherence with the touchscreen [2] binding.
>> 
>> Update the mms114 node for trats2 and trats dts according to the
>> binding.
>> 
>> [1] Documentation/devicetree/bindings/input/touchscreen/mms114.txt
>> [2] 
>> Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
>> 
>> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
>> ---
>> Hi Krzysztof,
>> 
>> this patch depends on Simon's patchset [1] and must be applied after
>> that. If you want I can ping you when the patch gets or you can take
>> it in the next cycle.
>> 
>> Andi
>> 
>> [1] https://marc.info/?l=linux-kernel&m=151682273403098&w=2
>> 
> 
> Hi Andi,
> 
> As I understand, the dependencies are in and I can take this?

Thanks a lot, somehow I missed it,

Please take it.

Thank you,
Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Krzysztof Kozlowski April 17, 2018, 7:46 p.m. UTC | #4
On Wed, Apr 18, 2018 at 03:06:39AM +0900, andi@etezian.org wrote:
> Hi Krzysztof,
> 
> On 18.04.2018 00:32, Krzysztof Kozlowski wrote:
> > On Fri, Jan 26, 2018 at 03:04:54PM +0900, Andi Shyti wrote:
> > > The mms114 binding [1] specifies that the 'x' and 'y' should be
> > > called respectively 'touchscreen-size-x' and 'touchscreen-size-y'
> > > in coherence with the touchscreen [2] binding.
> > > 
> > > Update the mms114 node for trats2 and trats dts according to the
> > > binding.
> > > 
> > > [1] Documentation/devicetree/bindings/input/touchscreen/mms114.txt
> > > [2]
> > > Documentation/devicetree/bindings/input/touchscreen/touchscreen.txt
> > > 
> > > Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
> > > ---
> > > Hi Krzysztof,
> > > 
> > > this patch depends on Simon's patchset [1] and must be applied after
> > > that. If you want I can ping you when the patch gets or you can take
> > > it in the next cycle.
> > > 
> > > Andi
> > > 
> > > [1] https://marc.info/?l=linux-kernel&m=151682273403098&w=2
> > > 
> > 
> > Hi Andi,
> > 
> > As I understand, the dependencies are in and I can take this?
> 
> Thanks a lot, somehow I missed it,
> 
> Please take it.

Unfortunately it does not apply anymore. Probably because the Trats2 DTS
was renamed.  Also another board was added so please rebase on v4.17-rc1
or linux-next.

Best regards,
Krzysztof

--
To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/arch/arm/boot/dts/exynos4210-trats.dts b/arch/arm/boot/dts/exynos4210-trats.dts
index 7b6ab7265110..fc71a493b5cb 100644
--- a/arch/arm/boot/dts/exynos4210-trats.dts
+++ b/arch/arm/boot/dts/exynos4210-trats.dts
@@ -261,8 +261,8 @@ 
 		reg = <0x48>;
 		interrupt-parent = <&gpx0>;
 		interrupts = <4 IRQ_TYPE_EDGE_FALLING>;
-		x-size = <720>;
-		y-size = <1280>;
+		touchscreen-size-x = <720>;
+		touchscreen-size-y = <1280>;
 		avdd-supply = <&tsp_reg>;
 		vdd-supply = <&tsp_reg>;
 	};
diff --git a/arch/arm/boot/dts/exynos4412-trats2.dts b/arch/arm/boot/dts/exynos4412-trats2.dts
index 220cdf109405..1808c4951538 100644
--- a/arch/arm/boot/dts/exynos4412-trats2.dts
+++ b/arch/arm/boot/dts/exynos4412-trats2.dts
@@ -635,8 +635,8 @@ 
 		reg = <0x48>;
 		interrupt-parent = <&gpm2>;
 		interrupts = <3 IRQ_TYPE_EDGE_FALLING>;
-		x-size = <720>;
-		y-size = <1280>;
+		touchscreen-size-x = <720>;
+		touchscreen-size-y = <1280>;
 		avdd-supply = <&ldo23_reg>;
 		vdd-supply = <&ldo24_reg>;
 	};