From patchwork Tue Feb 27 12:22:07 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrzej Hajda X-Patchwork-Id: 10245047 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A93F760208 for ; Tue, 27 Feb 2018 12:22:34 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 95B5120952 for ; Tue, 27 Feb 2018 12:22:34 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8948723794; Tue, 27 Feb 2018 12:22:34 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F072C20952 for ; Tue, 27 Feb 2018 12:22:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752557AbeB0MWW (ORCPT ); Tue, 27 Feb 2018 07:22:22 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:53588 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752049AbeB0MWU (ORCPT ); Tue, 27 Feb 2018 07:22:20 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20180227122217euoutp0263435189cc87d00473cdd6ef0a03e223~XLiVub8uW1494814948euoutp02r; Tue, 27 Feb 2018 12:22:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20180227122217euoutp0263435189cc87d00473cdd6ef0a03e223~XLiVub8uW1494814948euoutp02r DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1519734137; bh=Mi8ycMvgA8e4rteBRO6BaKSxwGFllLz590urBEJMLis=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=O+6OOU7nVxilz4TowPN59edt8ptHaaqA+RzlCVttKfDIKwEuY58bUpuMh+8aW55cX VVyb6R+NrgnK5/AiOiu+ytBNwldetyz3cljP0CUQyr4SHtcjhDTfbwhQmIJ4jk7w7O Z4rNunzMnpj67OXyTeCxkmT0FHu2i5V3wV/adI+Q= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20180227122216eucas1p254bdb1eff6b00bb7a91812bdd02c6592~XLiU242eU0469904699eucas1p2J; Tue, 27 Feb 2018 12:22:16 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 02.AD.05700.87D459A5; Tue, 27 Feb 2018 12:22:16 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180227122215eucas1p11a1a12c26665f032c666d10effaf15fc~XLiUCKNRq2465724657eucas1p1c; Tue, 27 Feb 2018 12:22:15 +0000 (GMT) X-AuditID: cbfec7f2-1dbff70000011644-21-5a954d783c3b Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id F0.2D.04183.77D459A5; Tue, 27 Feb 2018 12:22:15 +0000 (GMT) Received: from AMDC2768.DIGITAL.local ([106.120.43.17]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P4T00BY46D2WF00@eusync1.samsung.com>; Tue, 27 Feb 2018 12:22:15 +0000 (GMT) From: Andrzej Hajda To: devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS) Cc: Andrzej Hajda , Bartlomiej Zolnierkiewicz , Marek Szyprowski , dri-devel@lists.freedesktop.org, Inki Dae , Rob Herring , Mark Rutland , Krzysztof Kozlowski , Chanwoo Choi , Archit Taneja , Laurent Pinchart , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH v6 5/6] extcon: add possibility to get extcon device by OF node Date: Tue, 27 Feb 2018 13:22:07 +0100 Message-id: <20180227122207.23056-1-a.hajda@samsung.com> X-Mailer: git-send-email 2.16.2 In-reply-to: <5A953AF2.6030501@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrEIsWRmVeSWpSXmKPExsWy7djPc7oVvlOjDBZOEba4te4cq0VTx1tW i40z1rNaXP/ynNVi/hGg2JWv79ksJt2fwGJx/vwGdovOiUvYLTY9vsZqcXnXHDaLGef3MVks WtbKbLH2yF12i6XXLzJZtO49wu4g4LFm3hpGj8t9vUwesztmsnpsWtXJ5nG/+ziTx+Yl9R59 W1YxenzeJBfAEcVlk5Kak1mWWqRvl8CVcWzid/aC+dIVf/snMjUwvhHrYuTkkBAwkdjfsZml i5GLQ0hgBaPEjnvboJzPjBL3ryxjhanqm7qRFSKxjFHi3pSjUM5/RolF/z+xgFSxCWhK/N18 kw3EFhGIlXh3aRczSBGzwAUWiQunX7GDJIQFAiX+Xf/JBGKzCKhKfJvwmxHE5hWwkFi5dhEz xDp5iYVnr4LZnALaEj9PX2MHGSQhcJ9N4tmkuywQRS4S6z9ugbKFJV4d38IOYctIXJ7czQLR 0M0ocWpfJzOEM4VR4vyry0wQVdYSh49fBPuOWYBPYtK26UBFHEBxXomONiGIEg+J3W/+QAPA EcjuAmsVEqiTWPF8IfsERqkFjAyrGMVTS4tz01OLDfNSy/WKE3OLS/PS9ZLzczcxAlPC6X/H P+1g/Hop6RCjAAejEg/vDLkpUUKsiWXFlbmHGCU4mJVEeFcunhwlxJuSWFmVWpQfX1Sak1p8 iFGag0VJnDdOoy5KSCA9sSQ1OzW1ILUIJsvEwSnVwBgzR/NyRj/37Mmr2gTrldTlz59o9nkb JRAw1fjMkerWN6wxMfsY19cVHJ8du3hqxC1jwR+3eY51sfBuOvzr6ATFTSJiGqfj64wnWG7g TTzF+Ya7tcqukM9Gd3WoccfCwG7Td7Yb2MwLfh2z9VkjOYn9bnKSoNQz/5/rr9flJ7YGF5e/ dLn9SImlOCPRUIu5qDgRAMJ1sq8FAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t/xy7rlvlOjDN6eULe4te4cq0VTx1tW i40z1rNaXP/ynNVi/hGg2JWv79ksJt2fwGJx/vwGdovOiUvYLTY9vsZqcXnXHDaLGef3MVks WtbKbLH2yF12i6XXLzJZtO49wu4g4LFm3hpGj8t9vUwesztmsnpsWtXJ5nG/+ziTx+Yl9R59 W1YxenzeJBfAEcVlk5Kak1mWWqRvl8CVcWzid/aC+dIVf/snMjUwvhHrYuTkkBAwkeibupG1 i5GLQ0hgCaPE15dboZxGJolz+6awglSxCWhK/N18kw3EFhGIlXh76jMzSBGzwAUWid8TZ7KD JIQF/CVmv2thBrFZBFQlvk34zQhi8wpYSKxcu4gZYp28xMKzV8FsTgFtiZ+nr4H1CgloSWw7 vphxAiPPAkaGVYwiqaXFuem5xUZ6xYm5xaV56XrJ+bmbGIFBu+3Yzy07GLveBR9iFOBgVOLh nSE3JUqINbGsuDL3EKMEB7OSCO/KxZOjhHhTEiurUovy44tKc1KLDzFKc7AoifOeN6iMEhJI TyxJzU5NLUgtgskycXBKNTBGrKpfZp+65OahN2tT54cozi4L/PFHIU/lywcWhmeq2leLDXhm Cqzg7djxd4PYW4nMqDvu2UJqfNuP97mqu1zR3HbhfP58TvsUxiXuCQkyTwQuC8ttiPl+j2el nGLFPj09q1/GZ/fefvSq8Od21x+cifYCy3exF0ypbjvW8Emk+qX1rbuXZu9UYinOSDTUYi4q TgQAxIwaclYCAAA= X-CMS-MailID: 20180227122215eucas1p11a1a12c26665f032c666d10effaf15fc X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180227122215eucas1p11a1a12c26665f032c666d10effaf15fc X-RootMTR: 20180227122215eucas1p11a1a12c26665f032c666d10effaf15fc References: <5A953AF2.6030501@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since extcon property is not allowed in DT, extcon subsystem requires another way to get extcon device. Lets try the simplest approach - get edev by of_node. Signed-off-by: Andrzej Hajda Acked-by: Chanwoo Choi --- v5: function renamed to extcon_find_edev_by_node (Andy) v2: changed label to follow local convention (Chanwoo) --- drivers/extcon/extcon.c | 44 ++++++++++++++++++++++++++++++++++---------- include/linux/extcon.h | 6 ++++++ 2 files changed, 40 insertions(+), 10 deletions(-) diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c index cb38c2747684..8bff5fd18185 100644 --- a/drivers/extcon/extcon.c +++ b/drivers/extcon/extcon.c @@ -1336,6 +1336,28 @@ void extcon_dev_unregister(struct extcon_dev *edev) EXPORT_SYMBOL_GPL(extcon_dev_unregister); #ifdef CONFIG_OF + +/* + * extcon_find_edev_by_node - Find the extcon device from devicetree. + * @node : OF node identifying edev + * + * Return the pointer of extcon device if success or ERR_PTR(err) if fail. + */ +struct extcon_dev *extcon_find_edev_by_node(struct device_node *node) +{ + struct extcon_dev *edev; + + mutex_lock(&extcon_dev_list_lock); + list_for_each_entry(edev, &extcon_dev_list, entry) + if (edev->dev.parent && edev->dev.parent->of_node == node) + goto out; + edev = ERR_PTR(-EPROBE_DEFER); +out: + mutex_unlock(&extcon_dev_list_lock); + + return edev; +} + /* * extcon_get_edev_by_phandle - Get the extcon device from devicetree. * @dev : the instance to the given device @@ -1363,25 +1385,27 @@ struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) return ERR_PTR(-ENODEV); } - mutex_lock(&extcon_dev_list_lock); - list_for_each_entry(edev, &extcon_dev_list, entry) { - if (edev->dev.parent && edev->dev.parent->of_node == node) { - mutex_unlock(&extcon_dev_list_lock); - of_node_put(node); - return edev; - } - } - mutex_unlock(&extcon_dev_list_lock); + edev = extcon_find_edev_by_node(node); of_node_put(node); - return ERR_PTR(-EPROBE_DEFER); + return edev; } + #else + +struct extcon_dev *extcon_find_edev_by_node(struct device_node *node) +{ + return ERR_PTR(-ENOSYS); +} + struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) { return ERR_PTR(-ENOSYS); } + #endif /* CONFIG_OF */ + +EXPORT_SYMBOL_GPL(extcon_find_edev_by_node); EXPORT_SYMBOL_GPL(extcon_get_edev_by_phandle); /** diff --git a/include/linux/extcon.h b/include/linux/extcon.h index 6d94e82c8ad9..7f033b1ea568 100644 --- a/include/linux/extcon.h +++ b/include/linux/extcon.h @@ -230,6 +230,7 @@ extern void devm_extcon_unregister_notifier_all(struct device *dev, * Following APIs get the extcon_dev from devicetree or by through extcon name. */ extern struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name); +extern struct extcon_dev *extcon_find_edev_by_node(struct device_node *node); extern struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index); @@ -283,6 +284,11 @@ static inline struct extcon_dev *extcon_get_extcon_dev(const char *extcon_name) return ERR_PTR(-ENODEV); } +static inline struct extcon_dev *extcon_find_edev_by_node(struct device_node *node) +{ + return ERR_PTR(-ENODEV); +} + static inline struct extcon_dev *extcon_get_edev_by_phandle(struct device *dev, int index) {