From patchwork Mon Mar 5 08:57:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 10258425 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E685A602BD for ; Mon, 5 Mar 2018 08:58:11 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D4C2D2895B for ; Mon, 5 Mar 2018 08:58:11 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id C962328995; Mon, 5 Mar 2018 08:58:11 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7175B2895B for ; Mon, 5 Mar 2018 08:58:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933267AbeCEI6K (ORCPT ); Mon, 5 Mar 2018 03:58:10 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:39579 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933484AbeCEI6I (ORCPT ); Mon, 5 Mar 2018 03:58:08 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout1.w1.samsung.com (KnoxPortal) with ESMTP id 20180305085806euoutp0189b881be9349d1786edfe33aa7bee9a5~Y_nxjhJF72395923959euoutp01r; Mon, 5 Mar 2018 08:58:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20180305085806euoutp0189b881be9349d1786edfe33aa7bee9a5~Y_nxjhJF72395923959euoutp01r DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1520240286; bh=VoV2r9QqDDw8wZkPMQXb+P1SYVLEOxIzLC4YxQYcNNs=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=l9ZtphTYdqlKy2hKFF1LIlVXpkGUDigBySLEoMJsQxblrdLmp8BSr+IEQIPfZvlUh 1zAZ8Ras6JCCufPKQDiRDsAKSp7IzkIZJZoMoAfr/xpLj6LODkyAQmc/hazl4hDAnY AfFqyArMEwQ0tkHykefLHOJ+SuNCQCdupTJcSBdY= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180305085805eucas1p12f8053e4ee947d993f37c0e31fa56b12~Y_nwpyVjC1090610906eucas1p1g; Mon, 5 Mar 2018 08:58:05 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id A1.C6.17380.D960D9A5; Mon, 5 Mar 2018 08:58:05 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20180305085804eucas1p10709830a36b02a28a6cb74827968f64d~Y_nvxqmd81411514115eucas1p1J; Mon, 5 Mar 2018 08:58:04 +0000 (GMT) X-AuditID: cbfec7f4-6f9ff700000043e4-1d-5a9d069d8e8a Received: from eusync1.samsung.com ( [203.254.199.211]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 69.74.04183.C960D9A5; Mon, 5 Mar 2018 08:58:04 +0000 (GMT) MIME-version: 1.0 Content-transfer-encoding: 8BIT Content-type: text/plain; charset="UTF-8" Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0P5400MEY0WMAI90@eusync1.samsung.com>; Mon, 05 Mar 2018 08:58:04 +0000 (GMT) From: Marek Szyprowski To: dri-devel@lists.freedesktop.org, linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org Cc: Marek Szyprowski , Archit Taneja , =?UTF-8?q?Heiko=20St=C3=BCbner?= , Thierry Escande , Tomasz Figa , Sean Paul , Bartlomiej Zolnierkiewicz , Laurent Pinchart , Thierry Reding , Sandy Huang , Enric Balletbo i Serra , Andrzej Hajda , Douglas Anderson , Haixia Shi , Zain Wang , Lin Huang , =?UTF-8?q?St=C3=A9phane=20Marchesin?= , Caesar Wang Subject: [PATCH 1/3] drm/bridge: analogix_dp: Don't power bridge in analogix_dp_bind Date: Mon, 05 Mar 2018 09:57:39 +0100 Message-id: <20180305085741.18896-2-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.15.0 In-reply-to: <20180305085741.18896-1-m.szyprowski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA01Sa0hTYRjuO7cdtVNns/Ltag2CLmbZjS+yKFA4EVFR9GOCtfIwxTllU8ug Gpk2LZfT7DIvdBlSYjc1XWarliloq8xS1GYZIV0chjNUKs15ivr3fM/l5XlfPpZUdNKz2Dhd sqjXqbVKxp+qbhh5sayYKVatOG9mcOfN5zQ+bvLQ+M6FWzR2lT5m8Ovv/Qwu73IiPPbhK42L 847g4dtNJD5Z9YHAWRabDA+8HyPxhRcOAt+od8twifMHwu7bLoS9GaMMPvPmFYNHaksofDK9 lMCZ7TM2TRcKjS2U0GrOIQS724aEe1a3TCg0XaSFd6caCaHSdkz4ZX1ICeaqMiTUtJWQgrdi 3o4AlX94jKiNSxX1yzfu8491tlvIJBd3qL/ZRRlRW0A28mOBXw2Pn9aR2cifVfDXEBQ+MlPS w4ug92Mh+uuqrytjJKEUgbHuG+kTOF4Ow/nd4wmWJflgqH8V76NJfjHcvX9LJvmNBLz92cX4 BIYPg2xP9gSexmthwNSHpEABAxY3+HAgvwcyh1soH6b4hdDzMp3wzef4DfDeoZP6BMPVoXsT Y/z4jVB0uWFiA+CbZDCWc/xP6QjwOE2EhAPhS2OVTMJzoDX/FCXhY2Aeqiek8GkED04U/Ams hyeNLbRUbgrkVZ8nfSWA58CUqZAsAhizummJ3gzXexJ9tIK3IGhum5eL5lr/u5D134Ws/13o EiLLUJCYYkjQiIaVOvFgqEGdYEjRaUIPJCZUoPEf1zzaOGhHtT/3OxHPIuVkzq4rUilodaoh LcGJgCWV07hU7zjFxajTDov6xL36FK1ocKLZLKUM4qIXHVUpeI06WYwXxSRR/1clWL9ZRrTO EeOS14i13l3ykeTIjkkZF+XLO5YO7MafB642KCodM6vjy4MiX0ZVpO1MCb8y4m6qIYwncgbL d1Z2RkesimtV3Xm2brA6wGLXhIZsi+1enXUuUv4mj8wyfbI5pvauba0KORu1fcGh+b9yPeHO h21bf0xaU8llaLS2vgPpn7eEdygpQ6w6bAmpN6h/AxPdO4ptAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrHIsWRmVeSWpSXmKPExsVy+t/xy7pz2OZGGTTuE7O4te4cq0VTx1tW i40z1rNanF12kM3iytf3bBZrbh9itPj/6DWrxdxJtRY/Npxitmjf8ojJonPiEnaLTw/+M1vM OL+PyWLtkbvsFvMO/Wa0uLvhLKPF59Z/bBb9Vy+xWfzcNY/For15GZNF23UxB1GP2Q0XWTwu 9/Uyeey4u4TRY+esu+wesztmsnrc7z7O5LF5Sb3H31n7WTz6tqxi9Nh+bR6zx+dNcgHcUVw2 Kak5mWWpRfp2CVwZh65PZC44y1vx/vRZlgbGa9xdjJwcEgImEkf2rGLrYuTiEBJYwihx5OIq JpAEr4CgxI/J91i6GDk4mAXkJY5cygYJMwuoS0yat4gZor6JSeL9z9tsIAk2AUOJrrddYLaI QI7E4u/TwYYyC8xkk1j26R5YQlggTKLtx0UWEJtFQFXi4YVmJpAFvAK2Eg/25UEcJA/UuxOs nFPATmLOwmPMILYQUMm9x/eYJzDyz0Jy3iyE82YhOW8BI/MqRpHU0uLc9NxiI73ixNzi0rx0 veT83E2MwFjcduznlh2MXe+CDzEKcDAq8fAKFM6JEmJNLCuuzD3EKMHBrCTCW/YZKMSbklhZ lVqUH19UmpNafIhRmoNFSZz3vEFllJBAemJJanZqakFqEUyWiYNTqoHReKWYyeOsphf2k7KN OEOtGue822ilFapRa/LnW3bsos3bKn48bxRZ+elaUs71gl3Hm4IF/n85Jqp/I9pEXr5Nr1JX YWZykeQpqy37H9at99ng6Gb67qYr8+cWEdOiXZolPZ5Kp1MXfBHRrs05dfjKPtni9+nTBRY4 XZlqte77AfapLxeUTpyvxFKckWioxVxUnAgA3AANZsECAAA= X-CMS-MailID: 20180305085804eucas1p10709830a36b02a28a6cb74827968f64d X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20180305085804eucas1p10709830a36b02a28a6cb74827968f64d X-RootMTR: 20180305085804eucas1p10709830a36b02a28a6cb74827968f64d References: <20180305085741.18896-1-m.szyprowski@samsung.com> Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: zain wang The bridge does not need to be powered in analogix_dp_bind(), so remove the calls to pm_runtime_get()/phy_power_on()/analogix_dp_init_dp() as well as their power-off counterparts. Cc: Stéphane Marchesin Signed-off-by: zain wang Signed-off-by: Caesar Wang [the patch originally just removed the power_on portion, seanpaul removed the power off code as well as improved the commit message] Signed-off-by: Sean Paul Signed-off-by: Thierry Escande Signed-off-by: Marek Szyprowski Tested-by: Heiko Stuebner Reviewed-by: Heiko Stuebner --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 3f7a796b27e4..8475749baae5 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1378,11 +1378,6 @@ analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, pm_runtime_enable(dev); - pm_runtime_get_sync(dev); - phy_power_on(dp->phy); - - analogix_dp_init_dp(dp); - ret = devm_request_threaded_irq(&pdev->dev, dp->irq, analogix_dp_hardirq, analogix_dp_irq_thread, @@ -1410,15 +1405,10 @@ analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, goto err_disable_pm_runtime; } - phy_power_off(dp->phy); - pm_runtime_put(dev); - return dp; err_disable_pm_runtime: - phy_power_off(dp->phy); - pm_runtime_put(dev); pm_runtime_disable(dev); return ERR_PTR(ret);