| Message ID | 20180518080445.GB28335@mwanda (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
2018년 05월 18일 17:04에 Dan Carpenter 이(가) 쓴 글: > "id" needs to be signed for the error handling to work. Applied to exynos-drm-fixes-v4.18-rc1. Thanks, Inki Dae > > Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c > index 4dfbfc7f3b84..5ce84025d1cb 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c > @@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx) > > int exynos_drm_check_fimc_device(struct device *dev) > { > - unsigned int id = of_alias_get_id(dev->of_node, "fimc"); > + int id = of_alias_get_id(dev->of_node, "fimc"); > > if (id >= 0 && (BIT(id) & fimc_mask)) > return 0; > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimc.c b/drivers/gpu/drm/exynos/exynos_drm_fimc.c index 4dfbfc7f3b84..5ce84025d1cb 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimc.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimc.c @@ -1200,7 +1200,7 @@ static int fimc_setup_clocks(struct fimc_context *ctx) int exynos_drm_check_fimc_device(struct device *dev) { - unsigned int id = of_alias_get_id(dev->of_node, "fimc"); + int id = of_alias_get_id(dev->of_node, "fimc"); if (id >= 0 && (BIT(id) & fimc_mask)) return 0;
"id" needs to be signed for the error handling to work. Fixes: 7a2d5c77c558 ("drm/exynos: fimc: Convert driver to IPP v2 core API") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html