From patchwork Thu Jul 26 16:17:49 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546121 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6FA3C112E for ; Thu, 26 Jul 2018 16:18:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F44F2A514 for ; Thu, 26 Jul 2018 16:18:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 521112B898; Thu, 26 Jul 2018 16:18:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DFA822A514 for ; Thu, 26 Jul 2018 16:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731803AbeGZRgO (ORCPT ); Thu, 26 Jul 2018 13:36:14 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgO (ORCPT ); Thu, 26 Jul 2018 13:36:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sGPAb3GohodAk8ybrbheLMKhexV9LGF4tVcCwI9+U0g=; b=LGsP9Gq5OYZJ9M4LSG5iOZKKquuC05xE6Nezd5CPehduUwY7IBbLPRNTB4wyXhBaF9FA+nGH7PXWyD0qqI9kSkDLr6i+eNAOk179WK2EXtqcwyRLnm0PhG0cwfYRbEIbYlNGh2/u1pdG11ZffJDnypTWMgSpCcpIpSBxOZPOc1c= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:33 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 03/10] drm: mali-dp: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:49 +0100 Message-Id: <20180726161756.1794-4-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 22e419bb-84e7-404d-625c-08d5f3136fb2 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:sPmw9PAVGNBsg09ZGe486aA0GsPaiHNf9sGrxu4unPY9dcvDeyJq9EiALR1BjD9azdQ/Dsmj3rE8S+g8iiqe9wbMjmoOxqfLb1pHldiB3J/pRoEFDjtoLDxKkzdS5hjbe96i+7QJOmfpu3UkfsVU+PPhl4PAR7T3yiRQEXwRgbR77axF2OOx9n9VSRrSsMi2arpO/uXGgOgYUDMHh130FlcwociCvHhzSKTRhKu0Rx0nInlrxS5AFwZy0FzPWbM9;25:YmzCIPXWPMf2pDREMk18Dsw66RsecjOIGPS+9SQySj4ZNDL/KnXWKnm+Qc7bAJzvbCM42coWkJztfYp77rXoEXJr/4uFnzCkBIVzG6mebuqSlKeoAhf0rD9SZPCYJGAtVv22DvbWsss5C5zIxa4fQL2Ecj1jOThfFdhbkVoliZp5BeOg+ZF/4fKWUvKULSpbbJzjVzRvmvvrUzRh7zfJEz//AndQG+DCLXeogUErcLoa18jmnFwNa2uMHQGialfCLB63Z7RP4egj+mnzcWeuYGCK7eA8TkCrIWZjckfVOwmt9bVJsJ2Yn8EGj6AAW2g6I1+Lr8/ys5K14ocd8HDgZA==;31:N3hpIK35cmvqj8X33KoGlR2GCcLp1DZG7C4dd99fqblDR5g3IzxgqrmbZ9L7V9rkk3qV+5MCs9hHUr3Y8y6IYJyQacCvU96jcePyaH8MXS1W4IPdZl2T4HVOssCyM3zz+jgYnHaKXGSov5SEHKu796FArL+3rAKVh1WKSSrjpe52/vPgXGjLGDRW5B8/254gNvwX1JiPTsMfQHtEXgIUwJcm+1kenJexK1ccO0KIsiQ= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:RInirCzzPFJuztZAWd2neWNEt9zBr1qDX0VFU2Jp8GogQWH2KKVcVHUfHz5uXha7wYKOU0S9RE6Q7SybzRv/osXNqi5174Ulr/cuT7wprtv+MjDOWMlNk4n8x69oS/h0p0sc/XqVXOoS3awfdUIlX8Lv9AFzmL8FV8PvQCb2FNuLDEF3PE/kgybnwsh+E+1UDgjtHZ6azm1HQu8POrPAEiP4L6V/0oAczyU/nkobYiyn468gKCRGmme2WNIDCa5fX5TZ30aLTkSOKV6yNJDPyObEmRe7zTD1frBcgn8apCQd5I4eUhUM+CHU7XlJU/226CiRc+170TIa8B0ajBVRsg==;4:I4K/e+I9drcHSej1ay4PIY6/0UeVhNxWk0WKUTaNrfwFcHMtYUYbBKvFmdCC/TcJWiUtnArwBEORCshjN7vY9gt1ex3V+WAomrN8/0iny3gGrBajwKQuJK8E4dOHCUZX7SbZKc4qD+9IR0f/Au9gHPn0Dn29qCfaTerXq1EMRY1mI/Aa1L0r+oTh34QxJu5b0mO6rTIhMSvEH6aaKcu1VLFKwhMehzJTLmL7LMbM5x/J8D2NPDm0MLtQBcS18SSblaVAaSYsjT4EfqxrF44uJJWKI04IQObeRelIcPHXDs6EeeKyRTiF8cGis9SOLTIc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:HfkrphFBOPsgZGxoHVsrbjBVq9xzcjwViECAncKvtTsG/6pBiwYqk2AQ7HCITCASPnSP8ehYMcX8IMCPHYTJnwMk0a/QkutXlaFzTRy3esf8tmnHST5n+QUCAOqoRJXm9fQv4JcJjNJD2V0Tjoq76AtMVCv+3S7Y0tE919133vlgIy3a49BO8tpqYBToRP42fP5JdLKT2lIESwldrb5vELbJ8WGoOgCSbXsTcpJyo8T0G7gk+suYJEe6Ef9a2RBDndRmiPqEs7r5wHcU8+bAPrVy1bSxiJDWziqkDutCO4uBnSEllbuM4bi4ZrfgGw2AUXjSeLXKv55ow8Ok9YKZZp6ZlrDk4ZjmxJ6HOL6rnAYE+WiNacoAz+G1vxtfxrPaQrp6EG6WZiqv+Ie6ZlRnkDR3Z84H0XrYS7d0v2tN3CAuDJWex9WwMAKwI4dTkpHS0GnnXCqFPyOKYo5nZkByAgCPYK1qeXkLpAVYWTziQ1fIXhHwrCcJwTlthQEfCHoJ3LQI9uxpuQE/8kPBRIvdgGB4pGjkstVApY/fufeDQqFwenpTEZQKurZY7Yq8lkTgOGZjCDU/XMc2Iwm/wFxAQNlSAok5p3hoveC93DV6oDAZpX5GmjW7dha1KRmLbV1Nk+jI7BY2BrQGwojVeI8+yQX4t1aHfwZilmM5/iYYYozqvmhRr6LfCvnoxZTz2Lli2lEjNaJ4T76TPVpy3lWSruynasdJysirK3OnxYgCcqzliN3AjYQ2h0b4frGGno0VHhylZOL9aWbC0d4PHo5APzv06/J+gCWgdMAwvGJF2+Eny4f/MCOOIMbC83+jJpUvCUAD8OO4xnE3WZGEN6mvlORDzyU4VV4xfpxJj7y7w2pNbA7+vP8HhJEcfoMWxyZEvGbNIgVSJdoiBrxIjpJ1/yrO/d51zDcWUyXcLgUOIW1MeSXA+t5fySHn5DogW7cizwqXejy70we+xibCJejzah1QJ8E3jEUpVZ7ytkd66sWTxg7XwDJW5xBha3Aev23rFn5AsVbA5keRlX8fstYczHoyzb6D0VrvycGgu2gPWh9J3ZAdJe4TNlpy59MM0e4rEHZbY8Y6iY+rsTmP6bqaAe0ohO1FTn0SwF4xHG6+z6x3PivtcolEJBCbK0XGOT1ECe2z5wIeyDCm42JQYxj4C2p5BbeRzEaIw0oxvfVFs8BMF856HiNer3RSR1MAaXxs5Hf8Cr7QF0pgyJfKy/B2LhaZ9bm/oO+ShG+yx40UP8M= X-Microsoft-Antispam-Message-Info: DXv6vtnPo6g2aQxBqGX8orv8g7djdmfGB/QNy8vMmnaSF8Gfgv4g1THenv7oNN+4rWXyql2ylUxg77GxDrS90nzsjeOcMnG8Coom2am3T7Cg43oMcUBpINn18D4uby5tY1DckTFcLLZeOCa0IJ/9NEmRRI+a+AXZYPE/YK6vzQ882DxDT5Pif7bh5ZoVF/QKRMmGsPHKtZ7TomJIKQwAIy0aisd9gYBDGHXeCo93PM5jQORq7kT5G73be0F5J1tUBnBvN2q139EFq/SJs/Q1wKbXoRenNJLmuly2/24+7fHRr6xYKJJV/aZpr57iLnwY7uwJBW+npyE5ckZLEl3mN5/r7xhUjeqzKdW2ei+Vmbw= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:hMdPDAUmmRdLmGev6mqlM5TtLo2/hwrusaFdUGRCNkmI6egfiBG3pvd/gVD5dBiCqEpALyzYuFMPIBj5M7msshsMtqZuYRSyNkmJFY0uhR8TOe1G2inkgvMIhriqTVw8vlSW8OLfp0lBkPddTbOZwryh4J5kAcyn62a48ZNrrMKl106g/YVyP6xNVgf5G9cSsUn/mL7NGmFYwHBZVtCtB+3j6uX02edJdP2jV427Hcspfe1vDaokop38nCh18zSV50CbahubSoiVnGrC/h8IIYpOcbO9bRDSxkY86O4BKylY4HYowKBD/UpHNSq8wps4W538Ayh4cFKDmH1oBgi73mBcA01IjT0KYs0VOrCCsUMB4XP7tGPEcymSIf97CfBDv29ciF9A7Wjrk/FlG4973S/e/sOTCXOYo+hfBKWH08UQIR6f0mvOD4ztcdQ35nTuOXSx0l4nR21QDx+Fn2jq1w==;5:Dcm8NXn5KRI7ltNWx3FmstYvE3rJrpfeLYGFLeQtOMwN/nKPV2g9f5yYBTno1GTPPw4qntnxlomogrs2QzAyjYX6EMWOqts2afYo+OmQd/bW5IA+ywKxsVuANlFcNTVMf23WSMffWRk0gm7WwwHbvBfH9n7DkkVbP1Z8visJQRs=;7:BeR2FDceklKXEojYqUcMCXv5yZdbmTJUTM4ng19gEglL7sj07HcMp0owl+9WFYlQLWthYeQxPEnkuSWy3VOTi/O5oj7CpMRnt6rX17IRBlqDvut9NyoNULUhE+c+H6Caj4OP4pWRfVg1XerxyZ9tDV0DnRwkUBTQ5y/YpdpmW8JkGvlL+UmwOLfkroJYd/sG/WyO8sOAM7a249W7/U5ZLAU1UchOtNhF3N47JEAzO7PptKa3FenXzP5t+V/u99SL SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:33.2491 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 22e419bb-84e7-404d-625c-08d5f3136fb2 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. Reviewed-by: Ayan Kumar halder Acked-by: Liviu Dudau Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/arm/malidp_planes.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/arm/malidp_planes.c b/drivers/gpu/drm/arm/malidp_planes.c index 29409a65d864..49c37f6dd63e 100644 --- a/drivers/gpu/drm/arm/malidp_planes.c +++ b/drivers/gpu/drm/arm/malidp_planes.c @@ -78,11 +78,8 @@ static void malidp_plane_reset(struct drm_plane *plane) kfree(state); plane->state = NULL; state = kzalloc(sizeof(*state), GFP_KERNEL); - if (state) { - state->base.plane = plane; - state->base.rotation = DRM_MODE_ROTATE_0; - plane->state = &state->base; - } + if (state) + __drm_atomic_helper_plane_reset(plane, &state->base); } static struct