From patchwork Thu Jul 26 16:17:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10546129 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 42252112E for ; Thu, 26 Jul 2018 16:18:48 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3010D2A514 for ; Thu, 26 Jul 2018 16:18:48 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2117A2B88E; Thu, 26 Jul 2018 16:18:48 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A62702A514 for ; Thu, 26 Jul 2018 16:18:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731819AbeGZRgS (ORCPT ); Thu, 26 Jul 2018 13:36:18 -0400 Received: from mail-eopbgr10052.outbound.protection.outlook.com ([40.107.1.52]:34018 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731600AbeGZRgS (ORCPT ); Thu, 26 Jul 2018 13:36:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ZXEf8Msz5N6VKyG0qIrHK5r4oSmfWmCrnulObrD9mNs=; b=fUSy/LgDbkkByyeykOGXB0WlMNsRbI3MqkRTFNEFYhfyCL9civ7EOxGhBmDFYCJWNa/+j5s0hzSSi03F+rudXGF6m9Np+BzjE/CP1tBEwcrFgMv4emlPIAnixfVtoSufDCNzhj2cZ1Mo3cQy0sQwPPyZw00JqWwEPLIRBU5mWmc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; Received: from e114479-lin.cambridge.arm.com (217.140.96.140) by DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.973.20; Thu, 26 Jul 2018 16:18:36 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v2 04/10] drm: atmel-hlcdc: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Thu, 26 Jul 2018 17:17:50 +0100 Message-Id: <20180726161756.1794-5-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> References: <20180726161756.1794-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: AM0PR07CA0031.eurprd07.prod.outlook.com (2603:10a6:208:ac::44) To DB6PR0802MB2552.eurprd08.prod.outlook.com (2603:10a6:4:a1::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 6c687c91-9ce7-4607-bd92-08d5f31371bd X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(5600073)(711020)(4618075)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(2017052603328)(7153060)(7193020);SRVR:DB6PR0802MB2552; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;3:dDX4zgCDe3JUr34M0YSXOoNQYaimOiPwj4Oe649BFDVDJJvdhowGinFZbg2AsEJf14hYoMmbUqXiQT0jpBUfVbma9i+H4L1ghrtvycmx9e/q6mNxIdfRa1w3mbkMq+JN6tvTgOUbWjtG7DJtyo0f5sBv98FF2nycqE6SHY6sX7LbdcpPeG+OvHIBPEmSAVsopDf56Wu17CFMEz2dadpPVngGebaj2MokJWLTpbUyqxMnqgfCIIwagmjzV1KNl2qi;25:djNzK9GWrlyqr8ZZSMhK7mUWDmzk98fd1jgog+c6HI/oqeNbGRaFDrZFD6dNqxOTeuWlAB36Xwo+Eod7BSwqi8YT5FjyrJSRDmucPPyC+8LqScGg5vRfC5eixQtIgvrnuZSiQgM+e0OSTurecH/GZZQGBh7jaLEX4fpcML2P5D28d0S8FOJNrI12usLdVPA7xLbSUt7BPXLalkLgk3T+zY1ImV/5KtWpJ1yoGEZOK5JOJzbquiXL/9YxYvCUDOdE/K4pcyfJMMi8J8p+23HvFUtjc5Tyv+Lfjr2dowEYopbZAD2G1E4q4A0mPpN0U10CohoXl2SlNcpuqxZ6DVcHKg==;31:kQJH6Xrs3zGZAGFjGniSIQV+sglxr8WzSpFkWUuV70ZQgGGXKuCDsCjKRfVpxz8S+DC5ckvR8J8+jtGICYU2Kjf7iuV7kIBRZ5PNZnkCKr6/DBkBtdNpAJ0CH/EKuxXQqhy1vqEe31IzBKB8q/iGz9td9P8HBh0R6mIbicuMP6AVigPqMjpBICFuxnYRTuKZRsbh30KD6FKNPjcgWNKWxNdzmK08kie7P2C/x1z+DtE= X-MS-TrafficTypeDiagnostic: DB6PR0802MB2552: NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;20:f7iamJImEXk50aqhJzVls8YbKYerCgo4PIuw/6cNqDHYq8HHzZkvLjACfM8VzxfuZ5wkboHSwDEbfWmcuzW28WJ/t2rWV2BPY0ZvDZuqQNPYbOLtaX+yjr8/2bsWIf+LyHx7bf5VVEWv+rK0qup/4n5+D4k+XaHst3uS7S44K1o9F/HVf4Rfcx2TdyJD9Vj8sm1H6oAoj+Givk9dJH+jAkzG3zY6ceQR8YkZWiWD911nTfzzr+Wl1Uum5hNHiWd3a+KlAHgLNPPC0StBJGsUeqf8qAYsX94hN4Fln9t4xLNEgG3r+9Y2gczuvtkudWu6brA3bqdhBhyLvEjeTn/Vlg==;4:XdD2Az6gxfBdc9OeKRyrUaDSO8WLR+drvEsme4PULTfwbLtGq216ZtfoKFjEz/P7kBQMs+hhxgdEXV7Tli16mNHoWRU/1qM5bHKgg43yde4b08ArOU8wIMYE83iZo8J5wBZIIHKG2YtV/sySKx88DFXz9yb45lnjy2e8/E1HFBifriV3wBxgAfx8QVGvhUAibfS7xntMPXGpArqMTvqSyvPg63HoiiJI9rByEP1TPtAmik3zawdn3F1u5mVmyp064TW8RBIb61OqfaYWOntp4/u9vXADYnkKW4P2GTVzuCHCiZ6k/hXX8bkTWh6jVJ45 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(10201501046)(93006095)(93001095)(3231311)(944501410)(52105095)(3002001)(6055026)(149027)(150027)(6041310)(20161123558120)(20161123562045)(20161123564045)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011)(7699016);SRVR:DB6PR0802MB2552;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2552; X-Forefront-PRVS: 07459438AA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(39860400002)(136003)(346002)(396003)(376002)(366004)(189003)(199004)(105586002)(305945005)(36756003)(8676002)(478600001)(476003)(2616005)(81156014)(81166006)(486006)(97736004)(50226002)(16586007)(68736007)(316002)(72206003)(956004)(25786009)(7736002)(66066001)(106356001)(47776003)(6486002)(52116002)(2906002)(86362001)(446003)(1076002)(50466002)(7406005)(11346002)(7696005)(3846002)(51416003)(6666003)(48376002)(53936002)(6116002)(386003)(26005)(8936002)(5660300001)(4326008)(76176011)(16526019)(7416002)(186003)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2552;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;23:frtj9uP8r2lE+BvkNQex/Nb4sxuHlE8mqaGKbA6CLau5Qp6xEcI6nvKUD0JXenwCTzbGtH8H23Ww96HvWMf4Jvlmj21Q2j8ya7VmSkBic9wbL0n7xvtWd10UOa01X9AeqRSutdTECiq8k2Vx/msclmImxWAeuhKi20RAL3X2jym6L7WYQD3M/LCYFkZwfnMT02GQbHK3d4x9yIoQCVylDDbM+AYpJYa1L+uZ3ZBbeFROq1ivzdbwjvc1JMFQ43B84P6RxEiv9n4Pww7SGVt+joZVy7lPryGETktLJ+BNVDFSbqsWs0vE+uDHm5IvAkKOZJpfxE5muXVzIlBQ9re8maIqwQK1xIZsi8FMI41CU5dmpDgb1wuNYCq85Xjt8+mZpRkOVRfBfAt4C2WqKhn30X53QMhMWKkFyY3xsA/Hn2Yig/0zjJczT04PcjYwD2pUkwA/QBaI0QjbIlMVP3fNdZBa3xfCbYJ3D4cQp0kW52PyQZK5GFkyrWJBayh0GvpDBHc6I+Xy0/MJOsY7YrcHMCmmGwgF89gONJhIaCSyBNklNcynbawqLqMp6wbveZjwhMP6RRZkDdMzuGNoFxub01tGRgzJum7xRHWVyZSW1jsT5/MIryy6Lw/Ok1TZMswST3MzS6dLF1IBEPdSmpBPHx1o9mBzYftmtmg/CPpB1PmcDl2tuOHZkNZWrw5x7oYALX0H7YkdXNRwDf72tFZAhW7boT3fbSpVRGSQuENf72EMZ0Ba0mUmK2XKJIbZvma69tPjEhZ2IAJb+0kT7vfhYUPPb7xRywApwhSzSNfKFxEXUyY3O+UXO/y5hfxLrOxDgfn+EFsxX06c8XWxJHSKD3dEFmT+qbAm1MQDzITeyZSHyxTDnNeur8vHAAydcHuExaBV4bdYOvx5r+WFf6WqNLzIRnhdSNXzM0omzcmjR3mmapTROZ+HybHux9oB6z1b8y7pn2kP7QEFgLt3lDP8g/m3fEMB843C6bzlwk7Bqi5T44MNMDZRgz6s73Uv1GXdB0H2OXqv4BGD/0kdd1AShK/lu9SJ8GwbIuPqdZjWiAT0Dmwd3KijQFfmM22GvBTClBbvcOUoLbsqktEWLC2Pf3DoGf2lRqFQ3lTzKLt0yy9WZ4MFZdViCRyirH6170dhVtGd7rKoJ2olQh37EVT0AnkH3mQ4o10x9LukEP9danyFJOMIhZEvgHs4ccGmZ9/eq6rb+F1yzT0RvXoUqOmtI2qHN3RT3x6sCfHWYmw6JZo= X-Microsoft-Antispam-Message-Info: uiepA60wzstOILoVe0ovCZhOPDwM43elhjKSbTbTfdWXkALqOrsXKfPOYqE3Kasx4mqz6+Dm6d1o8JKQqP7vyOSbnfpYrIIjluM8piAPfHr8pJk0jq5kG4h/NSxItaZRCM+e35KmD21Q16FqEFvxps4Jfznr94NvCpLQI3auAp2kq2qJlunYuwA6HdnMw9wsLPPaB2cMgwoZkcupLr0HRganwR8kc/l9zdX4u49+3ngeva9Z9waMwOg9SX0RdaCxjeQqVYlKk9a69fVQ2O1RNYY3nQ9bh2/a8B+z4RLTArpeSXFWd4c/Nsb37mHtk1PMppqNmncA/1Scsgr9+zvw9kEYoz0/gRls7zJyl/iEEEI= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2552;6:r1xdRY2rwCACXXw6fbaDxX1M7BWq0gC1CmplpxG7Wg15FtZeHrhmquK5GpcsScugmMYr8sK2Ny+i4WfPAd/f6gz2VvPVeVbSCh8dV3ff9yH0K1hV5cYWxKdwv9jJP3f/+fwW7/c9LXn0k7dw/hi6Y5wj1BerHzzyXkORgNjNIFfJdYl9dzklEOrwuGrkWlh9kC9JFToa8+RHtm2RpHhnfbv6Fmu1QQeV3bqW96URco8itG/NDEwaSSromtZqWMW63agvEkuSTfcN7nls7OtnBcIGbj3t2Fxj7Z/+AHrTARYRY2uOPPvfBuk+oWMwVEQ6aPsl0mIz60WDJ+fBdYajBtSxpVsZDrvCp0Fn6OUZi8lV+pcZJaCqlA71YwO+7u+LDJI1+Mz1Sy4pWGXLA+AkUCVTgAh+b2U8AN2qWycfx11q5sQiPIJIWkCNjBa3TfeNrK9x3wC//NLJDklp/0cfZQ==;5:7XmJ8GggpRIaqUuKwkzvQfe35zRC/0P8VPQzE4LZsVVoHYTTuAZOllkRubE8I/RtrOScMniJcSbvmMa91JUPClCykOp/Of4JtwxHcBea0uz0M+X3MvORE3KA6cEEh63YhAXomDSV+mS80qdoeCaw5V7cS7eN7SruAndTLBJAjbU=;7:B3gPs/CMAXhBqggUkOtJXbZxY72a/fWj/edHtOQCjEgpnh2l2DgIKkegXz43bBqFPPb0+yZ5ykw1tNuODSZIa0qDLYtddpOUX3kZrXszd3Ez5Q9RtBwm4wqPy3ftiu/RAiySL4Qi7WPu64Qp0bidQpUWBRp3/ULkGgB6l5RvqGtquzjk97zsRB8PLN2L+VJk26rS/W62jhItBsICjdjC4W4fuAfSt0XpbbGx6UusZhFsPVsZSEAbc/JwJ4x6vF4t SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Jul 2018 16:18:36.6729 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 6c687c91-9ce7-4607-bd92-08d5f31371bd X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2552 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. __drm_atomic_helper_plane_reset initializes the alpha property to its max value, which is defined by the drm core as DRM_BLEND_ALPHA_OPAQUE, so nothing changes regarding the alpha value. Acked-by: Boris Brezillon Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c index 04440064b9b7..9330a076e15a 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c @@ -942,10 +942,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p) "Failed to allocate initial plane state\n"); return; } - - p->state = &state->base; - p->state->alpha = DRM_BLEND_ALPHA_OPAQUE; - p->state->plane = p; + __drm_atomic_helper_plane_reset(p, &state->base); } }