| Message ID | 20180803105540eucas1p17fd1e4ec4b4062498af392a91fc62665~HWoiDgG7K2563025630eucas1p1o@eucas1p1.samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ARM: dts: exynos: Fix sound in Snow-rev5 Chromebook | expand |
On 3 August 2018 at 12:55, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > This patch adds missing properties to the CODEC and sound nodes, so the > audio will work also on Snow rev5 Chromebook. This patch is an extension > to the commits: e9eefc3f8ce0 ("ARM: dts: exynos: Add missing clock and DAI > properties to the max98095 node in Snow Chromebook") and 6ab569936d60 > ("ARM: dts: exynos: Enable HDMI audio on Snow Chromebook"). It has been > reported that such changes work fine on the rev5 board too. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos5250-snow-rev5.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) Looks ok. It's too late for this cycle so I will take it after merge window. Shall this be backported to stable? Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Krzysztof, On 2018-08-07 08:56, Krzysztof Kozlowski wrote: > On 3 August 2018 at 12:55, Marek Szyprowski <m.szyprowski@samsung.com> wrote: >> This patch adds missing properties to the CODEC and sound nodes, so the >> audio will work also on Snow rev5 Chromebook. This patch is an extension >> to the commits: e9eefc3f8ce0 ("ARM: dts: exynos: Add missing clock and DAI >> properties to the max98095 node in Snow Chromebook") and 6ab569936d60 >> ("ARM: dts: exynos: Enable HDMI audio on Snow Chromebook"). It has been >> reported that such changes work fine on the rev5 board too. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm/boot/dts/exynos5250-snow-rev5.dts | 11 +++++++++++ >> 1 file changed, 11 insertions(+) > Looks ok. It's too late for this cycle so I will take it after merge > window. Shall this be backported to stable? v4.20 is fine. I doubt it makes sense to backport patches with just a missing features to stable. Stable backports should be used for fixing real bugs imho... Best regards
On 7 August 2018 at 09:03, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > Hi Krzysztof, > > On 2018-08-07 08:56, Krzysztof Kozlowski wrote: >> On 3 August 2018 at 12:55, Marek Szyprowski <m.szyprowski@samsung.com> wrote: >>> This patch adds missing properties to the CODEC and sound nodes, so the >>> audio will work also on Snow rev5 Chromebook. This patch is an extension >>> to the commits: e9eefc3f8ce0 ("ARM: dts: exynos: Add missing clock and DAI >>> properties to the max98095 node in Snow Chromebook") and 6ab569936d60 >>> ("ARM: dts: exynos: Enable HDMI audio on Snow Chromebook"). It has been >>> reported that such changes work fine on the rev5 board too. >>> >>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >>> --- >>> arch/arm/boot/dts/exynos5250-snow-rev5.dts | 11 +++++++++++ >>> 1 file changed, 11 insertions(+) >> Looks ok. It's too late for this cycle so I will take it after merge >> window. Shall this be backported to stable? > > v4.20 is fine. I doubt it makes sense to backport patches with just a > missing > features to stable. Stable backports should be used for fixing real bugs > imho... OK, thanks for comments. BR, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, Aug 03, 2018 at 12:55:32PM +0200, Marek Szyprowski wrote: > This patch adds missing properties to the CODEC and sound nodes, so the > audio will work also on Snow rev5 Chromebook. This patch is an extension > to the commits: e9eefc3f8ce0 ("ARM: dts: exynos: Add missing clock and DAI > properties to the max98095 node in Snow Chromebook") and 6ab569936d60 > ("ARM: dts: exynos: Enable HDMI audio on Snow Chromebook"). It has been > reported that such changes work fine on the rev5 board too. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos5250-snow-rev5.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > Thanks, applied. Best regards, Krzysztof
On Wed, Aug 29, 2018 at 09:21:38PM +0200, Krzysztof Kozlowski wrote: > On Fri, Aug 03, 2018 at 12:55:32PM +0200, Marek Szyprowski wrote: > > This patch adds missing properties to the CODEC and sound nodes, so the > > audio will work also on Snow rev5 Chromebook. This patch is an extension > > to the commits: e9eefc3f8ce0 ("ARM: dts: exynos: Add missing clock and DAI > > properties to the max98095 node in Snow Chromebook") and 6ab569936d60 > > ("ARM: dts: exynos: Enable HDMI audio on Snow Chromebook"). It has been > > reported that such changes work fine on the rev5 board too. > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > --- > > arch/arm/boot/dts/exynos5250-snow-rev5.dts | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > Thanks, applied. > ... and dropped cause build fails: arch/arm/boot/dts/exynos5250-snow-rev5.dtb: ERROR (phandle_references): /sound/codec: Reference to non-existent node or label "max98095" Do I need some dependency? Best regards, Krzysztof
On Fri, Aug 03, 2018 at 12:55:32PM +0200, Marek Szyprowski wrote: > This patch adds missing properties to the CODEC and sound nodes, so the > audio will work also on Snow rev5 Chromebook. This patch is an extension > to the commits: e9eefc3f8ce0 ("ARM: dts: exynos: Add missing clock and DAI > properties to the max98095 node in Snow Chromebook") and 6ab569936d60 > ("ARM: dts: exynos: Enable HDMI audio on Snow Chromebook"). It has been > reported that such changes work fine on the rev5 board too. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos5250-snow-rev5.dts | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow-rev5.dts b/arch/arm/boot/dts/exynos5250-snow-rev5.dts > index 0348b1c49a69..6589760d80ee 100644 > --- a/arch/arm/boot/dts/exynos5250-snow-rev5.dts > +++ b/arch/arm/boot/dts/exynos5250-snow-rev5.dts > @@ -20,6 +20,14 @@ > > samsung,model = "Snow-I2S-MAX98090"; > samsung,audio-codec = <&max98090>; > + > + cpu { > + sound-dai = <&i2s0 0>; > + }; > + > + codec { > + sound-dai = <&max98095 0>, <&hdmi>; Applied after fixing typo in max98095 phandle. I assumed it mirrors the regular Snow DTS. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos5250-snow-rev5.dts b/arch/arm/boot/dts/exynos5250-snow-rev5.dts index 0348b1c49a69..6589760d80ee 100644 --- a/arch/arm/boot/dts/exynos5250-snow-rev5.dts +++ b/arch/arm/boot/dts/exynos5250-snow-rev5.dts @@ -20,6 +20,14 @@ samsung,model = "Snow-I2S-MAX98090"; samsung,audio-codec = <&max98090>; + + cpu { + sound-dai = <&i2s0 0>; + }; + + codec { + sound-dai = <&max98095 0>, <&hdmi>; + }; }; }; @@ -31,6 +39,9 @@ interrupt-parent = <&gpx0>; pinctrl-names = "default"; pinctrl-0 = <&max98090_irq>; + clocks = <&pmu_system_controller 0>; + clock-names = "mclk"; + #sound-dai-cells = <1>; }; };
This patch adds missing properties to the CODEC and sound nodes, so the audio will work also on Snow rev5 Chromebook. This patch is an extension to the commits: e9eefc3f8ce0 ("ARM: dts: exynos: Add missing clock and DAI properties to the max98095 node in Snow Chromebook") and 6ab569936d60 ("ARM: dts: exynos: Enable HDMI audio on Snow Chromebook"). It has been reported that such changes work fine on the rev5 board too. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos5250-snow-rev5.dts | 11 +++++++++++ 1 file changed, 11 insertions(+)