From patchwork Sat Aug 4 16:15:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru-Cosmin Gheorghe X-Patchwork-Id: 10555803 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 99E2E13BB for ; Sat, 4 Aug 2018 16:16:31 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88BCF29C0C for ; Sat, 4 Aug 2018 16:16:31 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7B57729CF5; Sat, 4 Aug 2018 16:16:31 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06DEF29C0C for ; Sat, 4 Aug 2018 16:16:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728484AbeHDSRk (ORCPT ); Sat, 4 Aug 2018 14:17:40 -0400 Received: from mail-ve1eur01on0088.outbound.protection.outlook.com ([104.47.1.88]:36032 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728417AbeHDSRj (ORCPT ); Sat, 4 Aug 2018 14:17:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UJpGmcOv3Lv1jhgQfrzvW2LdGRdDwYVUXj/y7BXZsOo=; b=PKpNt0/8hQu3sLdtkKJUZAksHUhaFwS8T17L12S0LoEqKV8fg3m6ajn4CqEkrqdNFzFLrmPAM4+ZyfMc01XV14WPGqlWYb7Qiw6mSU93WMG0vvjzrZKYwRkLvgkmcFcuxQ79dRl9iHpVwZBnhpU0MMIVZuHFqJKHPa6A/tG17zY= Received: from e114479-lin.cambridge.arm.com (217.140.106.49) by AM5PR0802MB2547.eurprd08.prod.outlook.com (2603:10a6:203:a0::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1017.14; Sat, 4 Aug 2018 16:16:12 +0000 From: Alexandru Gheorghe To: seanpaul@chromium.org, airlied@linux.ie, dri-devel@lists.freedesktop.org, liviu.dudau@arm.com, brian.starkey@arm.com, malidp@foss.arm.com, ville.syrjala@linux.intel.com, daniel@ffwll.ch, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, alexander.deucher@amd.com, christian.koenig@amd.com, David1.Zhou@amd.com, harry.wentland@amd.com, andrey.grodzovsky@amd.com, Tony.Cheng@amd.com, sunpeng.li@amd.com, shirish.s@amd.com, boris.brezillon@bootlin.com, nicolas.ferre@microchip.com, alexandre.belloni@bootlin.com, inki.dae@samsung.com, jy0922.shim@samsung.com, sw0312.kim@samsung.com, kyungmin.park@samsung.com, kgene@kernel.org, krzk@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, p.zabel@pengutronix.de, laurent.pinchart@ideasonboard.com, maxime.ripard@bootlin.com, wens@csie.org, eric@anholt.net, linux-graphics-maintainer@vmware.com, syeh@vmware.com, thellstrom@vmware.com Cc: nd@arm.com, Alexandru Gheorghe Subject: [PATCH v3 05/10] drm/exynos: Use __drm_atomic_helper_plane_reset instead of copying the logic Date: Sat, 4 Aug 2018 17:15:25 +0100 Message-Id: <20180804161530.12275-6-alexandru-cosmin.gheorghe@arm.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20180804161530.12275-1-alexandru-cosmin.gheorghe@arm.com> References: <20180804161530.12275-1-alexandru-cosmin.gheorghe@arm.com> MIME-Version: 1.0 X-Originating-IP: [217.140.106.49] X-ClientProxiedBy: DB6P189CA0005.EURP189.PROD.OUTLOOK.COM (2603:10a6:6:2e::18) To AM5PR0802MB2547.eurprd08.prod.outlook.com (2603:10a6:203:a0::23) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 05a283f5-5767-4365-6b55-08d5fa25994f X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(7020095)(4652040)(8989117)(4534165)(4627221)(201703031133081)(201702281549075)(8990107)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020);SRVR:AM5PR0802MB2547; X-Microsoft-Exchange-Diagnostics: 1;AM5PR0802MB2547;3:yXiwIhFz5OU4Qe0KunnsrYURuyUjB0154fp4nvbZucR0WVzdypieFWaxw0rpGWZ9cZEloVofb5FpTaGEIx7TyiFMWtta+KL9DcraiNxaMSGqF3QZiGIvR55Rz5Fuq/g503ELfPPvxJjrQ45DPobSan8dTM+sZtXC0X9H3EVty7rf16s12zeeqgPaeZPmQoVG3EgFWx9Sdm/85rXL3ceDBQkDLYs5uknODNSMY6l4ZSDtX8j5pxPqLglh147ZDUCX;25:z66MGtjRV+seYSoTBpkO8MBFU0G004VZRmP0ZDEPVPtokth9EkYB6eBR8y6akjMFnxwquTbZrpfVnQFfbXyoKXc1r/39jhHJpcW0lBGcctKrTEUZNLc1ydIQMbbZEVSijD7Bpl2CDuIaFfYiAv99nBEOeTJpXCvHUqeFzmBBK/1E3NXkg/5YPVHDuYV7b1Tk+mLGsT/zMr+16WwzNtSaguqrqj1xSbQktso1ip3wbvtgVZ4E/RwwcFbOX6NOEhZi0iIgnxJ8+K8x9v67GZBwAbvSHMXuDTVuHXDU8LQvGfb1PMAEllEgf3708NCoz1i0Dx3M73sfV3i0SYywjn/jNg==;31:93iifDCyaDPG/pBq/lzeo0dssFoABhHKqkyUY6uiwD7H5uoTcUqCYQSaEkEbKnXFL8UtbS44pUnobfafrEJs3E55C9CiaB6szAdp/rv5oARIDbAfuwVmfVN8XvLwdjZBBek11ltLbW21tAZOZs5h95rN426dkSHLzPKKbMoQIafejiXHBIfwVgjA+0LYEFwclpbnT/68Eqoe6KgzE6t5zUWfdR7SczC49ng/7N3lbpY= X-MS-TrafficTypeDiagnostic: AM5PR0802MB2547: Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Alexandru-Cosmin.Gheorghe@arm.com; NoDisclaimer: True X-Microsoft-Exchange-Diagnostics: 1;AM5PR0802MB2547;20:RMdqc5brDU2oA8iQcEtQgu5I67K8MwCi4n48SSg5a1aXVkt8oKBptiGJBoyUkz/MC3z9tL/uKZrxHrVzjJeb3CdFnJd/zkkNaFPNSyQ2rYD0wbnai+cjyd7VWur9ISTrAVI9pnsmIyMXmUMpD5wmYFnKpHqQjOA5bU3I6tKcAklOfd8g6bERyJuALbe8TUTM7PcFzJNvjKUoRehkn/xfAyhU/vi+eiXMA2iBl4VN78MTkBlABMajzdiLZ0MQ398DGNQozeBWCe76ZQqxLysa9XGTddy6JMNA0CtJbjX/cszZ4flEs112m4NUrHwW0zH+somOJbT3U/kOay13XKqsnA==;4:iNNvRnei6rdIJZOuM3hduxIRLqIriR9qvD9XHSOD0ndNDBu5wVEbbcjkYaKkliSXf8922JYmrMiZLyGp68E3sjXpsWOh0biOPbWwRwCziN7YqSPF7LvsSCSk9tcz9W3Jwoeq+u1L8jOuovTN6beV71eCFIjCH63B69g2DZaY86QKDdZY2yFeN+/0vsGN5JufPyDvJ/CfjdjqAtEg53K0kRU59sE/Rx/fDuS0vMiJ60L5OI2uGUNuoXLV1zvsJvi27uBfwHkGPGEursIHB5eSLovSa+o8clcf7nwL4PC3VkgG/H/0/d7ShHQEg0bw2cNc X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-MS-Exchange-SenderADCheck: 1 X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231311)(944501410)(52105095)(10201501046)(93006095)(93001095)(3002001)(6055026)(149027)(150027)(6041310)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011)(7699016);SRVR:AM5PR0802MB2547;BCL:0;PCL:0;RULEID:;SRVR:AM5PR0802MB2547; X-Forefront-PRVS: 0754F7E325 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(1496009)(346002)(366004)(396003)(376002)(136003)(39860400002)(189003)(199004)(51416003)(86362001)(76176011)(7736002)(4326008)(66066001)(47776003)(52116002)(97736004)(7696005)(305945005)(25786009)(16526019)(186003)(105586002)(6116002)(3846002)(956004)(106356001)(7416002)(5660300001)(446003)(1076002)(11346002)(26005)(6666003)(2616005)(7406005)(478600001)(53936002)(72206003)(68736007)(486006)(8936002)(36756003)(50226002)(316002)(50466002)(81166006)(476003)(16586007)(81156014)(48376002)(386003)(2906002)(8676002)(6486002)(921003)(1121003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM5PR0802MB2547;H:e114479-lin.cambridge.arm.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; Received-SPF: None (protection.outlook.com: arm.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: 1;AM5PR0802MB2547;23:K6lWYs9WvqvyQhMrdirb656d4s6MbPCr82qKqY0ZfXOU4ZgL9HLwClcoMML9zUkO56z1+YR3AyXV0V1RPOWYCSMSIq95BCIfhYOysMcax36k8eIeaTWjI13R4kA6SmF2LypXlZOIbNkBRT41fH5JrvKfgD8k49ObeeH+2WWyILJBQ3SBiXaOekb2H0agobYsPzLFcN8OHtiOO2Exb7VpnbqwGPD18jkxNGPUN+UPU2d1t3YHu7OOPbJLG4tAmZZLnn/R6Vesgkmv2QBoos9rBQ4iYivDD/sBq2REdMCTRZIJRxo7jBjFT/iRoJwHTXd+Z+Vb6nWieQvyaRrasWPOnL+c8DuqSM7jqyUPZ9GqtuRUiim1/0LDK2ufJNNLBjDfZmH9d0qeVLRuagLMVHQr4TD3p3oXNCA0kcSSNrLhxHd0tO6jO2suq9B1zWkBj9GWOaWHVIIrqGpq8m2rM+to0PXOqBSYeL3LK9vyrezt3KtHZIFB64oYEuROZztTe65ET+AT0v2FAuR/REw2lV1gjfePfiJsJYZ+9Wqpd+h75Q0MNPNJhqvX3ca1iWRXEjY9MZfGYjUXTnloncuR5sGtweBfdj8xY9jeR4byUAHFt3kfI2ksFgAiO77koyQ4oHNQvweyxeYx4gNkhjmtNOBjafOZA0/VKELctMsp3pRU9ZjZI75oROECHxRu1bq+uMP+yW419J3whhTCUFlLw4eFvcQBTxvlCXfHf51HlwxRNwAcMsLm5pWse13UcCEKJemfX72N/Fqqj9ix+/IBCFjOSEYcNBqSpAUq9js/Cf7zgBS4tcuD29yndclkAhzCK6+o3YsqBeKa/NswUd8WrTOCIut6Rs6taMYKvYWgBT8xE7xrzJBWgo8A7385sQKqaiviiHoPF/cAdRfdAX5SKU3HE0sfYDrxKR3zGcRg4dcAQAvvcJHDtDZMA54zQcCgFqhvr1n72it9sSEt6JTVpkDKmr5YPO9e6MiP8U+ckAD/uPLCV4UgNjfSCP7Fpxhlmi7D4GssN+GhCUIacDvnZ4MsJBpgUIQdBp2yRRzg5iKs/922ELaSXkWHDm8ittKYAj6BljaI8XLlCR6kCmZTB7nJfaMvgNchq4dC5B0q5C2Jn8GG7ZNXnN97FraeMiqFsj4f78rV5gRjQdKNzPVe2avyZus4wMzdt7ap+6Bptw2Kl+5ww0bnKcA0Gfx/osRHqeddP7y7vkgu2QKFzF9vB1asyKhcB67YvSokUAZOo6OXcofJavS15whEGLRFFB2H9Knl X-Microsoft-Antispam-Message-Info: zah7lEAkoX0lwJGxqxjMouTbkdaGADER7xNSdSzqUa3OND5yeAX567vXATMz/FqnAgDviB9gZZvGelivUnolFAaqQxzban75sypk5/XK4qrm8ItAUULBLqvqqOHdsUSMn30CRiMh8JlhCt6jH+2Lqk996Vup0gpZpwqrChTyJVm8/vZmA/tG9nqmtgDQciedyMTB79aQ1ey2bpdt4i6s0S+hEN/DfjS8ZLkl8UwjIRUhFst3gA/8iHub/eTSA/Au+fwy5jesNEUg90jGsnbyPUT0j7sm7rko8L1P+6Hh9g6lOlEi3+Dx2OabYKQFqJlMTPZE+wF052C2Atc3LjP55zQuwIRc9JxnINtrCK3nQ84= X-Microsoft-Exchange-Diagnostics: 1;AM5PR0802MB2547;6:Y1+OsXnkRBS+1mUmNUQmfNdCm3n0BbPi3pmT1pt2u5EnKAuqNvlUktNocKmIqkqxOLZ+O6oKdZO81pEVw9BYJgs2gTmPx4F1axmhjoPclaKI4Lb3M10saowz3mpQKyx7itVUB0qKtW+rcjS+l7w8lg44yYn+oyxyuJkNyy7IF8boseNNTyie2UjT1GvwubGN6eDC0zaHpcThRBlPZomT3+cTzTBDJL3aqbBEntzBL+fCzc7+HsmLkB+BlsJ01JwArVv+BjdBBzR2Mjs39S+W7HAAJRI5OGwUKww7A2DvDU97HgU1IkjVoBSccHfscIWsmzsVoHzSjBga7cXGOBwu9tJj490cBAeODkbNmbd6mnFHt87COvDcEw2JFKEerHaiFfv2GI64aPOeAMSH+5WYIgeAOX+RiCXkFpvhidglUywUJfUyrdLaYRm1RYmUFotkJCeqVvOBQQ2zwWWNV/UDrA==;5:DQiiB7ooIJ7XffwKEvYLr9FQrK1LYBCY/0tOk2yKPR7EYuvt8tYiShHrzbgZJCRDIZqksjzzLInRL6smx7th4l243mFQKEJZoHxoOPECRsXhfoNFd6LHIk3KwbOGuq18KMtpKFK0OzEKp+4ldzlpSuDh38bgVqrdxCWKiMfOiSo=;7:WXtxf9csr/GpPFL32jMG0atOwxy4rGnOoOUzbWJeReuIV5Vsjt0mwX7zjAIYMJWwCHTEKtO+tcMmvZaY0D6BzU3vCqWhC0SgySbb9zOED8PFCH4oHR1IEeVax4wg603oOH3M7kFwOBg68dqlpn6oIC2eVA3eOckJ06L7+s/YGWcRWYCEOaq3QBqp0VS/SOz12M+pfDtd8qXeb0ZEofliHXQWwVHtdvtTuJwWv/fTIUN9adLQlPS3YsqRV9Y6NlZP SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Aug 2018 16:16:12.3736 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 05a283f5-5767-4365-6b55-08d5fa25994f X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0802MB2547 Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A new helper function(__drm_atomic_helper_plane_reset) has been added for linking a plane with its state and resetting the core properties(alpha, rotation, etc.) to their default values. Use that instead of duplicating the logic. Signed-off-by: Alexandru Gheorghe --- drivers/gpu/drm/exynos/exynos_drm_plane.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_plane.c b/drivers/gpu/drm/exynos/exynos_drm_plane.c index eb9915da7dec..681328fbe7de 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_plane.c +++ b/drivers/gpu/drm/exynos/exynos_drm_plane.c @@ -139,8 +139,7 @@ static void exynos_drm_plane_reset(struct drm_plane *plane) exynos_state = kzalloc(sizeof(*exynos_state), GFP_KERNEL); if (exynos_state) { - plane->state = &exynos_state->base; - plane->state->plane = plane; + __drm_atomic_helper_plane_reset(plane, &exynos_state->base); plane->state->zpos = exynos_plane->config->zpos; } }