[3/3] clk: s2mps11: Use existing defines from bindings for clock IDs

Commit Message

Krzysztof Kozlowski Aug. 7, 2018, 4:17 p.m. UTC

The clock IDs must match between DeviceTree bindings and the driver.
There is already a header file used by DeviceTree sources so include it
in the driver to remove duplicated symbols.

Signed-off-by: Krzysztof Kozlowski <[e-mail]>
---
 drivers/clk/clk-s2mps11.c | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

Comments

Rob Herring Aug. 14, 2018, 8:37 p.m. UTC | #1

On Tue,  7 Aug 2018 18:17:13 +0200, Krzysztof Kozlowski wrote:
> The clock IDs must match between DeviceTree bindings and the driver.
> There is already a header file used by DeviceTree sources so include it
> in the driver to remove duplicated symbols.
> 
> Signed-off-by: Krzysztof Kozlowski <[e-mail]>
> ---
>  drivers/clk/clk-s2mps11.c | 7 +------
>  1 file changed, 1 insertion(+), 6 deletions(-)
> 

Reviewed-by: Rob Herring <[e-mail]>

Stephen Boyd Aug. 27, 2018, 9:18 p.m. UTC | #2

Quoting Krzysztof Kozlowski (2018-08-07 09:17:13)
> The clock IDs must match between DeviceTree bindings and the driver.
> There is already a header file used by DeviceTree sources so include it
> in the driver to remove duplicated symbols.
> 
> Signed-off-by: Krzysztof Kozlowski <[e-mail]>
> ---

Applied to clk-next

Patch

diff --git a/drivers/clk/clk-s2mps11.c b/drivers/clk/clk-s2mps11.c
index ebf9115dad1d..56221647207d 100644
--- a/drivers/clk/clk-s2mps11.c
+++ b/drivers/clk/clk-s2mps11.c
@@ -17,12 +17,7 @@ 
 #include <linux/mfd/samsung/s5m8767.h>
 #include <linux/mfd/samsung/core.h>
 
-enum {
-	S2MPS11_CLK_AP = 0,
-	S2MPS11_CLK_CP,
-	S2MPS11_CLK_BT,
-	S2MPS11_CLKS_NUM,
-};
+#include <dt-bindings/clock/samsung,s2mps11.h>
 
 struct s2mps11_clk {
 	struct sec_pmic_dev *iodev;