| Message ID | 20180928133713eucas1p16a15a68b61de9aa3310737f7fd77d20d~Yk9kqY_Ga2124121241eucas1p1b@eucas1p1.samsung.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | ARM: SAMSUNG: limit SAMSUNG_PM_DEBUG config option to non-Exynos platforms | expand |
On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> wrote: > > "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > config option) is not working properly (debug messages are not > displayed after resume) on Exynos platforms because GPIOs restore > code is not implemented. AFAIR, it worked properly for the suspend part showing more logs. Unless it changed, the feature looks still useful. Best regards, Krzysztof > > Add PLAT_S3C24XX, ARCH_S3C64XX and ARCH_S5PV210 dependencies to > SAMSUNG_PM_DEBUG config option to hide it on Exynos platforms. > > Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> > --- > arch/arm/plat-samsung/Kconfig | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > Index: b/arch/arm/plat-samsung/Kconfig > =================================================================== > --- a/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.041911426 +0200 > +++ b/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.037911426 +0200 > @@ -238,7 +238,8 @@ comment "Power management" > > config SAMSUNG_PM_DEBUG > bool "Samsung PM Suspend debug" > - depends on PM && DEBUG_KERNEL > + depends on DEBUG_KERNEL > + depends on PM && (PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210) > depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART > help > Say Y here if you want verbose debugging from the PM Suspend and >
On 09/28/2018 03:54 PM, Krzysztof Kozlowski wrote: > On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz > <b.zolnierkie@samsung.com> wrote: >> >> "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG >> config option) is not working properly (debug messages are not >> displayed after resume) on Exynos platforms because GPIOs restore >> code is not implemented. > > AFAIR, it worked properly for the suspend part showing more logs. > Unless it changed, the feature looks still useful. Yes, it shows few additional messages from mach/plat specific suspend code but it breaks the assumption that features (even debug ones) work correctly and make you invest time in debugging known broken code. In case it is needed/useful (which should be rather rare situation) one can always easily revert the commit locally. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics
On Fri, Sep 28, 2018 at 06:34:55PM +0200, Bartlomiej Zolnierkiewicz wrote: > > > On 09/28/2018 03:54 PM, Krzysztof Kozlowski wrote: > > On Fri, 28 Sep 2018 at 15:37, Bartlomiej Zolnierkiewicz > > <b.zolnierkie@samsung.com> wrote: > >> > >> "Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG > >> config option) is not working properly (debug messages are not > >> displayed after resume) on Exynos platforms because GPIOs restore > >> code is not implemented. > > > > AFAIR, it worked properly for the suspend part showing more logs. > > Unless it changed, the feature looks still useful. > > Yes, it shows few additional messages from mach/plat specific suspend > code but it breaks the assumption that features (even debug ones) > work correctly and make you invest time in debugging known broken > code. OK, let's remove it. However in such case this change leaves useless S3C_PMDBG and other s3c_pm_* in Exynos code. They should go away along with SAMSUNG_PM_DEBUG. Best regards, Krzysztof > > In case it is needed/useful (which should be rather rare situation) > one can always easily revert the commit locally. > > Best regards, > -- > Bartlomiej Zolnierkiewicz > Samsung R&D Institute Poland > Samsung Electronics
Index: b/arch/arm/plat-samsung/Kconfig =================================================================== --- a/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.041911426 +0200 +++ b/arch/arm/plat-samsung/Kconfig 2018-09-28 15:20:06.037911426 +0200 @@ -238,7 +238,8 @@ comment "Power management" config SAMSUNG_PM_DEBUG bool "Samsung PM Suspend debug" - depends on PM && DEBUG_KERNEL + depends on DEBUG_KERNEL + depends on PM && (PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210) depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART help Say Y here if you want verbose debugging from the PM Suspend and
"Samsung PM Suspend debug" feature (controlled by SAMSUNG_PM_DEBUG config option) is not working properly (debug messages are not displayed after resume) on Exynos platforms because GPIOs restore code is not implemented. Add PLAT_S3C24XX, ARCH_S3C64XX and ARCH_S5PV210 dependencies to SAMSUNG_PM_DEBUG config option to hide it on Exynos platforms. Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com> --- arch/arm/plat-samsung/Kconfig | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)