| Message ID | 20181204165248.17572-5-k.konieczny@partner.samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3,1/5] clk: samsung: exynos5433: fix typo in imem divider | expand |
On Tue, Dec 04, 2018 at 05:52:47PM +0100, Kamil Konieczny wrote: > Add description for imem clock in the Samsung Exynos5433. The users can use > compatibility "samsung,exynos5433-cmu-imem". Thanks, applied but the commit message above is not matching contents at all. You did not add the description. Mentioning some users and compatibility also seems unrelated. Instead: 1. You added DT node for IMEM clock controller on Exynos5433. 2. Because it is necessary for SSS to work (beside obvious reasons: for DTS completeness and allowing to gate them when not used). Also, please use SoC name in commit title (for example at the end) to differentiate from Exynos7 or any other future SoCs. Best regards, Krzysztof
On 13.12.2018 22:10, Krzysztof Kozlowski wrote: > On Tue, Dec 04, 2018 at 05:52:47PM +0100, Kamil Konieczny wrote: >> Add description for imem clock in the Samsung Exynos5433. The users can use >> compatibility "samsung,exynos5433-cmu-imem". > > Thanks, applied but the commit message above is not matching contents at all. > You did not add the description. Mentioning some users and compatibility > also seems unrelated. Instead: > 1. You added DT node for IMEM clock controller on Exynos5433. > 2. Because it is necessary for SSS to work (beside obvious reasons: for > DTS completeness and allowing to gate them when not used). > Also, please use SoC name in commit title (for example at the end) to > differentiate from Exynos7 or any other future SoCs. Thank you for your work and insightfull comments, I hope to improve my commit messages.
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index 2131f12364cb..378cd3d87ff0 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -544,6 +544,21 @@ power-domains = <&pd_cam1>; }; + cmu_imem: clock-controller@11060000 { + compatible = "samsung,exynos5433-cmu-imem"; + reg = <0x11060000 0x1000>; + #clock-cells = <1>; + + clock-names = "oscclk", + "aclk_imem_sssx_266", + "aclk_imem_266", + "aclk_imem_200"; + clocks = <&xxti>, + <&cmu_top CLK_DIV_ACLK_IMEM_SSSX_266>, + <&cmu_top CLK_DIV_ACLK_IMEM_266>, + <&cmu_top CLK_DIV_ACLK_IMEM_200>; + }; + pd_gscl: power-domain@105c4000 { compatible = "samsung,exynos5433-pd"; reg = <0x105c4000 0x20>;
Add description for imem clock in the Samsung Exynos5433. The users can use compatibility "samsung,exynos5433-cmu-imem". Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com> --- arch/arm64/boot/dts/exynos/exynos5433.dtsi | 15 +++++++++++++++ 1 file changed, 15 insertions(+)