| Message ID | 20190103201408.GA27754@embeddedor (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | ARM: mach-s3c24xx: Fix boolean expressions in osiris_dvs_notify | expand |
On Thu, 3 Jan 2019 at 21:46, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > > Fix boolean expressions by using logical AND operator '&&' > instead of bitwise operator '&'. > > This issue was detected with the help of Coccinelle. > > Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.") > Cc: stable@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c > index 058ce73137e8..ccbd7b7965ca 100644 > --- a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c > +++ b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c > @@ -65,16 +65,16 @@ static int osiris_dvs_notify(struct notifier_block *nb, > > switch (val) { > case CPUFREQ_PRECHANGE: > - if (old_dvs & !new_dvs || > - cur_dvs & !new_dvs) { > + if (old_dvs && !new_dvs || > + cur_dvs && !new_dvs) { Technically the old code will work fine because all variables are bools (so 0 or 1). Therefore I am not sure whether this should be ported to stable. Anyway the patch is itself okay and I will take it after merge window. Thanks! Best regards, Krzysztof
On Thu, Jan 03, 2019 at 02:14:08PM -0600, Gustavo A. R. Silva wrote: > Fix boolean expressions by using logical AND operator '&&' > instead of bitwise operator '&'. > > This issue was detected with the help of Coccinelle. > > Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.") > Cc: stable@vger.kernel.org > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 ++++---- Thanks, applied with fixing up -Wparentheses warning. I think you should update your GCC. Best regards, Krzysztof
Hi Krzysztof, On 1/7/19 1:43 PM, Krzysztof Kozlowski wrote: > On Thu, Jan 03, 2019 at 02:14:08PM -0600, Gustavo A. R. Silva wrote: >> Fix boolean expressions by using logical AND operator '&&' >> instead of bitwise operator '&'. >> >> This issue was detected with the help of Coccinelle. >> >> Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.") >> Cc: stable@vger.kernel.org >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 ++++---- > > Thanks, applied with fixing up -Wparentheses warning. I think you should > update your GCC. > Thanks for that. I wonder if you could take these too: https://lore.kernel.org/lkml/418252fcd77472413ce15ac3df167e448a4defe9.1546667177.git.gustavo@embeddedor.com/ https://lore.kernel.org/lkml/2795c5ba939fe23dda6c86135d56e68433f7d68a.1546667177.git.gustavo@embeddedor.com/ Thanks -- Gustavo
On Mon, 7 Jan 2019 at 21:33, Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > > Hi Krzysztof, > > On 1/7/19 1:43 PM, Krzysztof Kozlowski wrote: > > On Thu, Jan 03, 2019 at 02:14:08PM -0600, Gustavo A. R. Silva wrote: > >> Fix boolean expressions by using logical AND operator '&&' > >> instead of bitwise operator '&'. > >> > >> This issue was detected with the help of Coccinelle. > >> > >> Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.") > >> Cc: stable@vger.kernel.org > >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > >> --- > >> arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 ++++---- > > > > Thanks, applied with fixing up -Wparentheses warning. I think you should > > update your GCC. > > > > Thanks for that. > > I wonder if you could take these too: > > https://lore.kernel.org/lkml/418252fcd77472413ce15ac3df167e448a4defe9.1546667177.git.gustavo@embeddedor.com/ > https://lore.kernel.org/lkml/2795c5ba939fe23dda6c86135d56e68433f7d68a.1546667177.git.gustavo@embeddedor.com/ Can't do. I am maintainer only for ARM/Samsung platform and these are for Integrator. Best regards, Krzysztof
On 1/8/19 1:42 AM, Krzysztof Kozlowski wrote: >> >> I wonder if you could take these too: >> >> https://lore.kernel.org/lkml/418252fcd77472413ce15ac3df167e448a4defe9.1546667177.git.gustavo@embeddedor.com/ >> https://lore.kernel.org/lkml/2795c5ba939fe23dda6c86135d56e68433f7d68a.1546667177.git.gustavo@embeddedor.com/ > > Can't do. I am maintainer only for ARM/Samsung platform and these are > for Integrator. > Oh Okay. I got it. Thanks -- Gustavo
diff --git a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c index 058ce73137e8..ccbd7b7965ca 100644 --- a/arch/arm/mach-s3c24xx/mach-osiris-dvs.c +++ b/arch/arm/mach-s3c24xx/mach-osiris-dvs.c @@ -65,16 +65,16 @@ static int osiris_dvs_notify(struct notifier_block *nb, switch (val) { case CPUFREQ_PRECHANGE: - if (old_dvs & !new_dvs || - cur_dvs & !new_dvs) { + if (old_dvs && !new_dvs || + cur_dvs && !new_dvs) { pr_debug("%s: exiting dvs\n", __func__); cur_dvs = false; gpio_set_value(OSIRIS_GPIO_DVS, 1); } break; case CPUFREQ_POSTCHANGE: - if (!old_dvs & new_dvs || - !cur_dvs & new_dvs) { + if (!old_dvs && new_dvs || + !cur_dvs && new_dvs) { pr_debug("entering dvs\n"); cur_dvs = true; gpio_set_value(OSIRIS_GPIO_DVS, 0);
Fix boolean expressions by using logical AND operator '&&' instead of bitwise operator '&'. This issue was detected with the help of Coccinelle. Fixes: 4fa084af28ca ("ARM: OSIRIS: DVS (Dynamic Voltage Scaling) supoort.") Cc: stable@vger.kernel.org Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- arch/arm/mach-s3c24xx/mach-osiris-dvs.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)