| Message ID | 20190109095557.5005-1-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0b94260ac1e11e37f546d06bfae5c5bf13e0ad33 |
| Headers | show |
| Series | ARM: dts: exynos: Fix eMMC regulator properties on OdroidU3 boards | expand |
On Wed, 9 Jan 2019 at 10:56, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > LDO20 regulator provides power for theeMMC card on Odroid U3 boards. That > regulator has been marked as 'boot-on' since the beggining of OdroidX/U3 > support, but such flag is not really needed for it. That regulator is > correctly described as supply for eMMC card and controlled by its driver. > > Commit 05f224ca6693 ("regulator: core: Clean enabling always-on regulators > + their supplies") changed the way the boot-on regulators are handled and > since then regulators marked as 'boot-on' got increased reference count > and are not turned off for the system suspend time. > > The new approach turned out to break suspend/resume support on OdroidU3 > with eMMC card, because the card is not properly shutdown due to missing > of power cycle. Fix this by removing excessive 'boot-on' flag and let > MMC driver to control turning power on and off. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Thanks, applied. (It seems patchwork notification bot did not notify about this) Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index 3a9eb1e91c45..24bcad3dfba9 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi @@ -390,7 +390,6 @@ regulator-name = "LDO20_1.8V"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; - regulator-boot-on; }; ldo21_reg: LDO21 {
LDO20 regulator provides power for theeMMC card on Odroid U3 boards. That regulator has been marked as 'boot-on' since the beggining of OdroidX/U3 support, but such flag is not really needed for it. That regulator is correctly described as supply for eMMC card and controlled by its driver. Commit 05f224ca6693 ("regulator: core: Clean enabling always-on regulators + their supplies") changed the way the boot-on regulators are handled and since then regulators marked as 'boot-on' got increased reference count and are not turned off for the system suspend time. The new approach turned out to break suspend/resume support on OdroidU3 with eMMC card, because the card is not properly shutdown due to missing of power cycle. Fix this by removing excessive 'boot-on' flag and let MMC driver to control turning power on and off. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 1 - 1 file changed, 1 deletion(-)