From patchwork Thu Jan 24 12:22:57 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marek Szyprowski X-Patchwork-Id: 10778831 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 5574E1515 for ; Thu, 24 Jan 2019 12:23:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 4757B2F084 for ; Thu, 24 Jan 2019 12:23:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 45A5D2F0BD; Thu, 24 Jan 2019 12:23:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=unavailable version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 06B072F09E for ; Thu, 24 Jan 2019 12:23:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727386AbfAXMXQ (ORCPT ); Thu, 24 Jan 2019 07:23:16 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:46696 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbfAXMXQ (ORCPT ); Thu, 24 Jan 2019 07:23:16 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20190124122313euoutp0210f4f178f950918485480e21430576a2~8yEpmKvTq0339203392euoutp02h; Thu, 24 Jan 2019 12:23:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20190124122313euoutp0210f4f178f950918485480e21430576a2~8yEpmKvTq0339203392euoutp02h DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1548332593; bh=bySyhtuLQkgUIZjh1PZALIchJDWXbng0LDwh5sfrK/0=; h=From:To:Cc:Subject:Date:In-reply-to:References:From; b=qO7diC2zrFJZk173S/YLfYuYTmSkvvoRjTpkHzlRtYDD3msghs8XWig7FRrsZ+LJU 9F3gRAm+zKFREUm+1c+D3flmWemJn5WHht3EmJjPQYVPG0J+03cY5tE9Zd13kwbCY7 Z7Sx5hWpvG4DZp7YFFz1IO+5HP4JZuaseiriPCvE= Received: from eusmges3new.samsung.com (unknown [203.254.199.245]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190124122313eucas1p268f3d603f9ed3d92b6db93f96943cb51~8yEpDFzoB2098620986eucas1p2o; Thu, 24 Jan 2019 12:23:13 +0000 (GMT) Received: from eucas1p2.samsung.com ( [182.198.249.207]) by eusmges3new.samsung.com (EUCPMTA) with SMTP id A4.24.04806.03EA94C5; Thu, 24 Jan 2019 12:23:12 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20190124122312eucas1p226ebde670733cd7a8acd755bd27fab26~8yEoSHsup0870308703eucas1p2o; Thu, 24 Jan 2019 12:23:12 +0000 (GMT) X-AuditID: cbfec7f5-367ff700000012c6-83-5c49ae300655 Received: from eusync3.samsung.com ( [203.254.199.213]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 8C.E4.04128.03EA94C5; Thu, 24 Jan 2019 12:23:12 +0000 (GMT) Received: from AMDC2765.digital.local ([106.116.147.25]) by eusync3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0PLU002OS52JPM60@eusync3.samsung.com>; Thu, 24 Jan 2019 12:23:12 +0000 (GMT) From: Marek Szyprowski To: linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org Cc: Marek Szyprowski , Krzysztof Kozlowski , Bartlomiej Zolnierkiewicz , Ulf Hansson , Markus Reichl , Srinivas Kandagatla Subject: [PATCH] ARM: dts: exynos: Fix pinctrl definition for EMMC RTSN line on OdroidX2/U3 Date: Thu, 24 Jan 2019 13:22:57 +0100 Message-id: <20190124122257.20569-1-m.szyprowski@samsung.com> X-Mailer: git-send-email 2.17.1 In-reply-to: X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrIIsWRmVeSWpSXmKPExsWy7djP87oG6zxjDD5dMrLYOGM9q8X58xvY LY7872e0mHF+H5PFyyM/GC3WHrnLbtF27BirxfG14Q4cHrfu1HtsWtXJ5nHn2h42j74tqxg9 Pm+SC2CN4rJJSc3JLEst0rdL4Mp41/yYteCLQMXebyoNjN18XYycHBICJhIX/qxn6WLk4hAS WMEosfvrblaQhJDAZ0aJwyfgimYtO80GUbSMUeL0qU9QTgOTxKeDr1lAqtgEDCW63naxgdgi Ag4S765fYAIpYhaYxiTRefUsE0hCWCBW4lLrVUYQm0VAVWLX3mtgzbwCthJfDn5jh1gnL7F6 wwFmEJtTwF5i7qGzYPdJCHSwSSxacA+qyEVi1r3vjBC2jMTlyd1QRc2MEu0zZrFDOD2MElvn 7GCDqLKWOHz8Ith3zAJ8EpO2TQdawQEU55XoaBOCKPGQaO5ZC/XbJKDerW9YJzBKLGBkWMUo nlpanJueWmycl1quV5yYW1yal66XnJ+7iREYcaf/Hf+6g3Hfn6RDjAIcjEo8vBvyPGKEWBPL iitzDzFKcDArifC6XnSLEeJNSaysSi3Kjy8qzUktPsQozcGiJM5bzfAgWkggPbEkNTs1tSC1 CCbLxMEp1cB4YXl40/cd185Wr9um2FTV+mZHSfD6P8cOq8w3vnWN/Zy93rfjRU1pdjEfZAOc VDpW6u+L7L13OUdOJHJLceoENTsuh76jPRzNsRm5jKtyRTkCpobmS926WM7AoxHTdnAyh4j9 VLWK27/au0Pq2WZ+7bQIF2szv1m/QS7mVlz0wkOZO9S2/lFiKc5INNRiLipOBACD3sMwtAIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupiluLIzCtJLcpLzFFi42I5/e/4VV2DdZ4xBrM72C02zljPanH+/AZ2 iyP/+xktZpzfx2Tx8sgPRou1R+6yW7QdO8ZqcXxtuAOHx6079R6bVnWyedy5tofNo2/LKkaP z5vkAlijuGxSUnMyy1KL9O0SuDLeNT9mLfgiULH3m0oDYzdfFyMnh4SAicSsZafZuhi5OIQE ljBK7J7/mgnCaWKS+H78MjNIFZuAoUTX2y42EFtEwEHi3fULYEXMAjOYJF5O/wKWEBaIlZg+ +S8LiM0ioCqxa+81MJtXwFbiy8Fv7BDr5CVWbzgANpRTwF5i7qGzYDVCAnYSB3vWMk9g5FnA yLCKUSS1tDg3PbfYSK84Mbe4NC9dLzk/dxMjMIS2Hfu5ZQdj17vgQ4wCHIxKPLwchR4xQqyJ ZcWVuYcYJTiYlUR4XS+6xQjxpiRWVqUW5ccXleakFh9ilOZgURLnPW9QGSUkkJ5YkpqdmlqQ WgSTZeLglGpgzNzB9ztGMcValDvPacPeE2Ifb1sEutyuq83SbpOd1Sz/gzF7w9yfvnk/+DV4 6rMfvlz4Qjfwf5jL1acrvszg4fTelbu1V3IDf0TtOg+J43p7argnmSy+uUvpYkGE6dvZvz8W J81ICd3H5CTnEd31TPHco5N5b65m77j/eufN7On2fMWhLhNeK7EUZyQaajEXFScCAEn7iPcd AgAA X-CMS-MailID: 20190124122312eucas1p226ebde670733cd7a8acd755bd27fab26 CMS-TYPE: 201P X-CMS-RootMailID: 20190124122312eucas1p226ebde670733cd7a8acd755bd27fab26 References: Sender: linux-samsung-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Commit 225da7e65a03 ("ARM: dts: add eMMC reset line for exynos4412-odroid-common") added MMC power sequence for eMMC card. It reused generic sd1_cd pin control configuration node and only disabled pull-up. However that time the pinctrl configuration was not applied during MMC power sequence driver initialization. This has been changed later by commit d97a1e5d7cd2 ("mmc: pwrseq: convert to proper platform device"). It turned out then, that the provided pinctrl configuration is not correct, because the EMMC_RTSN line is being re-configured as 'special function/card detect function for mmc1 controller' not the simple 'output', thus the power sequence driver doesn't really set the pin value. Fix this by providing separate node with EMMC_RTSN pin configuration. Reported-by: Markus Reichl Suggested-by: Ulf Hansson Fixes: 225da7e65a03 ("ARM: dts: add eMMC reset line for exynos4412-odroid-common") Signed-off-by: Marek Szyprowski --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi index 3a9eb1e91c45..8a64c4e8c474 100644 --- a/arch/arm/boot/dts/exynos4412-odroid-common.dtsi +++ b/arch/arm/boot/dts/exynos4412-odroid-common.dtsi @@ -49,7 +49,7 @@ }; emmc_pwrseq: pwrseq { - pinctrl-0 = <&sd1_cd>; + pinctrl-0 = <&emmc_rstn>; pinctrl-names = "default"; compatible = "mmc-pwrseq-emmc"; reset-gpios = <&gpk1 2 GPIO_ACTIVE_LOW>; @@ -165,12 +165,6 @@ cpu0-supply = <&buck2_reg>; }; -/* RSTN signal for eMMC */ -&sd1_cd { - samsung,pin-pud = ; - samsung,pin-drv = ; -}; - &pinctrl_1 { gpio_power_key: power_key { samsung,pins = "gpx1-3"; @@ -188,6 +182,11 @@ samsung,pins = "gpx3-7"; samsung,pin-pud = ; }; + + emmc_rstn: emmc-rstn { + samsung,pins = "gpk1-2"; + samsung,pin-pud = ; + }; }; &ehci {