| Message ID | 20200226101307.16708-1-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | drm/bridge: sii9234: silence warning about regulators during deferred probe | expand |
Hi Marek, Thank you for the patch. On Wed, Feb 26, 2020 at 11:13:07AM +0100, Marek Szyprowski wrote: > Don't confuse user with meaningless warning about failure in getting > regulators in case of deferred probe. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/bridge/sii9234.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c > index f81f81b7051f..b1258f0ed205 100644 > --- a/drivers/gpu/drm/bridge/sii9234.c > +++ b/drivers/gpu/drm/bridge/sii9234.c > @@ -836,7 +836,8 @@ static int sii9234_init_resources(struct sii9234 *ctx, > ctx->supplies[3].supply = "cvcc12"; > ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies); > if (ret) { > - dev_err(ctx->dev, "regulator_bulk failed\n"); > + if (ret != -EPROBE_DEFER) > + dev_err(ctx->dev, "regulator_bulk failed\n"); > return ret; > } >
On Wed, 26 Feb 2020 at 11:13, Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Don't confuse user with meaningless warning about failure in getting > regulators in case of deferred probe. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/gpu/drm/bridge/sii9234.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Best regards, Krzysztof
On 26.02.2020 11:13, Marek Szyprowski wrote: > Don't confuse user with meaningless warning about failure in getting > regulators in case of deferred probe. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > drivers/gpu/drm/bridge/sii9234.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c > index f81f81b7051f..b1258f0ed205 100644 > --- a/drivers/gpu/drm/bridge/sii9234.c > +++ b/drivers/gpu/drm/bridge/sii9234.c > @@ -836,7 +836,8 @@ static int sii9234_init_resources(struct sii9234 *ctx, > ctx->supplies[3].supply = "cvcc12"; > ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies); > if (ret) { > - dev_err(ctx->dev, "regulator_bulk failed\n"); > + if (ret != -EPROBE_DEFER) > + dev_err(ctx->dev, "regulator_bulk failed\n"); > return ret; > } > Queued to next. Andrzej
diff --git a/drivers/gpu/drm/bridge/sii9234.c b/drivers/gpu/drm/bridge/sii9234.c index f81f81b7051f..b1258f0ed205 100644 --- a/drivers/gpu/drm/bridge/sii9234.c +++ b/drivers/gpu/drm/bridge/sii9234.c @@ -836,7 +836,8 @@ static int sii9234_init_resources(struct sii9234 *ctx, ctx->supplies[3].supply = "cvcc12"; ret = devm_regulator_bulk_get(ctx->dev, 4, ctx->supplies); if (ret) { - dev_err(ctx->dev, "regulator_bulk failed\n"); + if (ret != -EPROBE_DEFER) + dev_err(ctx->dev, "regulator_bulk failed\n"); return ret; }
Don't confuse user with meaningless warning about failure in getting regulators in case of deferred probe. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/gpu/drm/bridge/sii9234.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)