| Message ID | 20200519104904.59246-1-m.shams@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] drm/exynos: Remove dev_err() on platform_get_irq() failure | expand |
Hi Tamseel, Same patch[1] has been merged. So could you re-post this patch after rebasing it on top of exynos-drm-next branch? After rebase, only g2d part would be valid. Thanks, Inki Dae [1] https://git.kernel.org/pub/scm/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-next&id=fdd79b0db1899f915f489e744a06846284fa3f1e 20. 5. 19. 오후 7:49에 Tamseel Shams 이(가) 쓴 글: > platform_get_irq() will call dev_err() itself on failure, > so there is no need for the driver to also do this. > This is detected by coccinelle. > > Also removing unnecessary curly braces around if () statement. > > Signed-off-by: Tamseel Shams <m.shams@samsung.com> > --- > Fixed review comment by joe@perches.com > > drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 +--- > drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 4 +--- > drivers/gpu/drm/exynos/exynos_drm_scaler.c | 4 +--- > 4 files changed, 3 insertions(+), 10 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > index 902938d2568f..958e2c6a6702 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c > @@ -1809,10 +1809,8 @@ static int exynos_dsi_probe(struct platform_device *pdev) > } > > dsi->irq = platform_get_irq(pdev, 0); > - if (dsi->irq < 0) { > - dev_err(dev, "failed to request dsi irq resource\n"); > + if (dsi->irq < 0) > return dsi->irq; > - } > > irq_set_status_flags(dsi->irq, IRQ_NOAUTOEN); > ret = devm_request_threaded_irq(dev, dsi->irq, NULL, > diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > index fcee33a43aca..03be31427181 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c > @@ -1498,7 +1498,6 @@ static int g2d_probe(struct platform_device *pdev) > > g2d->irq = platform_get_irq(pdev, 0); > if (g2d->irq < 0) { > - dev_err(dev, "failed to get irq\n"); > ret = g2d->irq; > goto err_put_clk; > } > diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c > index dafa87b82052..2d94afba031e 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c > @@ -293,10 +293,8 @@ static int rotator_probe(struct platform_device *pdev) > return PTR_ERR(rot->regs); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "failed to get irq\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_irq(dev, irq, rotator_irq_handler, 0, dev_name(dev), > rot); > diff --git a/drivers/gpu/drm/exynos/exynos_drm_scaler.c b/drivers/gpu/drm/exynos/exynos_drm_scaler.c > index 93c43c8d914e..ce1857138f89 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_scaler.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_scaler.c > @@ -502,10 +502,8 @@ static int scaler_probe(struct platform_device *pdev) > return PTR_ERR(scaler->regs); > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "failed to get irq\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_threaded_irq(dev, irq, NULL, scaler_irq_handler, > IRQF_ONESHOT, "drm_scaler", scaler); >
> -----Original Message----- > From: Inki Dae <inki.dae@samsung.com> > Sent: Wednesday, May 20, 2020 11:08 AM > To: Tamseel Shams <m.shams@samsung.com>; jy0922.shim@samsung.com; > sw0312.kim@samsung.com; kyungmin.park@samsung.com; airlied@linux.ie; > daniel@ffwll.ch > Cc: dri-devel@lists.freedesktop.org; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org; > shaik.ameer@samsung.com; krzk@kernel.org; alim.akhtar@samsung.com > Subject: Re: [PATCH v2] drm/exynos: Remove dev_err() on platform_get_irq() > failure > > Hi Tamseel, > > Same patch[1] has been merged. So could you re-post this patch after rebasing > it on top of exynos-drm-next branch? > After rebase, only g2d part would be valid. > Hi Inki Dae, Thanks for letting me know, I will send updated patch for G2D file. Thanks & Regards Tamseel Shams
diff --git a/drivers/gpu/drm/exynos/exynos_drm_dsi.c b/drivers/gpu/drm/exynos/exynos_drm_dsi.c index 902938d2568f..958e2c6a6702 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_dsi.c +++ b/drivers/gpu/drm/exynos/exynos_drm_dsi.c @@ -1809,10 +1809,8 @@ static int exynos_dsi_probe(struct platform_device *pdev) } dsi->irq = platform_get_irq(pdev, 0); - if (dsi->irq < 0) { - dev_err(dev, "failed to request dsi irq resource\n"); + if (dsi->irq < 0) return dsi->irq; - } irq_set_status_flags(dsi->irq, IRQ_NOAUTOEN); ret = devm_request_threaded_irq(dev, dsi->irq, NULL, diff --git a/drivers/gpu/drm/exynos/exynos_drm_g2d.c b/drivers/gpu/drm/exynos/exynos_drm_g2d.c index fcee33a43aca..03be31427181 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_g2d.c +++ b/drivers/gpu/drm/exynos/exynos_drm_g2d.c @@ -1498,7 +1498,6 @@ static int g2d_probe(struct platform_device *pdev) g2d->irq = platform_get_irq(pdev, 0); if (g2d->irq < 0) { - dev_err(dev, "failed to get irq\n"); ret = g2d->irq; goto err_put_clk; } diff --git a/drivers/gpu/drm/exynos/exynos_drm_rotator.c b/drivers/gpu/drm/exynos/exynos_drm_rotator.c index dafa87b82052..2d94afba031e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_rotator.c +++ b/drivers/gpu/drm/exynos/exynos_drm_rotator.c @@ -293,10 +293,8 @@ static int rotator_probe(struct platform_device *pdev) return PTR_ERR(rot->regs); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (irq < 0) return irq; - } ret = devm_request_irq(dev, irq, rotator_irq_handler, 0, dev_name(dev), rot); diff --git a/drivers/gpu/drm/exynos/exynos_drm_scaler.c b/drivers/gpu/drm/exynos/exynos_drm_scaler.c index 93c43c8d914e..ce1857138f89 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_scaler.c +++ b/drivers/gpu/drm/exynos/exynos_drm_scaler.c @@ -502,10 +502,8 @@ static int scaler_probe(struct platform_device *pdev) return PTR_ERR(scaler->regs); irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "failed to get irq\n"); + if (irq < 0) return irq; - } ret = devm_request_threaded_irq(dev, irq, NULL, scaler_irq_handler, IRQF_ONESHOT, "drm_scaler", scaler);
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Also removing unnecessary curly braces around if () statement. Signed-off-by: Tamseel Shams <m.shams@samsung.com> --- Fixed review comment by joe@perches.com drivers/gpu/drm/exynos/exynos_drm_dsi.c | 4 +--- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 1 - drivers/gpu/drm/exynos/exynos_drm_rotator.c | 4 +--- drivers/gpu/drm/exynos/exynos_drm_scaler.c | 4 +--- 4 files changed, 3 insertions(+), 10 deletions(-)