| Message ID | 20200615054928.55188-1-navid.emamdoost@gmail.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v2] drm/exynos: fix ref count leak in mic_pre_enable | expand |
20. 6. 15. 오후 2:49에 Navid Emamdoost 이(가) 쓴 글: > in mic_pre_enable, pm_runtime_get_sync is called which > increments the counter even in case of failure, leading to incorrect > ref count. In case of failure, decrement the ref count before returning. > > Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> > --- > Changes in v2: > - reuse the unlock label and call pm_runtime_put_noidle Picked it up. Thanks, Inki Dae > --- > --- > drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c > index a86abc173605..3821ea76a703 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c > @@ -269,8 +269,10 @@ static void mic_pre_enable(struct drm_bridge *bridge) > goto unlock; > > ret = pm_runtime_get_sync(mic->dev); > - if (ret < 0) > + if (ret < 0) { > + pm_runtime_put_noidle(mic->dev); > goto unlock; > + } > > mic_set_path(mic, 1); > >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_mic.c b/drivers/gpu/drm/exynos/exynos_drm_mic.c index a86abc173605..3821ea76a703 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_mic.c +++ b/drivers/gpu/drm/exynos/exynos_drm_mic.c @@ -269,8 +269,10 @@ static void mic_pre_enable(struct drm_bridge *bridge) goto unlock; ret = pm_runtime_get_sync(mic->dev); - if (ret < 0) + if (ret < 0) { + pm_runtime_put_noidle(mic->dev); goto unlock; + } mic_set_path(mic, 1);
in mic_pre_enable, pm_runtime_get_sync is called which increments the counter even in case of failure, leading to incorrect ref count. In case of failure, decrement the ref count before returning. Signed-off-by: Navid Emamdoost <navid.emamdoost@gmail.com> --- Changes in v2: - reuse the unlock label and call pm_runtime_put_noidle --- --- drivers/gpu/drm/exynos/exynos_drm_mic.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)