diff mbox series

[1/2] ARM: samsung: fix PM debug build with DEBUG_LL but !MMU

Message ID 20200910154150.3318-1-krzk@kernel.org
State Accepted
Commit 7be0d19c751b02db778ca95e3274d5ea7f31891c
Headers show
Series [1/2] ARM: samsung: fix PM debug build with DEBUG_LL but !MMU | expand

Commit Message

Krzysztof Kozlowski Sept. 10, 2020, 3:41 p.m. UTC
Selecting CONFIG_SAMSUNG_PM_DEBUG (depending on CONFIG_DEBUG_LL) but
without CONFIG_MMU leads to build errors:

  arch/arm/plat-samsung/pm-debug.c: In function ‘s3c_pm_uart_base’:
  arch/arm/plat-samsung/pm-debug.c:57:2: error:
    implicit declaration of function ‘debug_ll_addr’ [-Werror=implicit-function-declaration]

Reported-by: kernel test robot <lkp@intel.com>
Fixes: 99b2fc2b8b40 ("ARM: SAMSUNG: Use debug_ll_addr() to get UART base address")
Cc: <stable@vger.kernel.org>
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>

---

Patchset is rebased on v5.9-rc1.
---
 arch/arm/plat-samsung/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Sept. 16, 2020, 5 p.m. UTC | #1
On Thu, Sep 10, 2020 at 05:41:49PM +0200, Krzysztof Kozlowski wrote:
> Selecting CONFIG_SAMSUNG_PM_DEBUG (depending on CONFIG_DEBUG_LL) but
> without CONFIG_MMU leads to build errors:
> 
>   arch/arm/plat-samsung/pm-debug.c: In function ‘s3c_pm_uart_base’:
>   arch/arm/plat-samsung/pm-debug.c:57:2: error:
>     implicit declaration of function ‘debug_ll_addr’ [-Werror=implicit-function-declaration]
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 99b2fc2b8b40 ("ARM: SAMSUNG: Use debug_ll_addr() to get UART base address")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
> 
> ---
> 
> Patchset is rebased on v5.9-rc1.
> ---
>  arch/arm/plat-samsung/Kconfig | 1 +

Applied.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/plat-samsung/Kconfig b/arch/arm/plat-samsung/Kconfig
index 301e572651c0..790c87ee7271 100644
--- a/arch/arm/plat-samsung/Kconfig
+++ b/arch/arm/plat-samsung/Kconfig
@@ -241,6 +241,7 @@  config SAMSUNG_PM_DEBUG
 	depends on PM && DEBUG_KERNEL
 	depends on PLAT_S3C24XX || ARCH_S3C64XX || ARCH_S5PV210
 	depends on DEBUG_EXYNOS_UART || DEBUG_S3C24XX_UART || DEBUG_S3C2410_UART
+	depends on DEBUG_LL && MMU
 	help
 	  Say Y here if you want verbose debugging from the PM Suspend and
 	  Resume code. See <file:Documentation/arm/samsung-s3c24xx/suspend.rst>