diff mbox series

ARM: dts: exynos: Remove 'opp-shared' from Exynos4412 bus OPP-tables

Message ID 20200911122236.16805-1-m.szyprowski@samsung.com
State Under Review
Headers show
Series ARM: dts: exynos: Remove 'opp-shared' from Exynos4412 bus OPP-tables | expand

Commit Message

Marek Szyprowski Sept. 11, 2020, 12:22 p.m. UTC
Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the
values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts:
exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family")
revealed that 'opp-shared' property for the Exynos bus OPPs was used
incorrectly, what had the side-effect of disabling frequency scaling for
the second and latter buses sharing given OPP-table.

Fix this by removing bogus 'opp-shared' properties from Exynos4412 bus
OPP-tables. This restores frequency scaling for the following busses:
C2C, RightBus, and MFC.

Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
---
 arch/arm/boot/dts/exynos4412.dtsi | 6 ------
 1 file changed, 6 deletions(-)

Comments

Krzysztof Kozlowski Sept. 20, 2020, 3:27 p.m. UTC | #1
On Fri, Sep 11, 2020 at 02:22:36PM +0200, Marek Szyprowski wrote:
> Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the
> values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts:
> exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family")
> revealed that 'opp-shared' property for the Exynos bus OPPs was used
> incorrectly, what had the side-effect of disabling frequency scaling for
> the second and latter buses sharing given OPP-table.
> 
> Fix this by removing bogus 'opp-shared' properties from Exynos4412 bus
> OPP-tables. This restores frequency scaling for the following busses:
> C2C, RightBus, and MFC.
> 
> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4412.dtsi | 6 ------
>  1 file changed, 6 deletions(-)
>

As discussed on IRC, I am waiting with these patches till you let me
know they're good.

Best regards,
Krzysztof
Marek Szyprowski Oct. 2, 2020, 6 a.m. UTC | #2
Hi Krzysztof,

On 20.09.2020 17:27, Krzysztof Kozlowski wrote:
> On Fri, Sep 11, 2020 at 02:22:36PM +0200, Marek Szyprowski wrote:
>> Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the
>> values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts:
>> exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family")
>> revealed that 'opp-shared' property for the Exynos bus OPPs was used
>> incorrectly, what had the side-effect of disabling frequency scaling for
>> the second and latter buses sharing given OPP-table.
>>
>> Fix this by removing bogus 'opp-shared' properties from Exynos4412 bus
>> OPP-tables. This restores frequency scaling for the following busses:
>> C2C, RightBus, and MFC.
>>
>> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>> ---
>>   arch/arm/boot/dts/exynos4412.dtsi | 6 ------
>>   1 file changed, 6 deletions(-)
>>
> As discussed on IRC, I am waiting with these patches till you let me
> know they're good.

I got the information from Markus Reichl that this patch finally doesn't 
cause a regression. The issue he observed must be something else. 
Anyway, I would like to postpone this patch to the next release cycle to 
give it enough testing in linux-next.

Best regards
Krzysztof Kozlowski Oct. 2, 2020, 6:10 a.m. UTC | #3
On Fri, 2 Oct 2020 at 08:00, Marek Szyprowski <m.szyprowski@samsung.com> wrote:
>
> Hi Krzysztof,
>
> On 20.09.2020 17:27, Krzysztof Kozlowski wrote:
> > On Fri, Sep 11, 2020 at 02:22:36PM +0200, Marek Szyprowski wrote:
> >> Commits 1019fe2c7280 ("ARM: dts: exynos: Adjust bus related OPPs to the
> >> values correct for Exynos5422 Odroids") and 9ff416cf45a0 ("ARM: dts:
> >> exynos: Disable frequency scaling for FSYS bus on Odroid XU3 family")
> >> revealed that 'opp-shared' property for the Exynos bus OPPs was used
> >> incorrectly, what had the side-effect of disabling frequency scaling for
> >> the second and latter buses sharing given OPP-table.
> >>
> >> Fix this by removing bogus 'opp-shared' properties from Exynos4412 bus
> >> OPP-tables. This restores frequency scaling for the following busses:
> >> C2C, RightBus, and MFC.
> >>
> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> >> ---
> >>   arch/arm/boot/dts/exynos4412.dtsi | 6 ------
> >>   1 file changed, 6 deletions(-)
> >>
> > As discussed on IRC, I am waiting with these patches till you let me
> > know they're good.
>
> I got the information from Markus Reichl that this patch finally doesn't
> cause a regression. The issue he observed must be something else.
> Anyway, I would like to postpone this patch to the next release cycle to
> give it enough testing in linux-next.

Ok, thanks for letting me know.  I think postponing is a good idea.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index c74b1be12671..8afa634b2314 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -404,7 +404,6 @@ 
 
 		bus_dmc_opp_table: opp_table1 {
 			compatible = "operating-points-v2";
-			opp-shared;
 
 			opp-100000000 {
 				opp-hz = /bits/ 64 <100000000>;
@@ -431,7 +430,6 @@ 
 
 		bus_acp_opp_table: opp_table2 {
 			compatible = "operating-points-v2";
-			opp-shared;
 
 			opp-100000000 {
 				opp-hz = /bits/ 64 <100000000>;
@@ -497,7 +495,6 @@ 
 
 		bus_leftbus_opp_table: opp_table3 {
 			compatible = "operating-points-v2";
-			opp-shared;
 
 			opp-100000000 {
 				opp-hz = /bits/ 64 <100000000>;
@@ -520,7 +517,6 @@ 
 
 		bus_display_opp_table: opp_table4 {
 			compatible = "operating-points-v2";
-			opp-shared;
 
 			opp-160000000 {
 				opp-hz = /bits/ 64 <160000000>;
@@ -532,7 +528,6 @@ 
 
 		bus_fsys_opp_table: opp_table5 {
 			compatible = "operating-points-v2";
-			opp-shared;
 
 			opp-100000000 {
 				opp-hz = /bits/ 64 <100000000>;
@@ -544,7 +539,6 @@ 
 
 		bus_peri_opp_table: opp_table6 {
 			compatible = "operating-points-v2";
-			opp-shared;
 
 			opp-50000000 {
 				opp-hz = /bits/ 64 <50000000>;