| Message ID | 20201120085637.7299-3-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 75681980c4e3d89c55b5b8f20b8f4c1aace601be |
| Headers | show |
| Series | Fix USB2 PHY operation on Exynos542x | expand |
On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote: > USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the > recently introduced dedicated compatible for Exynos5420. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > --- > arch/arm/boot/dts/exynos54xx.dtsi | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi > index fe9d34c23374..2ddb7a5f12b3 100644 > --- a/arch/arm/boot/dts/exynos54xx.dtsi > +++ b/arch/arm/boot/dts/exynos54xx.dtsi > @@ -188,7 +188,7 @@ > compatible = "samsung,exynos4210-ehci"; > reg = <0x12110000 0x100>; > interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; > - phys = <&usb2_phy 1>; > + phys = <&usb2_phy 0>; > phy-names = "host"; > }; > > @@ -196,12 +196,12 @@ > compatible = "samsung,exynos4210-ohci"; > reg = <0x12120000 0x100>; > interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; > - phys = <&usb2_phy 1>; > + phys = <&usb2_phy 0>; > phy-names = "host"; > }; > > usb2_phy: phy@12130000 { > - compatible = "samsung,exynos5250-usb2-phy"; > + compatible = "samsung,exynos5420-usb2-phy"; The DTS change will wait till PHY driver adjustements get merged... or if the difference is not critical, maybe using both compatibles (5420 and 5250) would have sense? Best regards, Krzysztof
Hi Krzysztof, On 20.11.2020 12:05, Krzysztof Kozlowski wrote: > On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote: >> USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the >> recently introduced dedicated compatible for Exynos5420. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> >> --- >> arch/arm/boot/dts/exynos54xx.dtsi | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi >> index fe9d34c23374..2ddb7a5f12b3 100644 >> --- a/arch/arm/boot/dts/exynos54xx.dtsi >> +++ b/arch/arm/boot/dts/exynos54xx.dtsi >> @@ -188,7 +188,7 @@ >> compatible = "samsung,exynos4210-ehci"; >> reg = <0x12110000 0x100>; >> interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; >> - phys = <&usb2_phy 1>; >> + phys = <&usb2_phy 0>; >> phy-names = "host"; >> }; >> >> @@ -196,12 +196,12 @@ >> compatible = "samsung,exynos4210-ohci"; >> reg = <0x12120000 0x100>; >> interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; >> - phys = <&usb2_phy 1>; >> + phys = <&usb2_phy 0>; >> phy-names = "host"; >> }; >> >> usb2_phy: phy@12130000 { >> - compatible = "samsung,exynos5250-usb2-phy"; >> + compatible = "samsung,exynos5420-usb2-phy"; > The DTS change will wait till PHY driver adjustements get merged... or > if the difference is not critical, maybe using both compatibles (5420 > and 5250) would have sense? It won't work easily with both compatibles, because in the 5420 variant I've also changed the PHY indices (5420 has no device and second hsic phy). IMHO the dts change can wait for the next release. Best regards
On Fri, Nov 20, 2020 at 12:07:44PM +0100, Marek Szyprowski wrote: > Hi Krzysztof, > > On 20.11.2020 12:05, Krzysztof Kozlowski wrote: > > On Fri, Nov 20, 2020 at 09:56:37AM +0100, Marek Szyprowski wrote: > >> USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the > >> recently introduced dedicated compatible for Exynos5420. > >> > >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > >> --- > >> arch/arm/boot/dts/exynos54xx.dtsi | 6 +++--- > >> 1 file changed, 3 insertions(+), 3 deletions(-) > >> > >> diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi > >> index fe9d34c23374..2ddb7a5f12b3 100644 > >> --- a/arch/arm/boot/dts/exynos54xx.dtsi > >> +++ b/arch/arm/boot/dts/exynos54xx.dtsi > >> @@ -188,7 +188,7 @@ > >> compatible = "samsung,exynos4210-ehci"; > >> reg = <0x12110000 0x100>; > >> interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; > >> - phys = <&usb2_phy 1>; > >> + phys = <&usb2_phy 0>; > >> phy-names = "host"; > >> }; > >> > >> @@ -196,12 +196,12 @@ > >> compatible = "samsung,exynos4210-ohci"; > >> reg = <0x12120000 0x100>; > >> interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; > >> - phys = <&usb2_phy 1>; > >> + phys = <&usb2_phy 0>; > >> phy-names = "host"; > >> }; > >> > >> usb2_phy: phy@12130000 { > >> - compatible = "samsung,exynos5250-usb2-phy"; > >> + compatible = "samsung,exynos5420-usb2-phy"; > > The DTS change will wait till PHY driver adjustements get merged... or > > if the difference is not critical, maybe using both compatibles (5420 > > and 5250) would have sense? > > It won't work easily with both compatibles, because in the 5420 variant > I've also changed the PHY indices (5420 has no device and second hsic > phy). IMHO the dts change can wait for the next release. Thanks, applied. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos54xx.dtsi b/arch/arm/boot/dts/exynos54xx.dtsi index fe9d34c23374..2ddb7a5f12b3 100644 --- a/arch/arm/boot/dts/exynos54xx.dtsi +++ b/arch/arm/boot/dts/exynos54xx.dtsi @@ -188,7 +188,7 @@ compatible = "samsung,exynos4210-ehci"; reg = <0x12110000 0x100>; interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; - phys = <&usb2_phy 1>; + phys = <&usb2_phy 0>; phy-names = "host"; }; @@ -196,12 +196,12 @@ compatible = "samsung,exynos4210-ohci"; reg = <0x12120000 0x100>; interrupts = <GIC_SPI 71 IRQ_TYPE_LEVEL_HIGH>; - phys = <&usb2_phy 1>; + phys = <&usb2_phy 0>; phy-names = "host"; }; usb2_phy: phy@12130000 { - compatible = "samsung,exynos5250-usb2-phy"; + compatible = "samsung,exynos5420-usb2-phy"; reg = <0x12130000 0x100>; #phy-cells = <1>; };
USB2.0 PHY in Exynos5420 differs from Exynos5250 variant a bit, so use the recently introduced dedicated compatible for Exynos5420. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/boot/dts/exynos54xx.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)