| Message ID | 20210408134856.207305-1-clare.chenhui@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] clk: samsung: Remove redundant dev_err calls | expand |
On 08/04/2021 15:48, Chen Hui wrote: > There is error message within devm_ioremap_resource > already, so remove the dev_err calls to avoid redundant > error messages. > > Signed-off-by: Chen Hui <clare.chenhui@huawei.com> > --- > drivers/clk/samsung/clk-exynos4412-isp.c | 4 +--- > drivers/clk/samsung/clk-s5pv210-audss.c | 4 +--- > 2 files changed, 2 insertions(+), 6 deletions(-) Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Best regards, Krzysztof
On 08.04.2021 18:21, Krzysztof Kozlowski wrote: > On 08/04/2021 15:48, Chen Hui wrote: >> There is error message within devm_ioremap_resource >> already, so remove the dev_err calls to avoid redundant >> error messages. >> >> Signed-off-by: Chen Hui <clare.chenhui@huawei.com> >> --- >> drivers/clk/samsung/clk-exynos4412-isp.c | 4 +--- >> drivers/clk/samsung/clk-s5pv210-audss.c | 4 +--- >> 2 files changed, 2 insertions(+), 6 deletions(-) > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Thank you, patch applied.
diff --git a/drivers/clk/samsung/clk-exynos4412-isp.c b/drivers/clk/samsung/clk-exynos4412-isp.c index 4b9e73608c21..b69e381b8c0c 100644 --- a/drivers/clk/samsung/clk-exynos4412-isp.c +++ b/drivers/clk/samsung/clk-exynos4412-isp.c @@ -115,10 +115,8 @@ static int __init exynos4x12_isp_clk_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); reg_base = devm_ioremap_resource(dev, res); - if (IS_ERR(reg_base)) { - dev_err(dev, "failed to map registers\n"); + if (IS_ERR(reg_base)) return PTR_ERR(reg_base); - } exynos4x12_save_isp = samsung_clk_alloc_reg_dump(exynos4x12_clk_isp_save, ARRAY_SIZE(exynos4x12_clk_isp_save)); diff --git a/drivers/clk/samsung/clk-s5pv210-audss.c b/drivers/clk/samsung/clk-s5pv210-audss.c index 14985ebd043b..a7827a120695 100644 --- a/drivers/clk/samsung/clk-s5pv210-audss.c +++ b/drivers/clk/samsung/clk-s5pv210-audss.c @@ -72,10 +72,8 @@ static int s5pv210_audss_clk_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); reg_base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(reg_base)) { - dev_err(&pdev->dev, "failed to map audss registers\n"); + if (IS_ERR(reg_base)) return PTR_ERR(reg_base); - } clk_data = devm_kzalloc(&pdev->dev, struct_size(clk_data, hws, AUDSS_MAX_CLKS),
There is error message within devm_ioremap_resource already, so remove the dev_err calls to avoid redundant error messages. Signed-off-by: Chen Hui <clare.chenhui@huawei.com> --- drivers/clk/samsung/clk-exynos4412-isp.c | 4 +--- drivers/clk/samsung/clk-s5pv210-audss.c | 4 +--- 2 files changed, 2 insertions(+), 6 deletions(-)