diff mbox series

[-next] media: s3c-camif: fix PM reference leak in s3c_camif_open()

Message ID 20210409025709.181908-1-lujialin4@huawei.com (mailing list archive)
State Not Applicable
Headers show
Series [-next] media: s3c-camif: fix PM reference leak in s3c_camif_open() | expand

Commit Message

Lu Jialin April 9, 2021, 2:57 a.m. UTC
pm_runtime_get_sync will increment pm usage counter even it failed.
Forgetting to putting operation will result in reference leak here.
Fix it by replacing it with pm_runtime_resume_and_get to keep usage
counter balanced.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Lu Jialin <lujialin4@huawei.com>
 drivers/media/platform/s3c-camif/camif-capture.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff mbox series


diff --git a/drivers/media/platform/s3c-camif/camif-capture.c b/drivers/media/platform/s3c-camif/camif-capture.c
index 9ca49af29542..62241ec3b978 100644
--- a/drivers/media/platform/s3c-camif/camif-capture.c
+++ b/drivers/media/platform/s3c-camif/camif-capture.c
@@ -547,7 +547,7 @@  static int s3c_camif_open(struct file *file)
 	if (ret < 0)
 		goto unlock;
-	ret = pm_runtime_get_sync(camif->dev);
+	ret = pm_runtime_resume_and_get(camif->dev);
 	if (ret < 0)
 		goto err_pm;