| Message ID | 20210602110445.33536-1-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [RESEND,v2,1/4] mfd: sec-irq: Do not enforce (incorrect) interrupt trigger type | expand |
On 02/06/2021 13:04, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski <krzk@kernel.org> > > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Samsung PMIC drivers are used only on Devicetree boards. > > Additionally, the PMIC datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > Marek Szyprowski reports that together with DTS change (proper level in > DTS) it fixes RTC alarm failure that he observed from time to time on > TM2e board. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > > --- > > Rebased on https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/log/?h=for-mfd-next > > Changes since v1: > 1. Mention in commit msg that this fixes TM2e RTC alarm. > 2. Add Marek's tested-by. > --- > drivers/mfd/sec-irq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Dear Lee, This was already a resend. Any comments from your side? Best regards, Krzysztof
On Wed, 02 Jun 2021, Krzysztof Kozlowski wrote: > From: Krzysztof Kozlowski <krzk@kernel.org> > > Interrupt line can be configured on different hardware in different way, > even inverted. Therefore driver should not enforce specific trigger > type - edge falling - but instead rely on Devicetree to configure it. > > The Samsung PMIC drivers are used only on Devicetree boards. > > Additionally, the PMIC datasheets describe the interrupt line as active > low with a requirement of acknowledge from the CPU therefore the edge > falling is not correct. > > Marek Szyprowski reports that together with DTS change (proper level in > DTS) it fixes RTC alarm failure that he observed from time to time on > TM2e board. > > Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org> > Tested-by: Marek Szyprowski <m.szyprowski@samsung.com> > > --- > > Rebased on https://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git/log/?h=for-mfd-next > > Changes since v1: > 1. Mention in commit msg that this fixes TM2e RTC alarm. > 2. Add Marek's tested-by. > --- > drivers/mfd/sec-irq.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Applied, thanks.
diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index e473c2fb42d5..f5f59fdc72fe 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -479,8 +479,7 @@ int sec_irq_init(struct sec_pmic_dev *sec_pmic) } ret = devm_regmap_add_irq_chip(sec_pmic->dev, sec_pmic->regmap_pmic, - sec_pmic->irq, - IRQF_TRIGGER_FALLING | IRQF_ONESHOT, + sec_pmic->irq, IRQF_ONESHOT, 0, sec_irq_chip, &sec_pmic->irq_data); if (ret != 0) { dev_err(sec_pmic->dev, "Failed to register IRQ chip: %d\n", ret);