| Message ID | 20210917065436.145629-10-chanho61.park@samsung.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | introduce exynosauto v9 ufs driver | expand |
>-----Original Message----- >From: Chanho Park [mailto:chanho61.park@samsung.com] >Sent: Friday, September 17, 2021 12:24 PM >To: Alim Akhtar <alim.akhtar@samsung.com>; Avri Altman ><avri.altman@wdc.com>; James E . J . Bottomley <jejb@linux.ibm.com>; Martin >K . Petersen <martin.petersen@oracle.com>; Krzysztof Kozlowski ><krzysztof.kozlowski@canonical.com> >Cc: Bean Huo <beanhuo@micron.com>; Bart Van Assche ><bvanassche@acm.org>; Adrian Hunter <adrian.hunter@intel.com>; Christoph >Hellwig <hch@infradead.org>; Can Guo <cang@codeaurora.org>; Jaegeuk Kim ><jaegeuk@kernel.org>; Gyunghoon Kwon <goodjob.kwon@samsung.com>; >linux-samsung-soc@vger.kernel.org; linux-scsi@vger.kernel.org; Chanho Park ><chanho61.park@samsung.com>; Kiwoong Kim <kwmad.kim@samsung.com> >Subject: [PATCH v3 09/17] scsi: ufs: ufs-exynos: correct timeout value setting >registers > >PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL >PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL >PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL > >Cc: Alim Akhtar <alim.akhtar@samsung.com> >Cc: Kiwoong Kim <kwmad.kim@samsung.com> >Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >Signed-off-by: Chanho Park <chanho61.park@samsung.com> >--- Please add a [Fixes] tag with the original commit which introduce this With the above fix, feel free to add Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > drivers/scsi/ufs/ufs-exynos.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index >2024e44a09d7..e32f7d09db1a 100644 >--- a/drivers/scsi/ufs/ufs-exynos.c >+++ b/drivers/scsi/ufs/ufs-exynos.c >@@ -644,9 +644,9 @@ static int exynos_ufs_pre_pwr_mode(struct ufs_hba >*hba, > } > > /* setting for three timeout values for traffic class #0 */ >- ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA0), 8064); >- ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA1), >28224); >- ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA2), >20160); >+ ufshcd_dme_set(hba, UIC_ARG_MIB(DL_FC0PROTTIMEOUTVAL), 8064); >+ ufshcd_dme_set(hba, UIC_ARG_MIB(DL_TC0REPLAYTIMEOUTVAL), >28224); >+ ufshcd_dme_set(hba, UIC_ARG_MIB(DL_AFC0REQTIMEOUTVAL), 20160); > > return 0; > out: >-- >2.33.0
> >Subject: [PATCH v3 09/17] scsi: ufs: ufs-exynos: correct timeout value > >setting registers > > > >PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL > >PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL > >PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL > > > >Cc: Alim Akhtar <alim.akhtar@samsung.com> > >Cc: Kiwoong Kim <kwmad.kim@samsung.com> > >Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > >Signed-off-by: Chanho Park <chanho61.park@samsung.com> > >--- > Please add a [Fixes] tag with the original commit which introduce this I'll add below "Fixes" tag. Fixes: a967ddb22d94 ("scsi: ufs: ufs-exynos: Apply vendor-specific values for three timeouts") > > With the above fix, feel free to add > > Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> Thanks for your review :) Best Regards, Chanho Park
diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index 2024e44a09d7..e32f7d09db1a 100644 --- a/drivers/scsi/ufs/ufs-exynos.c +++ b/drivers/scsi/ufs/ufs-exynos.c @@ -644,9 +644,9 @@ static int exynos_ufs_pre_pwr_mode(struct ufs_hba *hba, } /* setting for three timeout values for traffic class #0 */ - ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA0), 8064); - ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA1), 28224); - ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA2), 20160); + ufshcd_dme_set(hba, UIC_ARG_MIB(DL_FC0PROTTIMEOUTVAL), 8064); + ufshcd_dme_set(hba, UIC_ARG_MIB(DL_TC0REPLAYTIMEOUTVAL), 28224); + ufshcd_dme_set(hba, UIC_ARG_MIB(DL_AFC0REQTIMEOUTVAL), 20160); return 0; out:
PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL Cc: Alim Akhtar <alim.akhtar@samsung.com> Cc: Kiwoong Kim <kwmad.kim@samsung.com> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Signed-off-by: Chanho Park <chanho61.park@samsung.com> --- drivers/scsi/ufs/ufs-exynos.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)