diff mbox series

scsi: ufs: ufs-exynos: correct timeout value setting registers

Message ID 20211018062841.18226-1-chanho61.park@samsung.com (mailing list archive)
State Accepted
Commit 282da7cef078a87b6d5e8ceba8b17e428cf0e37c
Headers show
Series scsi: ufs: ufs-exynos: correct timeout value setting registers | expand

Commit Message

Chanho Park Oct. 18, 2021, 6:28 a.m. UTC
PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL
PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL
PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL

Cc: Alim Akhtar <alim.akhtar@samsung.com>
Cc: Kiwoong Kim <kwmad.kim@samsung.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
Fixes: a967ddb22d94 ("scsi: ufs: ufs-exynos: Apply vendor-specific values for three timeouts")
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
Signed-off-by: Chanho Park <chanho61.park@samsung.com>
---
- Separated this patch from [1] as suggested by Avri Altman.
[1]: https://lore.kernel.org/linux-scsi/20211007080934.108804-1-chanho61.park@samsung.com/

 drivers/scsi/ufs/ufs-exynos.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Avri Altman Oct. 18, 2021, 6:33 a.m. UTC | #1
> 
> PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL
> PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL
> PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL
> 
> Cc: Alim Akhtar <alim.akhtar@samsung.com>
> Cc: Kiwoong Kim <kwmad.kim@samsung.com>
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com>
> Fixes: a967ddb22d94 ("scsi: ufs: ufs-exynos: Apply vendor-specific values for
> three timeouts")
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> Signed-off-by: Chanho Park <chanho61.park@samsung.com>
Reviewed-by: Avri Altman <avri.altman@wdc.com>


> ---
> - Separated this patch from [1] as suggested by Avri Altman.
> [1]: https://lore.kernel.org/linux-scsi/20211007080934.108804-1-
> chanho61.park@samsung.com/
> 
>  drivers/scsi/ufs/ufs-exynos.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c index
> d81a2eb894ad..226e7e64fad4 100644
> --- a/drivers/scsi/ufs/ufs-exynos.c
> +++ b/drivers/scsi/ufs/ufs-exynos.c
> @@ -643,9 +643,9 @@ static int exynos_ufs_pre_pwr_mode(struct ufs_hba
> *hba,
>         }
> 
>         /* setting for three timeout values for traffic class #0 */
> -       ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA0), 8064);
> -       ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA1),
> 28224);
> -       ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA2),
> 20160);
> +       ufshcd_dme_set(hba, UIC_ARG_MIB(DL_FC0PROTTIMEOUTVAL), 8064);
> +       ufshcd_dme_set(hba, UIC_ARG_MIB(DL_TC0REPLAYTIMEOUTVAL),
> 28224);
> +       ufshcd_dme_set(hba, UIC_ARG_MIB(DL_AFC0REQTIMEOUTVAL),
> 20160);
> 
>         return 0;
>  out:
> --
> 2.33.0
Martin K. Petersen Oct. 21, 2021, 3:40 a.m. UTC | #2
On Mon, 18 Oct 2021 15:28:41 +0900, Chanho Park wrote:

> PA_PWRMODEUSERDATA0 -> DL_FC0PROTTIMEOUTVAL
> PA_PWRMODEUSERDATA1 -> DL_TC0REPLAYTIMEOUTVAL
> PA_PWRMODEUSERDATA2 -> DL_AFC0REQTIMEOUTVAL
> 
> 

Applied to 5.15/scsi-fixes, thanks!

[1/1] scsi: ufs: ufs-exynos: correct timeout value setting registers
      https://git.kernel.org/mkp/scsi/c/282da7cef078
diff mbox series

Patch

diff --git a/drivers/scsi/ufs/ufs-exynos.c b/drivers/scsi/ufs/ufs-exynos.c
index d81a2eb894ad..226e7e64fad4 100644
--- a/drivers/scsi/ufs/ufs-exynos.c
+++ b/drivers/scsi/ufs/ufs-exynos.c
@@ -643,9 +643,9 @@  static int exynos_ufs_pre_pwr_mode(struct ufs_hba *hba,
 	}
 
 	/* setting for three timeout values for traffic class #0 */
-	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA0), 8064);
-	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA1), 28224);
-	ufshcd_dme_set(hba, UIC_ARG_MIB(PA_PWRMODEUSERDATA2), 20160);
+	ufshcd_dme_set(hba, UIC_ARG_MIB(DL_FC0PROTTIMEOUTVAL), 8064);
+	ufshcd_dme_set(hba, UIC_ARG_MIB(DL_TC0REPLAYTIMEOUTVAL), 28224);
+	ufshcd_dme_set(hba, UIC_ARG_MIB(DL_AFC0REQTIMEOUTVAL), 20160);
 
 	return 0;
 out: