| Message ID | 20211030121410.65834-1-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | ff6780f1d0221b19134287d4adf3d3cf02117542 |
| Headers | show |
| Series | ARM: dts: exynos/i9100: Fix Bluetooth node | expand |
On 30/10/2021 14:14, Paul Cercueil wrote: > The reset GPIO was marked active-high, which is against what's specified > in the documentation. Mark the reset GPIO as active-low. With this > change, Bluetooth can now be used on the i9100. > > Also switch away from using the deprecated 'host-wakeup-gpios' property, > and use a 'host-wakeup' interrupt instead. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> Thanks for the patch, but please split it into two commits and add a "Fixes" tag for the "reset-gpios" one. All rest looks good, nice patch! Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts index 55922176807e..76b1017e05e8 100644 --- a/arch/arm/boot/dts/exynos4210-i9100.dts +++ b/arch/arm/boot/dts/exynos4210-i9100.dts @@ -827,9 +827,12 @@ bluetooth { compatible = "brcm,bcm4330-bt"; shutdown-gpios = <&gpl0 4 GPIO_ACTIVE_HIGH>; - reset-gpios = <&gpl1 0 GPIO_ACTIVE_HIGH>; + reset-gpios = <&gpl1 0 GPIO_ACTIVE_LOW>; device-wakeup-gpios = <&gpx3 1 GPIO_ACTIVE_HIGH>; - host-wakeup-gpios = <&gpx2 6 GPIO_ACTIVE_HIGH>; + + interrupt-parent = <&gpx2>; + interrupts = <6 IRQ_TYPE_EDGE_FALLING>; + interrupt-names = "host-wakeup"; }; };
The reset GPIO was marked active-high, which is against what's specified in the documentation. Mark the reset GPIO as active-low. With this change, Bluetooth can now be used on the i9100. Also switch away from using the deprecated 'host-wakeup-gpios' property, and use a 'host-wakeup' interrupt instead. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- arch/arm/boot/dts/exynos4210-i9100.dts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)