From patchwork Fri Dec 3 18:35:17 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sam Protsenko X-Patchwork-Id: 12655629 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1983FC433F5 for ; Fri, 3 Dec 2021 18:35:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382728AbhLCSjG (ORCPT ); Fri, 3 Dec 2021 13:39:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53912 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1382735AbhLCSip (ORCPT ); Fri, 3 Dec 2021 13:38:45 -0500 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1048AC061A83 for ; Fri, 3 Dec 2021 10:35:21 -0800 (PST) Received: by mail-lj1-x22e.google.com with SMTP id e11so7786690ljo.13 for ; Fri, 03 Dec 2021 10:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aQnrspX0S8NnC4mxCmKPdkJ6I75373YtJdts4KCHDH8=; b=qYK9cCqqjz4Qv85bmedDRlhwPofmfrLO949h2gjaDftYpZEPsucz4ommT5hBAk6+9z P/55ZUobXmg6hhr0wiBP9Lv6hu9/eS5TCPMJdkUdVcuvn8ta0CTR+betnF8V5TlFu2id UjKfuqV7P7yEJgF3hYBxAsSHUeY+fJRuiUqu/NLbjk8Kj3D4HqARTAYnCz2+PHGnaKgH 0ATTA5TiEVmka2z0SjtA1AorX+BpJVRgs/ii6vwd2Magx4EsF5aoRpskY3nSYEjcK0qq Q+W3Bu5xLPXwMBGIawjEPMfMU+pLWHCl3JhiSASuGe9A9ccrlF7Ujg2I4SL1Ss5KEquV AO5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=aQnrspX0S8NnC4mxCmKPdkJ6I75373YtJdts4KCHDH8=; b=eaPciQUTSQjHdfDhvo9koBQu/DsWo/uEM1v9XRUTUHtKeixfplGDrbGP7+rIAB2Cgn qxUhxNqOO20PRFRxbOVa3w6xNMy+JUvX/FPmLH9TafEVwM+ofdu0pYJcSyKO+7a+Iin7 1/rELV/+O459ln8oCldnM7cqZVWOZzh6zms8upunW1Ud83zx79UF/CsT27LTKn/7HcXz pLfDLNQ4X32oI32g4x/T1KpOfxQsUx4uSAj4RKbN4EoQ5io1GVrljsumIbUnoNy/oNrg T2sX7nBNGXv61j0wyChUl+N+qVapSe3nYhYtcVselOXiKXHCunPxuX3rHi1Sl/+Qdljq n1mA== X-Gm-Message-State: AOAM530V9n1DTzCUThje7Y+Y+7dOqArmceHbj8NiBCg8O9oCOaLVB/B9 QixrVeOFp+NhR1dmdUlMlbYPeRcCtea/vgaC X-Google-Smtp-Source: ABdhPJwj4GY/waMrbwCZWa+p5cuBxz4LdUMdBeiNnkEryxqskHF71WC2CXIypDg2pYfKf9/x2sxgfw== X-Received: by 2002:a2e:9787:: with SMTP id y7mr19557627lji.228.1638556519298; Fri, 03 Dec 2021 10:35:19 -0800 (PST) Received: from localhost ([31.134.121.151]) by smtp.gmail.com with ESMTPSA id f13sm462261lfc.215.2021.12.03.10.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Dec 2021 10:35:18 -0800 (PST) From: Sam Protsenko To: Rob Herring Cc: Krzysztof Kozlowski , Geert Uytterhoeven , Masahiro Yamada , David Virag , Jaewon Kim , linux-samsung-soc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] dt-bindings: Only show unique unit address warning for enabled nodes Date: Fri, 3 Dec 2021 20:35:17 +0200 Message-Id: <20211203183517.11390-1-semen.protsenko@linaro.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-samsung-soc@vger.kernel.org There are valid cases when two nodes can have the same address. For example, in Exynos SoCs there is USI IP-core, which might be configured to provide UART, SPI or I2C block, all of which having the same base register address. But only one can be enabled at a time. That looks like this: usi@138200c0 { serial@13820000 { status = "okay"; }; i2c@13820000 { status = "disabled"; }; }; When running "make dt_binding_check", it reports next warning: Warning (unique_unit_address): /example-0/usi@138200c0/serial@13820000: duplicate unit-address (also used in node /example-0/usi@138200c0/i2c@13820000) Disable "unique_unit_address" in DTC_FLAGS to suppress warnings like that, but enable "unique_unit_address_if_enabled" warning, so that dtc still reports a warning when two enabled nodes are having the same address. Signed-off-by: Sam Protsenko Reported-by: Rob Herring Suggested-by: Rob Herring --- Documentation/devicetree/bindings/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile index c9abfbe3f0aa..41c555181b6f 100644 --- a/Documentation/devicetree/bindings/Makefile +++ b/Documentation/devicetree/bindings/Makefile @@ -65,7 +65,9 @@ DT_DOCS = $(patsubst $(srctree)/%,%,$(shell $(find_all_cmd))) override DTC_FLAGS := \ -Wno-avoid_unnecessary_addr_size \ -Wno-graph_child_address \ - -Wno-interrupt_provider + -Wno-interrupt_provider \ + -Wno-unique_unit_address \ + -Wunique_unit_address_if_enabled # Disable undocumented compatible checks until warning free override DT_CHECKER_FLAGS ?=