| Message ID | 20220111201722.327219-22-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | pinctrl: dt-bindings: samsung: convert to dtschema | expand |
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > Sent: Wednesday, January 12, 2022 5:17 AM > To: Tomasz Figa <tomasz.figa@gmail.com>; Krzysztof Kozlowski > <krzysztof.kozlowski@canonical.com>; Sylwester Nawrocki > <s.nawrocki@samsung.com>; Linus Walleij <linus.walleij@linaro.org>; Rob > Herring <robh+dt@kernel.org>; linux-arm-kernel@lists.infradead.org; linux- > samsung-soc@vger.kernel.org; linux-gpio@vger.kernel.org; > devicetree@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Marek Szyprowski <m.szyprowski@samsung.com>; Sam Protsenko > <semen.protsenko@linaro.org>; Chanho Park <chanho61.park@samsung.com>; > Alim Akhtar <alim.akhtar@gmail.com> > Subject: [PATCH v2 28/28] arm64: dts: exynos: use dedicated wake-up > pinctrl compatible in ExynosAutov9 > > Older Samsung Exynos SoC pin controller nodes (Exynos3250, Exynos4, > Exynos5, Exynos5433) with external wake-up interrupts, expected to have > one interrupt for multiplexing these wake-up interrupts. Also they > expected to have exactly one pin controller capable of external wake-up > interrupts. > > It seems however that newer ARMv8 Exynos SoC like Exynos850 and > ExynosAutov9 have differences: > 1. No multiplexed external wake-up interrupt, only direct, 2. More than > one pin controller capable of external wake-up interrupts. > > Use dedicated ExynosAutov9 compatible for its external wake-up interrupts > controller to indicate the differences. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> Reviewed-by: Chanho Park <chanho61.park@samsung.com> And you can also put Tested-by: Chanho Park <chanho61.park@samsung.com> Best Regards, Chanho Park
On Tue, 11 Jan 2022 at 22:19, Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> wrote: > > Older Samsung Exynos SoC pin controller nodes (Exynos3250, Exynos4, > Exynos5, Exynos5433) with external wake-up interrupts, expected to have > one interrupt for multiplexing these wake-up interrupts. Also they > expected to have exactly one pin controller capable of external wake-up > interrupts. > > It seems however that newer ARMv8 Exynos SoC like Exynos850 and > ExynosAutov9 have differences: > 1. No multiplexed external wake-up interrupt, only direct, > 2. More than one pin controller capable of external wake-up interrupts. > > Use dedicated ExynosAutov9 compatible for its external wake-up interrupts > controller to indicate the differences. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- Reviewed-by: Sam Protsenko <semen.protsenko@linaro.org> > arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi > index de8fcb82eaec..807d500d6022 100644 > --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi > +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi > @@ -208,7 +208,7 @@ pinctrl_alive: pinctrl@10450000 { > reg = <0x10450000 0x1000>; > > wakeup-interrupt-controller { > - compatible = "samsung,exynos7-wakeup-eint"; > + compatible = "samsung,exynosautov9-wakeup-eint"; > }; > }; > > -- > 2.32.0 >
diff --git a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi index de8fcb82eaec..807d500d6022 100644 --- a/arch/arm64/boot/dts/exynos/exynosautov9.dtsi +++ b/arch/arm64/boot/dts/exynos/exynosautov9.dtsi @@ -208,7 +208,7 @@ pinctrl_alive: pinctrl@10450000 { reg = <0x10450000 0x1000>; wakeup-interrupt-controller { - compatible = "samsung,exynos7-wakeup-eint"; + compatible = "samsung,exynosautov9-wakeup-eint"; }; };
Older Samsung Exynos SoC pin controller nodes (Exynos3250, Exynos4, Exynos5, Exynos5433) with external wake-up interrupts, expected to have one interrupt for multiplexing these wake-up interrupts. Also they expected to have exactly one pin controller capable of external wake-up interrupts. It seems however that newer ARMv8 Exynos SoC like Exynos850 and ExynosAutov9 have differences: 1. No multiplexed external wake-up interrupt, only direct, 2. More than one pin controller capable of external wake-up interrupts. Use dedicated ExynosAutov9 compatible for its external wake-up interrupts controller to indicate the differences. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- arch/arm64/boot/dts/exynos/exynosautov9.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)