| Message ID | 20220129173407.278591-1-krzysztof.kozlowski@canonical.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0b59bc00a6936e8670b58d4307a2cfba341d40d0 |
| Headers | show |
| Series | clk: samsung: fix missing Tesla FSD dependency on Exynos | expand |
On 29/01/2022 18:34, Krzysztof Kozlowski wrote: > The Tesla FSD clock controller driver uses shared parts from Exynos > ARM64 clock drivers, so add proper dependency to fix COMPILE_TEST build > errors like: > > /usr/bin/aarch64-linux-gnu-ld: drivers/clk/samsung/clk-fsd.o: in function `fsd_cmu_probe': > clk-fsd.c:(.init.text+0x9c): undefined reference to `exynos_arm64_register_cmu' > > Reported-by: kernel test robot <lkp@intel.com> > Fixes: e3f3dc3810d3 ("clk: samsung: fsd: Add cmu_peric block clock information") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> > --- > drivers/clk/samsung/Kconfig | 1 + > 1 file changed, 1 insertion(+) > What I forgot to mention - the commit being fixes is in my tree, so this should go as well via Samsung SoC. Best regards, Krzysztof
>-----Original Message----- >From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@canonical.com] >Sent: Saturday, January 29, 2022 11:04 PM >To: Sylwester Nawrocki <s.nawrocki@samsung.com>; Tomasz Figa ><tomasz.figa@gmail.com>; Chanwoo Choi <cw00.choi@samsung.com>; Alim >Akhtar <alim.akhtar@samsung.com>; Michael Turquette ><mturquette@baylibre.com>; Stephen Boyd <sboyd@kernel.org>; Krzysztof >Kozlowski <krzysztof.kozlowski@canonical.com>; linux-samsung- >soc@vger.kernel.org; linux-clk@vger.kernel.org; linux- >kernel@vger.kernel.org >Cc: kernel test robot <lkp@intel.com> >Subject: [PATCH] clk: samsung: fix missing Tesla FSD dependency on Exynos > >The Tesla FSD clock controller driver uses shared parts from Exynos >ARM64 clock drivers, so add proper dependency to fix COMPILE_TEST build >errors like: > > /usr/bin/aarch64-linux-gnu-ld: drivers/clk/samsung/clk-fsd.o: in function >`fsd_cmu_probe': > clk-fsd.c:(.init.text+0x9c): undefined reference to >`exynos_arm64_register_cmu' > >Reported-by: kernel test robot <lkp@intel.com> >Fixes: e3f3dc3810d3 ("clk: samsung: fsd: Add cmu_peric block clock >information") >Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> >--- Thanks Krzysztof for a quick patch Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > drivers/clk/samsung/Kconfig | 1 + > 1 file changed, 1 insertion(+) > >diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index >5f64c58f120f..8e8245ab3fd1 100644 >--- a/drivers/clk/samsung/Kconfig >+++ b/drivers/clk/samsung/Kconfig >@@ -129,6 +129,7 @@ config S3C2443_COMMON_CLK config >TESLA_FSD_COMMON_CLK > bool "Tesla FSD clock controller support" if COMPILE_TEST > depends on COMMON_CLK_SAMSUNG >+ depends on EXYNOS_ARM64_COMMON_CLK > help > Support for the clock controller present on the Tesla FSD SoC. > Choose Y here only if you build for this SoC. >-- >2.32.0
On Sat, 29 Jan 2022 18:34:07 +0100, Krzysztof Kozlowski wrote: > The Tesla FSD clock controller driver uses shared parts from Exynos > ARM64 clock drivers, so add proper dependency to fix COMPILE_TEST build > errors like: > > /usr/bin/aarch64-linux-gnu-ld: drivers/clk/samsung/clk-fsd.o: in function `fsd_cmu_probe': > clk-fsd.c:(.init.text+0x9c): undefined reference to `exynos_arm64_register_cmu' > > [...] Applied, thanks! [1/1] clk: samsung: fix missing Tesla FSD dependency on Exynos commit: 0b59bc00a6936e8670b58d4307a2cfba341d40d0 Best regards,
diff --git a/drivers/clk/samsung/Kconfig b/drivers/clk/samsung/Kconfig index 5f64c58f120f..8e8245ab3fd1 100644 --- a/drivers/clk/samsung/Kconfig +++ b/drivers/clk/samsung/Kconfig @@ -129,6 +129,7 @@ config S3C2443_COMMON_CLK config TESLA_FSD_COMMON_CLK bool "Tesla FSD clock controller support" if COMPILE_TEST depends on COMMON_CLK_SAMSUNG + depends on EXYNOS_ARM64_COMMON_CLK help Support for the clock controller present on the Tesla FSD SoC. Choose Y here only if you build for this SoC.
The Tesla FSD clock controller driver uses shared parts from Exynos ARM64 clock drivers, so add proper dependency to fix COMPILE_TEST build errors like: /usr/bin/aarch64-linux-gnu-ld: drivers/clk/samsung/clk-fsd.o: in function `fsd_cmu_probe': clk-fsd.c:(.init.text+0x9c): undefined reference to `exynos_arm64_register_cmu' Reported-by: kernel test robot <lkp@intel.com> Fixes: e3f3dc3810d3 ("clk: samsung: fsd: Add cmu_peric block clock information") Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@canonical.com> --- drivers/clk/samsung/Kconfig | 1 + 1 file changed, 1 insertion(+)