diff mbox series

media: exynos4-is: Fix compile warning

Message ID 20220420051149epcms1p469ac91524037074586d368fe901e0964@epcms1p4 (mailing list archive)
State Accepted
Commit e080f5c1f2b6d02c02ee5d674e0e392ccf63bbaf
Headers show
Series media: exynos4-is: Fix compile warning | expand

Commit Message

Kwanghoon Son April 20, 2022, 5:11 a.m. UTC
declare 'static' to fix warning message from
https://lore.kernel.org/linux-media/202204192315.ZHbOex51-lkp@intel.com/T/#u

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Kwang Son <k.son@samsung.com>
---
 drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Krzysztof Kozlowski April 20, 2022, 6:31 a.m. UTC | #1
Hi,

You sent three almost the same patches, so how can we know which one to
choose? Please use versioning of the patches (git help format-patch).

On 20/04/2022 07:11, Kwanghoon Son wrote:
> declare 'static' to fix warning message from
> https://lore.kernel.org/linux-media/202204192315.ZHbOex51-lkp@intel.com/T/#u

No external references, instead quote trimmed warning message (only the
relevant part).

> 
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Kwang Son <k.son@samsung.com>

Name used here does not match name used for commit, so please fix your
setup.


Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h b/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
index edcb3a5e3cb9..2dd4ddbc748a 100644
--- a/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
+++ b/drivers/media/platform/samsung/exynos4-is/fimc-isp-video.h
@@ -32,7 +32,7 @@  static inline int fimc_isp_video_device_register(struct fimc_isp *isp,
 	return 0;
 }
 
-void fimc_isp_video_device_unregister(struct fimc_isp *isp,
+static inline void fimc_isp_video_device_unregister(struct fimc_isp *isp,
 				enum v4l2_buf_type type)
 {
 }