diff mbox series

[06/10] dt-bindings: mfd: samsung,exynos5433-lpass: fix 'dma-channels/requests' properties

Message ID 20220427155840.596535-7-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Commit 380422ad344d461901dca85970ecc976e182f0c9
Headers show
Series ARM/arm64: dts: use proper 'dma-channels/requests' properties | expand

Commit Message

Krzysztof Kozlowski April 27, 2022, 3:58 p.m. UTC
pl330 DMA controller bindings documented 'dma-channels' and
'dma-requests' properties (without leading hash sign), so fix the DTS to
match the bindings.

Reported-by: Rob Herring <robh@kernel.org>
Fixes: e18183cefc8b ("mfd: Add DT bindings documentation for Samsung Exynos LPASS")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml     | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Alim Akhtar April 27, 2022, 4:41 p.m. UTC | #1
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Wednesday, April 27, 2022 9:29 PM
>To: Lee Jones <lee.jones@linaro.org>; Rob Herring <robh+dt@kernel.org>;
>Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Dinh Nguyen <dinguyen@kernel.org>; Michal
>Simek <michal.simek@xilinx.com>; Liviu Dudau <liviu.dudau@arm.com>;
>Sudeep Holla <sudeep.holla@arm.com>; Lorenzo Pieralisi
><lorenzo.pieralisi@arm.com>; Ray Jui <rjui@broadcom.com>; Scott Branden
><sbranden@broadcom.com>; Broadcom Kernel Team <bcm-kernel-feedback-
>list@broadcom.com>; Sylwester Nawrocki <s.nawrocki@samsung.com>;
>devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org; linux-kernel@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>; Rob Herring
><robh@kernel.org>
>Subject: [PATCH 06/10] dt-bindings: mfd: samsung,exynos5433-lpass: fix
>'dma-channels/requests' properties
>
>pl330 DMA controller bindings documented 'dma-channels' and 'dma-
>requests' properties (without leading hash sign), so fix the DTS to match
the
>bindings.
>
>Reported-by: Rob Herring <robh@kernel.org>
>Fixes: e18183cefc8b ("mfd: Add DT bindings documentation for Samsung
>Exynos LPASS")
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---
Looking at Documentation/devicetree/bindings/dma/dma-common.yaml
This change looks good.

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


> .../devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml     | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-
>lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-
>lpass.yaml
>index f7bb67d10eff..b97b06848729 100644
>--- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-
>lpass.yaml
>+++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-
>lpass.yam
>+++ l
>@@ -79,8 +79,8 @@ examples:
>             clocks = <&cmu_aud CLK_ACLK_DMAC>;
>             clock-names = "apb_pclk";
>             #dma-cells = <1>;
>-            #dma-channels = <8>;
>-            #dma-requests = <32>;
>+            dma-channels = <8>;
>+            dma-requests = <32>;
>             power-domains = <&pd_aud>;
>         };
>
>--
>2.32.0
Rob Herring April 27, 2022, 6:25 p.m. UTC | #2
On Wed, 27 Apr 2022 17:58:36 +0200, Krzysztof Kozlowski wrote:
> pl330 DMA controller bindings documented 'dma-channels' and
> 'dma-requests' properties (without leading hash sign), so fix the DTS to
> match the bindings.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: e18183cefc8b ("mfd: Add DT bindings documentation for Samsung Exynos LPASS")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>
Lee Jones April 28, 2022, 9:53 a.m. UTC | #3
On Wed, 27 Apr 2022, Krzysztof Kozlowski wrote:

> pl330 DMA controller bindings documented 'dma-channels' and
> 'dma-requests' properties (without leading hash sign), so fix the DTS to
> match the bindings.
> 
> Reported-by: Rob Herring <robh@kernel.org>
> Fixes: e18183cefc8b ("mfd: Add DT bindings documentation for Samsung Exynos LPASS")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
>  .../devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml     | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Applied, thanks.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
index f7bb67d10eff..b97b06848729 100644
--- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
+++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
@@ -79,8 +79,8 @@  examples:
             clocks = <&cmu_aud CLK_ACLK_DMAC>;
             clock-names = "apb_pclk";
             #dma-cells = <1>;
-            #dma-channels = <8>;
-            #dma-requests = <32>;
+            dma-channels = <8>;
+            dma-requests = <32>;
             power-domains = <&pd_aud>;
         };