| Message ID | 20220430121902.59895-3-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 361736cf495ccc49df5ae66d0f9f10a55976d2da |
| Headers | show |
| Series | ARM/arm64: dts: drop useless 'dma-channels/requests' properties | expand |
On Sat, 30 Apr 2022 14:18:55 +0200, Krzysztof Kozlowski wrote: > The pl330 DMA controller provides number of DMA channels and requests > through its registers, so duplicating this information (with a chance of > mistakes) in DTS is pointless. Additionally the DTS used always wrong > property names which causes DT schema check failures - the bindings > documented 'dma-channels' and 'dma-requests' properties without leading > hash sign. > > [...] Applied, thanks! [2/9] ARM: dts: socfpga: drop useless 'dma-channels/requests' properties commit: 361736cf495ccc49df5ae66d0f9f10a55976d2da Best regards,
diff --git a/arch/arm/boot/dts/socfpga.dtsi b/arch/arm/boot/dts/socfpga.dtsi index b8c5dd7860cb..bfaef45bdd04 100644 --- a/arch/arm/boot/dts/socfpga.dtsi +++ b/arch/arm/boot/dts/socfpga.dtsi @@ -80,8 +80,6 @@ pdma: pdma@ffe01000 { <0 110 4>, <0 111 4>; #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; clocks = <&l4_main_clk>; clock-names = "apb_pclk"; resets = <&rst DMA_RESET>; diff --git a/arch/arm/boot/dts/socfpga_arria10.dtsi b/arch/arm/boot/dts/socfpga_arria10.dtsi index f1e50d2e623a..26bda2557fe8 100644 --- a/arch/arm/boot/dts/socfpga_arria10.dtsi +++ b/arch/arm/boot/dts/socfpga_arria10.dtsi @@ -73,8 +73,6 @@ pdma: pdma@ffda1000 { <0 90 IRQ_TYPE_LEVEL_HIGH>, <0 91 IRQ_TYPE_LEVEL_HIGH>; #dma-cells = <1>; - #dma-channels = <8>; - #dma-requests = <32>; clocks = <&l4_main_clk>; clock-names = "apb_pclk"; resets = <&rst DMA_RESET>, <&rst DMA_OCP_RESET>;
The pl330 DMA controller provides number of DMA channels and requests through its registers, so duplicating this information (with a chance of mistakes) in DTS is pointless. Additionally the DTS used always wrong property names which causes DT schema check failures - the bindings documented 'dma-channels' and 'dma-requests' properties without leading hash sign. Reported-by: Rob Herring <robh@kernel.org> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- arch/arm/boot/dts/socfpga.dtsi | 2 -- arch/arm/boot/dts/socfpga_arria10.dtsi | 2 -- 2 files changed, 4 deletions(-)