| Message ID | 20220523145513.12341-1-linmq006@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | c4c79525042a4a7df96b73477feaf232fe44ae81 |
| Headers | show |
| Series | ARM: exynos: Fix refcount leak in exynos_map_pmu | expand |
On Mon, 23 May 2022 18:55:13 +0400, Miaoqian Lin wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > of_node_put() checks null pointer. > > Applied, thanks! [1/1] ARM: exynos: Fix refcount leak in exynos_map_pmu https://git.kernel.org/krzk/linux/c/c4c79525042a4a7df96b73477feaf232fe44ae81 Best regards,
diff --git a/arch/arm/mach-exynos/exynos.c b/arch/arm/mach-exynos/exynos.c index 8b48326be9fd..51a247ca4da8 100644 --- a/arch/arm/mach-exynos/exynos.c +++ b/arch/arm/mach-exynos/exynos.c @@ -149,6 +149,7 @@ static void exynos_map_pmu(void) np = of_find_matching_node(NULL, exynos_dt_pmu_match); if (np) pmu_base_addr = of_iomap(np, 0); + of_node_put(np); } static void __init exynos_init_irq(void)
of_find_matching_node() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. of_node_put() checks null pointer. Fixes: fce9e5bb2526 ("ARM: EXYNOS: Add support for mapping PMU base address via DT") Signed-off-by: Miaoqian Lin <linmq006@gmail.com> --- arch/arm/mach-exynos/exynos.c | 1 + 1 file changed, 1 insertion(+)