| Message ID | 20220609060323.106095-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 0356163e5883e298b518cd16517be633824987f9 |
| Headers | show |
| Series | [-next] spi: Return true/false (not 1/0) from bool function | expand |
On 09/06/2022 08:03, Yang Li wrote: > Return boolean values ("true" or "false") instead of 1 or 0 from bool > function. This fixes the following warnings from coccicheck: > > ./drivers/spi/spi-s3c64xx.c:385:9-10: WARNING: return of 0/1 in function > 's3c64xx_spi_can_dma' with return type bool > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> It was reported by coccinelle, not robot, wasn't it? I cannot find this report. This is an open source work and public collaboration. The "Reported-by" usually means that the issue was reported. Usually in public. Can we see the report? Otherwise adding non-public reports is useless and clutters our report-credit-system. > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/spi/spi-s3c64xx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c > index 82558e37c735..28e7b7cb68a7 100644 > --- a/drivers/spi/spi-s3c64xx.c > +++ b/drivers/spi/spi-s3c64xx.c > @@ -382,7 +382,7 @@ static bool s3c64xx_spi_can_dma(struct spi_master *master, > if (sdd->rx_dma.ch && sdd->tx_dma.ch) { > return xfer->len > (FIFO_LVL_MASK(sdd) >> 1) + 1; > } else { > - return 0; > + return false; > } > > } Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 09/06/2022 07:36, Krzysztof Kozlowski wrote: > On 09/06/2022 08:03, Yang Li wrote: >> Return boolean values ("true" or "false") instead of 1 or 0 from bool >> function. This fixes the following warnings from coccicheck: >> >> ./drivers/spi/spi-s3c64xx.c:385:9-10: WARNING: return of 0/1 in function >> 's3c64xx_spi_can_dma' with return type bool >> >> Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > It was reported by coccinelle, not robot, wasn't it? > > I cannot find this report. Yeah, I was similarly confused by the patches on my driver. Spent some time digging through quarantine systems etc to try and find the report & couldn't. I hope I didn't miss something. > This is an open source work and public > collaboration. The "Reported-by" usually means that the issue was > reported. Usually in public. Can we see the report? > Otherwise adding non-public reports is useless and clutters our > report-credit-system. > > > >> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> >> --- >> drivers/spi/spi-s3c64xx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c >> index 82558e37c735..28e7b7cb68a7 100644 >> --- a/drivers/spi/spi-s3c64xx.c >> +++ b/drivers/spi/spi-s3c64xx.c >> @@ -382,7 +382,7 @@ static bool s3c64xx_spi_can_dma(struct spi_master *master, >> if (sdd->rx_dma.ch && sdd->tx_dma.ch) { >> return xfer->len > (FIFO_LVL_MASK(sdd) >> 1) + 1; >> } else { >> - return 0; >> + return false; >> } >> >> } > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Best regards, > Krzysztof
diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index 82558e37c735..28e7b7cb68a7 100644 --- a/drivers/spi/spi-s3c64xx.c +++ b/drivers/spi/spi-s3c64xx.c @@ -382,7 +382,7 @@ static bool s3c64xx_spi_can_dma(struct spi_master *master, if (sdd->rx_dma.ch && sdd->tx_dma.ch) { return xfer->len > (FIFO_LVL_MASK(sdd) >> 1) + 1; } else { - return 0; + return false; } }
Return boolean values ("true" or "false") instead of 1 or 0 from bool function. This fixes the following warnings from coccicheck: ./drivers/spi/spi-s3c64xx.c:385:9-10: WARNING: return of 0/1 in function 's3c64xx_spi_can_dma' with return type bool Reported-by: Abaci Robot <abaci@linux.alibaba.com> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/spi/spi-s3c64xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)