diff mbox series

scsi: ufs: exynos: constify driver data

Message ID 20220613101429.114449-1-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Commit dcad25cb2500d2fe1f9a9222ecb316f431e2e1c9
Headers show
Series scsi: ufs: exynos: constify driver data | expand

Commit Message

Krzysztof Kozlowski June 13, 2022, 10:14 a.m. UTC 
Constify the drv data because it should not be modified (used by
multiple devices).

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 drivers/ufs/host/ufs-exynos.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

Comments

Chanho Park June 13, 2022, 10:54 a.m. UTC | #1 
> Subject: [PATCH] scsi: ufs: exynos: constify driver data
> 
> Constify the drv data because it should not be modified (used by multiple
> devices).
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Reviewed-by: Chanho Park <chanho61.park@samsung.com>

Best Regards,
Chanho Park
Martin K. Petersen June 14, 2022, 2:09 a.m. UTC | #2 
Krzysztof,

> Constify the drv data because it should not be modified (used by
> multiple devices).

Applied to 5.20/scsi-staging, thanks!
Martin K. Petersen June 17, 2022, 2:21 a.m. UTC | #3 
On Mon, 13 Jun 2022 12:14:29 +0200, Krzysztof Kozlowski wrote:

> Constify the drv data because it should not be modified (used by
> multiple devices).
> 
> 

Applied to 5.20/scsi-queue, thanks!

[1/1] scsi: ufs: exynos: constify driver data
      https://git.kernel.org/mkp/scsi/c/dcad25cb2500
diff mbox series

Patch

diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c
index a81d8cbd542f..9fef706d896e 100644
--- a/drivers/ufs/host/ufs-exynos.c
+++ b/drivers/ufs/host/ufs-exynos.c
@@ -157,7 +157,6 @@  enum {
 
 #define CNTR_DIV_VAL 40
 
-static struct exynos_ufs_drv_data exynos_ufs_drvs;
 static void exynos_ufs_auto_ctrl_hcc(struct exynos_ufs *ufs, bool en);
 static void exynos_ufs_ctrl_clkstop(struct exynos_ufs *ufs, bool en);
 
@@ -1473,7 +1472,7 @@  static int exynosauto_ufs_vh_init(struct ufs_hba *hba)
 	return 0;
 }
 
-static struct ufs_hba_variant_ops ufs_hba_exynos_ops = {
+static const struct ufs_hba_variant_ops ufs_hba_exynos_ops = {
 	.name				= "exynos_ufs",
 	.init				= exynos_ufs_init,
 	.hce_enable_notify		= exynos_ufs_hce_enable_notify,
@@ -1545,7 +1544,7 @@  static struct exynos_ufs_uic_attr exynos7_uic_attr = {
 	.pa_dbg_option_suite		= 0x30103,
 };
 
-static struct exynos_ufs_drv_data exynosauto_ufs_drvs = {
+static const struct exynos_ufs_drv_data exynosauto_ufs_drvs = {
 	.uic_attr		= &exynos7_uic_attr,
 	.quirks			= UFSHCD_QUIRK_PRDT_BYTE_GRAN |
 				  UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR |
@@ -1561,7 +1560,7 @@  static struct exynos_ufs_drv_data exynosauto_ufs_drvs = {
 	.post_pwr_change	= exynosauto_ufs_post_pwr_change,
 };
 
-static struct exynos_ufs_drv_data exynosauto_ufs_vh_drvs = {
+static const struct exynos_ufs_drv_data exynosauto_ufs_vh_drvs = {
 	.vops			= &ufs_hba_exynosauto_vh_ops,
 	.quirks			= UFSHCD_QUIRK_PRDT_BYTE_GRAN |
 				  UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR |
@@ -1573,7 +1572,7 @@  static struct exynos_ufs_drv_data exynosauto_ufs_vh_drvs = {
 	.opts			= EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX,
 };
 
-static struct exynos_ufs_drv_data exynos_ufs_drvs = {
+static const struct exynos_ufs_drv_data exynos_ufs_drvs = {
 	.uic_attr		= &exynos7_uic_attr,
 	.quirks			= UFSHCD_QUIRK_PRDT_BYTE_GRAN |
 				  UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR |