diff mbox series

[1/5] ARM: dts: exynos: align SDHCI node name with dtschema

Message ID 20220626120342.38851-2-krzysztof.kozlowski@linaro.org (mailing list archive)
State Accepted
Commit c805b77caba9e49d43321112f272508d2b1acd25
Headers show
Series mmc: dt-bindings: samsung,s3c6410-sdhci: convert to dtschema | expand

Commit Message

Krzysztof Kozlowski June 26, 2022, 12:03 p.m. UTC 
The node names should be generic and DT schema expects "mmc".

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 arch/arm/boot/dts/exynos4.dtsi | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

Comments

Alim Akhtar June 27, 2022, 1:31 a.m. UTC | #1 
>-----Original Message-----
>From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>Sent: Sunday, June 26, 2022 5:34 PM
>To: Ulf Hansson <ulf.hansson@linaro.org>; Rob Herring
><robh+dt@kernel.org>; Krzysztof Kozlowski
><krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
><alim.akhtar@samsung.com>; Jaehoon Chung <jh80.chung@samsung.com>;
>linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux-
>kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>samsung-soc@vger.kernel.org
>Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>Subject: [PATCH 1/5] ARM: dts: exynos: align SDHCI node name with
>dtschema
>
>The node names should be generic and DT schema expects "mmc".
>
>Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>---

 (for patch 1 ~ 4)

Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>


> arch/arm/boot/dts/exynos4.dtsi | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/arch/arm/boot/dts/exynos4.dtsi
>b/arch/arm/boot/dts/exynos4.dtsi index 6f0ca3354e39..5c4ecda27a47 100644
>--- a/arch/arm/boot/dts/exynos4.dtsi
>+++ b/arch/arm/boot/dts/exynos4.dtsi
>@@ -316,7 +316,7 @@ keypad: keypad@100a0000 {
> 			status = "disabled";
> 		};
>
>-		sdhci_0: sdhci@12510000 {
>+		sdhci_0: mmc@12510000 {
> 			compatible = "samsung,exynos4210-sdhci";
> 			reg = <0x12510000 0x100>;
> 			interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
>@@ -325,7 +325,7 @@ sdhci_0: sdhci@12510000 {
> 			status = "disabled";
> 		};
>
>-		sdhci_1: sdhci@12520000 {
>+		sdhci_1: mmc@12520000 {
> 			compatible = "samsung,exynos4210-sdhci";
> 			reg = <0x12520000 0x100>;
> 			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
>@@ -334,7 +334,7 @@ sdhci_1: sdhci@12520000 {
> 			status = "disabled";
> 		};
>
>-		sdhci_2: sdhci@12530000 {
>+		sdhci_2: mmc@12530000 {
> 			compatible = "samsung,exynos4210-sdhci";
> 			reg = <0x12530000 0x100>;
> 			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
>@@ -343,7 +343,7 @@ sdhci_2: sdhci@12530000 {
> 			status = "disabled";
> 		};
>
>-		sdhci_3: sdhci@12540000 {
>+		sdhci_3: mmc@12540000 {
> 			compatible = "samsung,exynos4210-sdhci";
> 			reg = <0x12540000 0x100>;
> 			interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;
>--
>2.34.1
Krzysztof Kozlowski June 27, 2022, 8:55 a.m. UTC | #2 
On 27/06/2022 03:31, Alim Akhtar wrote:
> 
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
>> Sent: Sunday, June 26, 2022 5:34 PM
>> To: Ulf Hansson <ulf.hansson@linaro.org>; Rob Herring
>> <robh+dt@kernel.org>; Krzysztof Kozlowski
>> <krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar
>> <alim.akhtar@samsung.com>; Jaehoon Chung <jh80.chung@samsung.com>;
>> linux-mmc@vger.kernel.org; devicetree@vger.kernel.org; linux-
>> kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; linux-
>> samsung-soc@vger.kernel.org
>> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> Subject: [PATCH 1/5] ARM: dts: exynos: align SDHCI node name with
>> dtschema
>>
>> The node names should be generic and DT schema expects "mmc".
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>> ---
> 
>  (for patch 1 ~ 4)
> 
> Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>

Tooling does not handle such cases.

Best regards,
Krzysztof
Krzysztof Kozlowski June 27, 2022, 9:15 a.m. UTC | #3 
On Sun, 26 Jun 2022 14:03:38 +0200, Krzysztof Kozlowski wrote:
> The node names should be generic and DT schema expects "mmc".
> 
> 

Applied, thanks!

[1/5] ARM: dts: exynos: align SDHCI node name with dtschema
      https://git.kernel.org/krzk/linux/c/c805b77caba9e49d43321112f272508d2b1acd25

Best regards,
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos4.dtsi b/arch/arm/boot/dts/exynos4.dtsi
index 6f0ca3354e39..5c4ecda27a47 100644
--- a/arch/arm/boot/dts/exynos4.dtsi
+++ b/arch/arm/boot/dts/exynos4.dtsi
@@ -316,7 +316,7 @@  keypad: keypad@100a0000 {
 			status = "disabled";
 		};
 
-		sdhci_0: sdhci@12510000 {
+		sdhci_0: mmc@12510000 {
 			compatible = "samsung,exynos4210-sdhci";
 			reg = <0x12510000 0x100>;
 			interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
@@ -325,7 +325,7 @@  sdhci_0: sdhci@12510000 {
 			status = "disabled";
 		};
 
-		sdhci_1: sdhci@12520000 {
+		sdhci_1: mmc@12520000 {
 			compatible = "samsung,exynos4210-sdhci";
 			reg = <0x12520000 0x100>;
 			interrupts = <GIC_SPI 74 IRQ_TYPE_LEVEL_HIGH>;
@@ -334,7 +334,7 @@  sdhci_1: sdhci@12520000 {
 			status = "disabled";
 		};
 
-		sdhci_2: sdhci@12530000 {
+		sdhci_2: mmc@12530000 {
 			compatible = "samsung,exynos4210-sdhci";
 			reg = <0x12530000 0x100>;
 			interrupts = <GIC_SPI 75 IRQ_TYPE_LEVEL_HIGH>;
@@ -343,7 +343,7 @@  sdhci_2: sdhci@12530000 {
 			status = "disabled";
 		};
 
-		sdhci_3: sdhci@12540000 {
+		sdhci_3: mmc@12540000 {
 			compatible = "samsung,exynos4210-sdhci";
 			reg = <0x12540000 0x100>;
 			interrupts = <GIC_SPI 76 IRQ_TYPE_LEVEL_HIGH>;