| Message ID | 20220628220409.26545-2-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 22f3571cbc84b9150238a43d271ffbf7fad3d81d |
| Headers | show |
| Series | [1/2] phy: samsung: phy-exynos-pcie: sanitize init/power_on callbacks | expand |
> The proper initialization for generic PHYs is to call first phy_init(), > then phy_power_on(). > > While touching this, lets remove the phy_reset() call. It is just a left- > over from the obsoleted Exynos5440 support and current exynos-pcie PHY > driver doesn't even support this function. It is also rarely used by other > drivers. > > Reported-by: Bjorn Helgaas <helgaas@kernel.org> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Reviewed-by: Chanho Park <chanho61.park@samsung.com> Best Regards, Chanho Park
On 29/06/2022 00:04, Marek Szyprowski wrote: > The proper initialization for generic PHYs is to call first phy_init(), > then phy_power_on(). > > While touching this, lets remove the phy_reset() call. It is just a > left-over from the obsoleted Exynos5440 support and current exynos-pcie > PHY driver doesn't even support this function. It is also rarely used by > other drivers. > > Reported-by: Bjorn Helgaas <helgaas@kernel.org> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/drivers/pci/controller/dwc/pci-exynos.c b/drivers/pci/controller/dwc/pci-exynos.c index 467c8d1cd7e4..0d490ae52874 100644 --- a/drivers/pci/controller/dwc/pci-exynos.c +++ b/drivers/pci/controller/dwc/pci-exynos.c @@ -258,9 +258,8 @@ static int exynos_pcie_host_init(struct pcie_port *pp) exynos_pcie_assert_core_reset(ep); - phy_reset(ep->phy); - phy_power_on(ep->phy); phy_init(ep->phy); + phy_power_on(ep->phy); exynos_pcie_deassert_core_reset(ep); exynos_pcie_enable_irq_pulse(ep);
The proper initialization for generic PHYs is to call first phy_init(), then phy_power_on(). While touching this, lets remove the phy_reset() call. It is just a left-over from the obsoleted Exynos5440 support and current exynos-pcie PHY driver doesn't even support this function. It is also rarely used by other drivers. Reported-by: Bjorn Helgaas <helgaas@kernel.org> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- The exynos-pcie PHY driver has been adjusted for this change in the previous patch. --- drivers/pci/controller/dwc/pci-exynos.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)