diff mbox series

[08/10] drm/fbdev-generic: Minimize client unregistering

Message ID 20230123100559.12351-9-tzimmermann@suse.de (mailing list archive)
State New
Headers show
Series drm/fb-helper: Various cleanups | expand

Commit Message

Thomas Zimmermann Jan. 23, 2023, 10:05 a.m. UTC
For uninitialized framebuffers, only release the DRM client and
free the fbdev memory. Do not attempt to clean up the framebuffer.

DRM fbdev clients have a two-step initialization: first create
the DRM client; then create the framebuffer device on the first
successful hotplug event. In cases where the client never creates
the framebuffer, only the client state needs to be released. We
can detect which case it is, full or client-only cleanup, be
looking at the presence of fb_helper's info field.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
 drivers/gpu/drm/drm_fbdev_generic.c | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)
diff mbox series


diff --git a/drivers/gpu/drm/drm_fbdev_generic.c b/drivers/gpu/drm/drm_fbdev_generic.c
index dd8be5e0f271..bd5b59551c06 100644
--- a/drivers/gpu/drm/drm_fbdev_generic.c
+++ b/drivers/gpu/drm/drm_fbdev_generic.c
@@ -362,11 +362,13 @@  static void drm_fbdev_client_unregister(struct drm_client_dev *client)
 	struct drm_fb_helper *fb_helper = drm_fb_helper_from_client(client);
-	if (fb_helper->info)
-		/* drm_fbdev_fb_destroy() takes care of cleanup */
+	if (fb_helper->info) {
-	else
-		drm_fbdev_release(fb_helper);
+	} else {
+		drm_fb_helper_unprepare(fb_helper);
+		drm_client_release(&fb_helper->client);
+		kfree(fb_helper);
+	}
 static int drm_fbdev_client_restore(struct drm_client_dev *client)