| Message ID | 20230207205834.673163-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | b5babca2e64c39646d3937a8f83dd2a0d5fb8765 |
| Headers | show |
| Series | [v2,1/4] media: dt-bindings: samsung-fimc: drop simple-bus | expand |
On Tue, 07 Feb 2023 21:58:31 +0100, Krzysztof Kozlowski wrote: > The FIMC camera node wrapper is not a bus, so using simple-bus fallback > compatible just to instantiate its children nodes was never correct. > Drop the simple-bus compatible and expect driver to explicitly populate > children devices. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes since v1: > 1. None > --- > Documentation/devicetree/bindings/media/samsung-fimc.txt | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On 07/02/2023 21:58, Krzysztof Kozlowski wrote: > The FIMC camera node wrapper is not a bus, so using simple-bus fallback > compatible just to instantiate its children nodes was never correct. > Drop the simple-bus compatible and expect driver to explicitly populate > children devices. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Changes since v1: > 1. None > --- Mauro, Any comments on the patchset? Can you pick it up? Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/media/samsung-fimc.txt b/Documentation/devicetree/bindings/media/samsung-fimc.txt index 20447529c985..f90267f1180e 100644 --- a/Documentation/devicetree/bindings/media/samsung-fimc.txt +++ b/Documentation/devicetree/bindings/media/samsung-fimc.txt @@ -15,7 +15,7 @@ Common 'camera' node Required properties: -- compatible: must be "samsung,fimc", "simple-bus" +- compatible: must be "samsung,fimc" - clocks: list of clock specifiers, corresponding to entries in the clock-names property; - clock-names : must contain "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -156,8 +156,8 @@ Example: }; }; - camera { - compatible = "samsung,fimc", "simple-bus"; + camera@11800000 { + compatible = "samsung,fimc"; clocks = <&clock 132>, <&clock 133>, <&clock 351>, <&clock 352>; clock-names = "sclk_cam0", "sclk_cam1", "pxl_async0", @@ -166,6 +166,7 @@ Example: clock-output-names = "cam_a_clkout", "cam_b_clkout"; pinctrl-names = "default"; pinctrl-0 = <&cam_port_a_clk_active>; + ranges; #address-cells = <1>; #size-cells = <1>;
The FIMC camera node wrapper is not a bus, so using simple-bus fallback compatible just to instantiate its children nodes was never correct. Drop the simple-bus compatible and expect driver to explicitly populate children devices. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- Changes since v1: 1. None --- Documentation/devicetree/bindings/media/samsung-fimc.txt | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)