| Message ID | 20230708084027.18352-4-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Galaxy S2 (i9100) panel updates v2 | expand |
On 08/07/2023 10:40, Paul Cercueil wrote: > The previous values were completely bogus, and resulted in the computed > DPI ratio being much lower than reality, causing applications and UIs to > misbehave. > > The new values were measured by myself with a ruler. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2") > Cc: <stable@vger.kernel.org> # v5.8+ > --- This does not apply. You rebased your work on some older version/tree, without new layout. Please work on linux-next. Best regards, Krzysztof
Hi Krzysztof, Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a écrit : > On 08/07/2023 10:40, Paul Cercueil wrote: > > The previous values were completely bogus, and resulted in the > > computed > > DPI ratio being much lower than reality, causing applications and > > UIs to > > misbehave. > > > > The new values were measured by myself with a ruler. > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the > > Galaxy S2") > > Cc: <stable@vger.kernel.org> # v5.8+ > > --- > > This does not apply. You rebased your work on some older > version/tree, > without new layout. Please work on linux-next. This patchset was based on drm-misc-next, because that's where I was planning to apply it; and it was extremely unlikely (but not impossible, apparently) that the i9100.dts would be modified in the meantime. I can rebase on linux-next, the problem then is that I then don't know how/where to apply the patchset. Cheers, -Paul
On 10/07/2023 09:35, Paul Cercueil wrote: > Hi Krzysztof, > > Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a écrit : >> On 08/07/2023 10:40, Paul Cercueil wrote: >>> The previous values were completely bogus, and resulted in the >>> computed >>> DPI ratio being much lower than reality, causing applications and >>> UIs to >>> misbehave. >>> >>> The new values were measured by myself with a ruler. >>> >>> Signed-off-by: Paul Cercueil <paul@crapouillou.net> >>> Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the >>> Galaxy S2") >>> Cc: <stable@vger.kernel.org> # v5.8+ >>> --- >> >> This does not apply. You rebased your work on some older >> version/tree, >> without new layout. Please work on linux-next. > > This patchset was based on drm-misc-next, because that's where I was > planning to apply it; and it was extremely unlikely (but not > impossible, apparently) that the i9100.dts would be modified in the > meantime. > > I can rebase on linux-next, the problem then is that I then don't know > how/where to apply the patchset. DTS cannot go via drm-misc-next, so if that's your intention please always split the patchset into separate ones. *Always*. Best regards, Krzysztof
Le lundi 10 juillet 2023 à 09:45 +0200, Krzysztof Kozlowski a écrit : > On 10/07/2023 09:35, Paul Cercueil wrote: > > Hi Krzysztof, > > > > Le lundi 10 juillet 2023 à 08:59 +0200, Krzysztof Kozlowski a > > écrit : > > > On 08/07/2023 10:40, Paul Cercueil wrote: > > > > The previous values were completely bogus, and resulted in the > > > > computed > > > > DPI ratio being much lower than reality, causing applications > > > > and > > > > UIs to > > > > misbehave. > > > > > > > > The new values were measured by myself with a ruler. > > > > > > > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > > > Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for > > > > the > > > > Galaxy S2") > > > > Cc: <stable@vger.kernel.org> # v5.8+ > > > > --- > > > > > > This does not apply. You rebased your work on some older > > > version/tree, > > > without new layout. Please work on linux-next. > > > > This patchset was based on drm-misc-next, because that's where I > > was > > planning to apply it; and it was extremely unlikely (but not > > impossible, apparently) that the i9100.dts would be modified in the > > meantime. > > > > I can rebase on linux-next, the problem then is that I then don't > > know > > how/where to apply the patchset. > > DTS cannot go via drm-misc-next, so if that's your intention please > always split the patchset into separate ones. *Always*. Noted. Then I'll apply the patches [1/3] and [2/3] to drm-misc-next since I have my ACKs, and re-send patch [3/3] as standalone and rebased on linux-next. Cheers, -Paul
diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts index 37cd4dde53e4..a9ec1f6c1dea 100644 --- a/arch/arm/boot/dts/exynos4210-i9100.dts +++ b/arch/arm/boot/dts/exynos4210-i9100.dts @@ -207,8 +207,8 @@ lcd@0 { power-on-delay = <10>; reset-delay = <10>; - panel-width-mm = <90>; - panel-height-mm = <154>; + panel-width-mm = <56>; + panel-height-mm = <93>; display-timings { timing {
The previous values were completely bogus, and resulted in the computed DPI ratio being much lower than reality, causing applications and UIs to misbehave. The new values were measured by myself with a ruler. Signed-off-by: Paul Cercueil <paul@crapouillou.net> Fixes: 8620cc2f99b7 ("ARM: dts: exynos: Add devicetree file for the Galaxy S2") Cc: <stable@vger.kernel.org> # v5.8+ --- arch/arm/boot/dts/exynos4210-i9100.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)