diff mbox series

[1/7] ARM: dts: exynos: k3g: Add WiFi card support

Message ID 20230716220644.22158-2-markuss.broks@gmail.com (mailing list archive)
State New
Headers show
Series Add various peripheral support for K3G | expand

Commit Message

Markuss Broks July 16, 2023, 10:05 p.m. UTC
This device has Broadcom BCM4354 WiFi card installed,
which uses SDIO interface.

Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
---
 arch/arm/boot/dts/exynos5422-samsung-k3g.dts | 29 ++++++++++++++++++++
 1 file changed, 29 insertions(+)

Comments

Krzysztof Kozlowski July 19, 2023, 9:04 a.m. UTC | #1
On 17/07/2023 00:05, Markuss Broks wrote:
> This device has Broadcom BCM4354 WiFi card installed,
> which uses SDIO interface.
> 
> Signed-off-by: Markuss Broks <markuss.broks@gmail.com>
> ---


>  &pinctrl_0 {
>  	s2mps11_irq: s2mps11-irq-pins {
>  		samsung,pins = "gpx0-7";
> @@ -628,6 +652,11 @@ touch_irq: touch-irq-pins {
>  		samsung,pins = "gpx1-6";
>  		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
>  	};
> +
> +	wlan_reset: wlan-reset {

It does not look like you tested the DTS against bindings. Please run
`make dtbs_check` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).

This is a requirement since few months (half a year?).

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/exynos5422-samsung-k3g.dts b/arch/arm/boot/dts/exynos5422-samsung-k3g.dts
index c35261a338ff..1a11a6993ba7 100644
--- a/arch/arm/boot/dts/exynos5422-samsung-k3g.dts
+++ b/arch/arm/boot/dts/exynos5422-samsung-k3g.dts
@@ -48,6 +48,13 @@  tsp_vdd: regulator-tsp-vdd-en {
 		gpio = <&gpy3 5 GPIO_ACTIVE_HIGH>;
 		enable-active-high;
 	};
+
+	wlan_pwrseq: wlan-pwrseq {
+		compatible = "mmc-pwrseq-simple";
+		reset-gpios = <&gpy7 7 GPIO_ACTIVE_LOW>; /* WIFI_EN */
+		clocks = <&s2mps11_osc S2MPS11_CLK_BT>; /* Used not only for Bluetooth */
+		clock-names = "ext_clock";
+	};
 };
 
 &cpu0 {
@@ -616,6 +623,23 @@  &mmc_0 {
 	bus-width = <8>;
 };
 
+/* WiFi SDIO module */
+&mmc_1 {
+	status = "okay";
+	cap-sdio-irq;
+	cap-sd-highspeed;
+	non-removable;
+	samsung,dw-mshc-ciu-div = <1>;
+	samsung,dw-mshc-sdr-timing = <0 1>;
+	samsung,dw-mshc-ddr-timing = <0 2>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&sd1_clk>, <&sd1_cmd>, <&sd1_int>, <&sd1_bus1>,
+			<&sd1_bus4>, <&wlan_reset>;
+	bus-width = <4>;
+	vqmmc-supply = <&ldo3_reg>;
+	mmc-pwrseq = <&wlan_pwrseq>;
+};
+
 &pinctrl_0 {
 	s2mps11_irq: s2mps11-irq-pins {
 		samsung,pins = "gpx0-7";
@@ -628,6 +652,11 @@  touch_irq: touch-irq-pins {
 		samsung,pins = "gpx1-6";
 		samsung,pin-pud = <EXYNOS_PIN_PULL_DOWN>;
 	};
+
+	wlan_reset: wlan-reset {
+		samsung,pins = "gpy7-7";
+		samsung,pin-pud = <EXYNOS_PIN_PULL_NONE>;
+	};
 };
 
 &rtc {