| Message ID | 20240618-starqltechn_integration_upstream-v3-9-e3f6662017ac@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | This is continued work on Samsung S9(SM-9600) starqltechn | expand |
On Tue, 18 Jun 2024 16:59:43 +0300, Dzmitry Sankouski wrote: > add samsung,s2dos05 core MFD module binding > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > --- > .../devicetree/bindings/mfd/samsung,s2dos05.yaml | 89 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 90 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/mfd/samsung,s2dos05.example.dtb: /example-0/i2c/pmic@60: failed to match any schema with compatible: ['samsung,s2dos05'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240618-starqltechn_integration_upstream-v3-9-e3f6662017ac@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 18/06/2024 15:59, Dzmitry Sankouski wrote: > add samsung,s2dos05 core MFD module binding > > Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> > --- > .../devicetree/bindings/mfd/samsung,s2dos05.yaml | 89 ++++++++++++++++++++++ > MAINTAINERS | 1 + > 2 files changed, 90 insertions(+) > > diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml b/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml > new file mode 100644 > index 000000000000..f2ef5171cc40 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml > @@ -0,0 +1,89 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/samsung,s2dos05.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung S2DOS05 Power Management IC > + > +maintainers: > + - Dzmitry Sankouski <dsankouski@gmail.com> > + > +description: > + This is a part of device tree bindings for S2M and S5M family of Power > + Management IC (PMIC). No, it is not. > + > + The S2DOS05 is a companion power management IC for the panel and touchscreen > + in smart phones. Provides voltage and current regulators and adc for power/current > + measurements. > + > +properties: > + compatible: > + const: samsung,s2dos05-pmic s2dos05 cannot be anything else than pmic. Drop the suffix. > + > + reg: > + maxItems: 1 > + > + regulators: > + $ref: /schemas/regulator/samsung,s2dos05.yaml > + description: List of regulators and its properties > + > +required: > + - compatible > + - reg > + - regulators > + > +additionalProperties: false > + > +examples: > + - | > + i2c { > + #address-cells = <1>; > + #size-cells = <0>; > + > + pmic@60 { > + compatible = "samsung,s2dos05"; > + reg = <0x60>; > + > + regulators { Messed indentation. Everywhere, each of your patch. > + s2dos05_ldo1: s2dos05-ldo1 { Just "ldo1" and drop unused labels. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml b/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml new file mode 100644 index 000000000000..f2ef5171cc40 --- /dev/null +++ b/Documentation/devicetree/bindings/mfd/samsung,s2dos05.yaml @@ -0,0 +1,89 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/mfd/samsung,s2dos05.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung S2DOS05 Power Management IC + +maintainers: + - Dzmitry Sankouski <dsankouski@gmail.com> + +description: + This is a part of device tree bindings for S2M and S5M family of Power + Management IC (PMIC). + + The S2DOS05 is a companion power management IC for the panel and touchscreen + in smart phones. Provides voltage and current regulators and adc for power/current + measurements. + +properties: + compatible: + const: samsung,s2dos05-pmic + + reg: + maxItems: 1 + + regulators: + $ref: /schemas/regulator/samsung,s2dos05.yaml + description: List of regulators and its properties + +required: + - compatible + - reg + - regulators + +additionalProperties: false + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pmic@60 { + compatible = "samsung,s2dos05"; + reg = <0x60>; + + regulators { + s2dos05_ldo1: s2dos05-ldo1 { + regulator-name = "s2dos05-ldo1"; + regulator-min-microvolt = <1500000>; + regulator-max-microvolt = <2000000>; + regulator-active-discharge = <0x1>; + }; + + s2dos05_ldo2: s2dos05-ldo2 { + regulator-name = "s2dos05-ldo2"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-active-discharge = <0x1>; + regulator-boot-on; + }; + + s2dos05_ldo3: s2dos05-ldo3 { + regulator-name = "s2dos05-ldo3"; + regulator-min-microvolt = <3000000>; + regulator-max-microvolt = <3000000>; + regulator-active-discharge = <0x1>; + regulator-boot-on; + }; + + s2dos05_ldo4: s2dos05-ldo4 { + regulator-name = "s2dos05-ldo4"; + regulator-min-microvolt = <2700000>; + regulator-max-microvolt = <3775000>; + regulator-active-discharge = <0x1>; + }; + + s2dos05_buck1: s2dos05-buck1 { + regulator-name = "s2dos05-buck1"; + regulator-min-microvolt = <850000>; + regulator-max-microvolt = <2100000>; + regulator-active-discharge = <0x1>; + }; + }; + }; + }; + +... diff --git a/MAINTAINERS b/MAINTAINERS index f008429033c9..3ab41e53c9fc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19897,6 +19897,7 @@ L: linux-samsung-soc@vger.kernel.org S: Maintained B: mailto:linux-samsung-soc@vger.kernel.org F: Documentation/devicetree/bindings/clock/samsung,s2mps11.yaml +F: Documentation/devicetree/bindings/mfd/samsung,s2dos*.yaml F: Documentation/devicetree/bindings/mfd/samsung,s2m*.yaml F: Documentation/devicetree/bindings/mfd/samsung,s5m*.yaml F: Documentation/devicetree/bindings/regulator/samsung,s2m*.yaml
add samsung,s2dos05 core MFD module binding Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com> --- .../devicetree/bindings/mfd/samsung,s2dos05.yaml | 89 ++++++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 90 insertions(+)