| Message ID | 20250215122409.162810-2-ivo.ivanov.ivanov1@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | phy: samsung: add Exynos2200 SNPS eUSB2 driver | expand |
On Sat, 15 Feb 2025 14:24:06 +0200, Ivaylo Ivanov wrote: > The Exynos2200 SoC uses Synopsis eUSB2 PHY. Add a dt-binding schema > for the new driver. > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > --- > .../samsung,exynos2200-snps-eusb2-phy.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.example.dts:18:18: fatal error: dt-bindings/clock/samsung,exynos2200.h: No such file or directory 18 | #include <dt-bindings/clock/samsung,exynos2200.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [scripts/Makefile.dtbs:131: Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1511: dt_binding_check] Error 2 make: *** [Makefile:251: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250215122409.162810-2-ivo.ivanov.ivanov1@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Sat Feb 15, 2025 at 1:24 PM CET, Ivaylo Ivanov wrote: > The Exynos2200 SoC uses Synopsis eUSB2 PHY. Add a dt-binding schema > for the new driver. > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > --- > .../samsung,exynos2200-snps-eusb2-phy.yaml | 75 +++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml > > diff --git a/Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml > new file mode 100644 > index 000000000..d69a10f00 > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml > @@ -0,0 +1,75 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/phy/samsung,exynos2200-snps-eusb2-phy.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Samsung SNPS eUSB2 phy controller > + > +maintainers: > + - Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > + > +description: > + eUSB2 controller supports LS/FS/HS usb connectivity on Exynos chipsets. > + > +properties: > + compatible: > + enum: > + - samsung,exynos2200-snps-eusb2-phy > + > + reg: > + maxItems: 1 > + > + "#phy-cells": > + const: 0 > + > + clocks: > + items: > + - description: Reference clock > + - description: APB clock > + - description: Control PCLK > + > + clock-names: > + items: > + - const: ref > + - const: apb > + - const: ctrl > + > + phys: > + maxItems: 1 > + description: > + Phandle to USBCON phy > + > + vdd-supply: > + description: > + Phandle to 0.88V regulator supply > + > + vdda12-supply: > + description: > + Phandle to 1.2V regulator supply > + > +required: > + - compatible > + - reg > + - "#phy-cells" > + - clocks > + - clock-names > + - vdd-supply > + - vdda12-supply > + > +additionalProperties: false > + > +examples: > + - | > + #include <dt-bindings/clock/samsung,exynos2200.h> > + > + usb_hsphy: phy@10ab0000 { > + compatible = "samsung,exynos2200-snps-eusb2-phy"; > + reg = <0 0x10ab0000 0 0x10000>; > + clocks = <&cmu_hsi0 CLK_MOUT_HSI0_USB32DRD>, > + <&cmu_hsi0 CLK_MOUT_HSI0_NOC>, > + <&cmu_hsi0 CLK_DOUT_DIV_CLK_HSI0_EUSB>; > + clock-names = "ref", "apb", "ctrl"; > + #phy-cells = <0>; > + phys = <&usbcon_phy>; > + }; Shouldn't the example have at least all the *required* properties? Same for patch 2 of this series. Cheers, Diederik
On 16/02/2025 10:14, Diederik de Haas wrote: >> +examples: >> + - | >> + #include <dt-bindings/clock/samsung,exynos2200.h> >> + >> + usb_hsphy: phy@10ab0000 { >> + compatible = "samsung,exynos2200-snps-eusb2-phy"; >> + reg = <0 0x10ab0000 0 0x10000>; >> + clocks = <&cmu_hsi0 CLK_MOUT_HSI0_USB32DRD>, >> + <&cmu_hsi0 CLK_MOUT_HSI0_NOC>, >> + <&cmu_hsi0 CLK_DOUT_DIV_CLK_HSI0_EUSB>; >> + clock-names = "ref", "apb", "ctrl"; >> + #phy-cells = <0>; >> + phys = <&usbcon_phy>; >> + }; > > Shouldn't the example have at least all the *required* properties? > Same for patch 2 of this series. Yeah, this wasn't ever tested. Best regards, Krzysztof
On 2/16/25 11:22, Krzysztof Kozlowski wrote: > On 16/02/2025 10:14, Diederik de Haas wrote: >>> +examples: >>> + - | >>> + #include <dt-bindings/clock/samsung,exynos2200.h> >>> + >>> + usb_hsphy: phy@10ab0000 { >>> + compatible = "samsung,exynos2200-snps-eusb2-phy"; >>> + reg = <0 0x10ab0000 0 0x10000>; >>> + clocks = <&cmu_hsi0 CLK_MOUT_HSI0_USB32DRD>, >>> + <&cmu_hsi0 CLK_MOUT_HSI0_NOC>, >>> + <&cmu_hsi0 CLK_DOUT_DIV_CLK_HSI0_EUSB>; >>> + clock-names = "ref", "apb", "ctrl"; >>> + #phy-cells = <0>; >>> + phys = <&usbcon_phy>; >>> + }; >> Shouldn't the example have at least all the *required* properties? >> Same for patch 2 of this series. > > Yeah, this wasn't ever tested. Device trees were tested with dtbs_check W=1 but I overlooked testing bindings with dt_bindings_check. Anyways this is rather a small problem, will be fixed in a v2. Best regards, Ivaylo > > Best regards, > Krzysztof
On 16/02/2025 10:27, Ivaylo Ivanov wrote: > On 2/16/25 11:22, Krzysztof Kozlowski wrote: >> On 16/02/2025 10:14, Diederik de Haas wrote: >>>> +examples: >>>> + - | >>>> + #include <dt-bindings/clock/samsung,exynos2200.h> >>>> + >>>> + usb_hsphy: phy@10ab0000 { >>>> + compatible = "samsung,exynos2200-snps-eusb2-phy"; >>>> + reg = <0 0x10ab0000 0 0x10000>; >>>> + clocks = <&cmu_hsi0 CLK_MOUT_HSI0_USB32DRD>, >>>> + <&cmu_hsi0 CLK_MOUT_HSI0_NOC>, >>>> + <&cmu_hsi0 CLK_DOUT_DIV_CLK_HSI0_EUSB>; >>>> + clock-names = "ref", "apb", "ctrl"; >>>> + #phy-cells = <0>; >>>> + phys = <&usbcon_phy>; >>>> + }; >>> Shouldn't the example have at least all the *required* properties? >>> Same for patch 2 of this series. >> >> Yeah, this wasn't ever tested. > > Device trees were tested with dtbs_check W=1 but I overlooked testing bindings > with dt_bindings_check. Anyways this is rather a small problem, will be fixed > in a v2. > This makes the bindings unreviewable and they will be marked as "changes requested". Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml b/Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml new file mode 100644 index 000000000..d69a10f00 --- /dev/null +++ b/Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml @@ -0,0 +1,75 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/phy/samsung,exynos2200-snps-eusb2-phy.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Samsung SNPS eUSB2 phy controller + +maintainers: + - Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> + +description: + eUSB2 controller supports LS/FS/HS usb connectivity on Exynos chipsets. + +properties: + compatible: + enum: + - samsung,exynos2200-snps-eusb2-phy + + reg: + maxItems: 1 + + "#phy-cells": + const: 0 + + clocks: + items: + - description: Reference clock + - description: APB clock + - description: Control PCLK + + clock-names: + items: + - const: ref + - const: apb + - const: ctrl + + phys: + maxItems: 1 + description: + Phandle to USBCON phy + + vdd-supply: + description: + Phandle to 0.88V regulator supply + + vdda12-supply: + description: + Phandle to 1.2V regulator supply + +required: + - compatible + - reg + - "#phy-cells" + - clocks + - clock-names + - vdd-supply + - vdda12-supply + +additionalProperties: false + +examples: + - | + #include <dt-bindings/clock/samsung,exynos2200.h> + + usb_hsphy: phy@10ab0000 { + compatible = "samsung,exynos2200-snps-eusb2-phy"; + reg = <0 0x10ab0000 0 0x10000>; + clocks = <&cmu_hsi0 CLK_MOUT_HSI0_USB32DRD>, + <&cmu_hsi0 CLK_MOUT_HSI0_NOC>, + <&cmu_hsi0 CLK_DOUT_DIV_CLK_HSI0_EUSB>; + clock-names = "ref", "apb", "ctrl"; + #phy-cells = <0>; + phys = <&usbcon_phy>; + };
The Exynos2200 SoC uses Synopsis eUSB2 PHY. Add a dt-binding schema for the new driver. Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> --- .../samsung,exynos2200-snps-eusb2-phy.yaml | 75 +++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 Documentation/devicetree/bindings/phy/samsung,exynos2200-snps-eusb2-phy.yaml