| Message ID | 20250215130500.170738-2-ivo.ivanov.ivanov1@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | arm64: dts: exynos: add initial support for Samsung Galaxy S22+ | expand |
On 15/02/2025 14:04, Ivaylo Ivanov wrote: > Add binding for the Samsung Galaxy S22+ (SM-S906B) board, which is > based on the Samsung Exynos2200 SoC. > > Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> > --- > .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > index fab29f95d..bb3f6a0e1 100644 > --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml > @@ -45,6 +45,12 @@ properties: > - const: samsung,aries > - const: samsung,s5pv210 > > + - description: Exynos2200 based boards > + items: > + - enum: > + - samsung,g0s # Samsung Galaxy S22+ (SM-S906B) What does g0s stand for? Sound a bit cryptic and you did not use it in commit msg to explain the origin. Best regards, Krzysztof
On 2/19/25 10:35, Krzysztof Kozlowski wrote: > On 15/02/2025 14:04, Ivaylo Ivanov wrote: >> Add binding for the Samsung Galaxy S22+ (SM-S906B) board, which is >> based on the Samsung Exynos2200 SoC. >> >> Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> >> --- >> .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >> index fab29f95d..bb3f6a0e1 100644 >> --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >> +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml >> @@ -45,6 +45,12 @@ properties: >> - const: samsung,aries >> - const: samsung,s5pv210 >> >> + - description: Exynos2200 based boards >> + items: >> + - enum: >> + - samsung,g0s # Samsung Galaxy S22+ (SM-S906B) > > What does g0s stand for? Samsung started codenaming their S series like that since ~S20. I'd actually much rather use something like samsung,s22p but since 990 devices upstream already use the weird codenames, I've decided to do the same. I'll mention G0S it in the commit message next revision. Best regards, Ivaylo > Sound a bit cryptic and you did not use it in > commit msg to explain the origin. > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml index fab29f95d..bb3f6a0e1 100644 --- a/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml +++ b/Documentation/devicetree/bindings/arm/samsung/samsung-boards.yaml @@ -45,6 +45,12 @@ properties: - const: samsung,aries - const: samsung,s5pv210 + - description: Exynos2200 based boards + items: + - enum: + - samsung,g0s # Samsung Galaxy S22+ (SM-S906B) + - const: samsung,exynos2200 + - description: Exynos3250 based boards items: - enum:
Add binding for the Samsung Galaxy S22+ (SM-S906B) board, which is based on the Samsung Exynos2200 SoC. Signed-off-by: Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> --- .../devicetree/bindings/arm/samsung/samsung-boards.yaml | 6 ++++++ 1 file changed, 6 insertions(+)