| Message ID | 20250403-s2mpg10-v3-23-b542b3505e68@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Samsung S2MPG10 PMIC MFD-based drivers | expand |
On Thu, 03 Apr 2025, André Draszik wrote: > Add myself as module author, so people know whom to complain to about > after the recent updates :-) Full-stop. Smiley faces might be okay on the list, but not sure we want them in commit messages. > Signed-off-by: André Draszik <andre.draszik@linaro.org> > --- > drivers/mfd/sec-common.c | 1 + > drivers/mfd/sec-i2c.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c > index 448300ab547c10d81f9f2b2798d54c8a03c714d8..05658f05cb857a784c7d01b1cf25de4870e1a95e 100644 > --- a/drivers/mfd/sec-common.c > +++ b/drivers/mfd/sec-common.c > @@ -293,6 +293,7 @@ static int sec_pmic_resume(struct device *dev) > DEFINE_SIMPLE_DEV_PM_OPS(sec_pmic_pm_ops, sec_pmic_suspend, sec_pmic_resume); > EXPORT_SYMBOL_GPL(sec_pmic_pm_ops); > > +MODULE_AUTHOR("André Draszik <andre.draszik@linaro.org>"); Might be more polite to put yourself at the bottom. Not sure these are ordered alphabetically on purpose. > MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>"); > MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>"); > MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>"); > diff --git a/drivers/mfd/sec-i2c.c b/drivers/mfd/sec-i2c.c > index 2ccb494c8c024361c78e92be71ce9c215757dd89..74fd28a6bc9a42879fc1eb05546777f60e0062e9 100644 > --- a/drivers/mfd/sec-i2c.c > +++ b/drivers/mfd/sec-i2c.c > @@ -233,6 +233,7 @@ static struct i2c_driver sec_pmic_i2c_driver = { > }; > module_i2c_driver(sec_pmic_i2c_driver); > > +MODULE_AUTHOR("André Draszik <andre.draszik@linaro.org>"); > MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>"); > MODULE_DESCRIPTION("I2C driver for the Samsung S5M"); > MODULE_LICENSE("GPL"); > > -- > 2.49.0.472.ge94155a9ec-goog >
On Fri, 2025-04-04 at 10:42 +0100, Lee Jones wrote: > On Thu, 03 Apr 2025, André Draszik wrote: > > > Add myself as module author, so people know whom to complain to about > > after the recent updates :-) > > Full-stop. > > Smiley faces might be okay on the list, but not sure we want them in > commit messages. OK. > > > Signed-off-by: André Draszik <andre.draszik@linaro.org> > > --- > > drivers/mfd/sec-common.c | 1 + > > drivers/mfd/sec-i2c.c | 1 + > > 2 files changed, 2 insertions(+) > > > > diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c > > index 448300ab547c10d81f9f2b2798d54c8a03c714d8..05658f05cb857a784c7d01b1cf25de4870e1a95e 100644 > > --- a/drivers/mfd/sec-common.c > > +++ b/drivers/mfd/sec-common.c > > @@ -293,6 +293,7 @@ static int sec_pmic_resume(struct device *dev) > > DEFINE_SIMPLE_DEV_PM_OPS(sec_pmic_pm_ops, sec_pmic_suspend, sec_pmic_resume); > > EXPORT_SYMBOL_GPL(sec_pmic_pm_ops); > > > > +MODULE_AUTHOR("André Draszik <andre.draszik@linaro.org>"); > > Might be more polite to put yourself at the bottom. > > Not sure these are ordered alphabetically on purpose. Yes, I wanted to keep the alphabetical order (by first name), no ill intention here. Will do. Cheers, A. > > > MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>"); > > MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>"); > > MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>");
diff --git a/drivers/mfd/sec-common.c b/drivers/mfd/sec-common.c index 448300ab547c10d81f9f2b2798d54c8a03c714d8..05658f05cb857a784c7d01b1cf25de4870e1a95e 100644 --- a/drivers/mfd/sec-common.c +++ b/drivers/mfd/sec-common.c @@ -293,6 +293,7 @@ static int sec_pmic_resume(struct device *dev) DEFINE_SIMPLE_DEV_PM_OPS(sec_pmic_pm_ops, sec_pmic_suspend, sec_pmic_resume); EXPORT_SYMBOL_GPL(sec_pmic_pm_ops); +MODULE_AUTHOR("André Draszik <andre.draszik@linaro.org>"); MODULE_AUTHOR("Chanwoo Choi <cw00.choi@samsung.com>"); MODULE_AUTHOR("Krzysztof Kozlowski <krzk@kernel.org>"); MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>"); diff --git a/drivers/mfd/sec-i2c.c b/drivers/mfd/sec-i2c.c index 2ccb494c8c024361c78e92be71ce9c215757dd89..74fd28a6bc9a42879fc1eb05546777f60e0062e9 100644 --- a/drivers/mfd/sec-i2c.c +++ b/drivers/mfd/sec-i2c.c @@ -233,6 +233,7 @@ static struct i2c_driver sec_pmic_i2c_driver = { }; module_i2c_driver(sec_pmic_i2c_driver); +MODULE_AUTHOR("André Draszik <andre.draszik@linaro.org>"); MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>"); MODULE_DESCRIPTION("I2C driver for the Samsung S5M"); MODULE_LICENSE("GPL");
Add myself as module author, so people know whom to complain to about after the recent updates :-) Signed-off-by: André Draszik <andre.draszik@linaro.org> --- drivers/mfd/sec-common.c | 1 + drivers/mfd/sec-i2c.c | 1 + 2 files changed, 2 insertions(+)