| Message ID | 20250403-s2mpg10-v3-6-b542b3505e68@linaro.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | Samsung S2MPG10 PMIC MFD-based drivers | expand |
On 03/04/2025 10:58, André Draszik wrote: > This driver misses to include some of the respective headers of some of > the APIs used. It also includes headers that aren't needed (e.g. due to > previous driver rework where includes weren't updated). > > It is good practice to directly include all headers used, which avoids > implicit dependencies and spurious build breakage if someone rearranged > headers, as this could cause the implicit includes to be dropped. > > Include the relevant headers explicitly and drop superfluous ones. > > Signed-off-by: André Draszik <andre.draszik@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c index e31b3a6fbc8922e04a8bfcb78c85b6dbaf395e37..b12020c416aa8bf552f3d3b7829f6a38a773f674 100644 --- a/drivers/mfd/sec-core.c +++ b/drivers/mfd/sec-core.c @@ -3,9 +3,9 @@ // Copyright (c) 2012 Samsung Electronics Co., Ltd // http://www.samsung.com +#include <linux/device.h> #include <linux/err.h> #include <linux/i2c.h> -#include <linux/init.h> #include <linux/interrupt.h> #include <linux/mfd/core.h> #include <linux/mfd/samsung/core.h> @@ -17,13 +17,12 @@ #include <linux/mfd/samsung/s2mps15.h> #include <linux/mfd/samsung/s2mpu02.h> #include <linux/mfd/samsung/s5m8767.h> +#include <linux/mod_devicetable.h> #include <linux/module.h> -#include <linux/moduleparam.h> -#include <linux/mutex.h> #include <linux/of.h> +#include <linux/pm.h> #include <linux/pm_runtime.h> #include <linux/regmap.h> -#include <linux/slab.h> static const struct mfd_cell s5m8767_devs[] = { { .name = "s5m8767-pmic", }, diff --git a/drivers/mfd/sec-irq.c b/drivers/mfd/sec-irq.c index 5c0d949aa1a20f5538d8baf7a8aefc1160ffa14c..3ed2902c3a2634a6ea656d890ecea934053bd192 100644 --- a/drivers/mfd/sec-irq.c +++ b/drivers/mfd/sec-irq.c @@ -3,7 +3,10 @@ // Copyright (c) 2011-2014 Samsung Electronics Co., Ltd // http://www.samsung.com -#include <linux/device.h> +#include <linux/array_size.h> +#include <linux/build_bug.h> +#include <linux/dev_printk.h> +#include <linux/export.h> #include <linux/interrupt.h> #include <linux/irq.h> #include <linux/mfd/samsung/core.h>
This driver misses to include some of the respective headers of some of the APIs used. It also includes headers that aren't needed (e.g. due to previous driver rework where includes weren't updated). It is good practice to directly include all headers used, which avoids implicit dependencies and spurious build breakage if someone rearranged headers, as this could cause the implicit includes to be dropped. Include the relevant headers explicitly and drop superfluous ones. Signed-off-by: André Draszik <andre.draszik@linaro.org> --- drivers/mfd/sec-core.c | 7 +++---- drivers/mfd/sec-irq.c | 5 ++++- 2 files changed, 7 insertions(+), 5 deletions(-)