| Message ID | 20250407110516.41124-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3] media: platform: exynos4-is: Use of_get_available_child_by_name() | expand |
On 07/04/2025 13:05, Biju Das wrote: > Simplify fimc_md_is_isp_available() by using > of_get_available_child_by_name(). > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > --- > v2->v3: > * Fixed CHECK: Comparison to NULL could be written "child" reoported by > [1] https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/74116132/artifacts/report.htm > * Dropped Rb tag from Krzysztof. And what is the reason? Minor tweak for checkpatch? Really? Please follow closely submitting patches about review tags. Best regards, Krzysztof
Hi Krzysztof, > -----Original Message----- > From: Krzysztof Kozlowski <krzk@kernel.org> > Sent: 07 April 2025 14:30 > Subject: Re: [PATCH v3] media: platform: exynos4-is: Use of_get_available_child_by_name() > > On 07/04/2025 13:05, Biju Das wrote: > > Simplify fimc_md_is_isp_available() by using > > of_get_available_child_by_name(). > > > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> > > --- > > v2->v3: > > * Fixed CHECK: Comparison to NULL could be written "child" reoported by > > [1] > > https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/741 > > 16132/artifacts/report.htm > > * Dropped Rb tag from Krzysztof. > And what is the reason? Minor tweak for checkpatch? Really? Just to have your second opinion, I dropped the Rb tag even though it is minor as the patch got rejected see[1]. [1] Thanks for your patches! Unfortunately the Media CI robot detected some issues: # Test checkpatch:./0001-media-platform-exynos4-is-Use-of_get_available_child.patch checkpatch CHECK: Comparison to NULL could be written "child" #28: FILE: drivers/media/platform/samsung/exynos4-is/media-dev.h:183: +return child != NULL; total: 0 errors, 0 warnings, 1 checks, 10 lines checked Please fix your series, and upload a new version. If you have a patchwork account, do not forget to mark the current series as Superseded. For more details, check the full report at: https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/74116132/artifacts/report.htm . Cheers, Biju
diff --git a/drivers/media/platform/samsung/exynos4-is/media-dev.h b/drivers/media/platform/samsung/exynos4-is/media-dev.h index a50e58ab7ef7..ea496670d4b5 100644 --- a/drivers/media/platform/samsung/exynos4-is/media-dev.h +++ b/drivers/media/platform/samsung/exynos4-is/media-dev.h @@ -179,8 +179,8 @@ int fimc_md_set_camclk(struct v4l2_subdev *sd, bool on); static inline bool fimc_md_is_isp_available(struct device_node *node) { struct device_node *child __free(device_node) = - of_get_child_by_name(node, FIMC_IS_OF_NODE_NAME); - return child ? of_device_is_available(child) : false; + of_get_available_child_by_name(node, FIMC_IS_OF_NODE_NAME); + return child; } #else #define fimc_md_is_isp_available(node) (false)
Simplify fimc_md_is_isp_available() by using of_get_available_child_by_name(). Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com> --- v2->v3: * Fixed CHECK: Comparison to NULL could be written "child" reoported by [1] https://linux-media.pages.freedesktop.org/-/users/patchwork/-/jobs/74116132/artifacts/report.htm * Dropped Rb tag from Krzysztof. v1->v2: * Rebased to next as the dependency patch hits on 6.15-rc1. --- drivers/media/platform/samsung/exynos4-is/media-dev.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)